All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Magnus Damm <magnus.damm@gmail.com>,
	linux-renesas-soc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: renesas: Fix pin controller node names
Date: Fri, 21 Aug 2020 20:20:17 +0200	[thread overview]
Message-ID: <20200821182017.GB69748@oden.dyn.berto.se> (raw)
In-Reply-To: <20200821112433.5652-1-geert+renesas@glider.be>

Hi Geert,

Thanks for your patch.

On 2020-08-21 13:24:33 +0200, Geert Uytterhoeven wrote:
> According to Devicetree Specification v0.2 and later, Section "Generic
> Names Recommendation", the node name for a pin controller device node
> should be "pinctrl".
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

> ---
> To be queued in renesas-devel for v5.10.
> 
>  arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 2 +-
>  arch/arm64/boot/dts/renesas/r8a774b1.dtsi | 2 +-
>  arch/arm64/boot/dts/renesas/r8a774c0.dtsi | 2 +-
>  arch/arm64/boot/dts/renesas/r8a774e1.dtsi | 2 +-
>  arch/arm64/boot/dts/renesas/r8a77951.dtsi | 2 +-
>  arch/arm64/boot/dts/renesas/r8a77960.dtsi | 2 +-
>  arch/arm64/boot/dts/renesas/r8a77961.dtsi | 2 +-
>  arch/arm64/boot/dts/renesas/r8a77965.dtsi | 2 +-
>  arch/arm64/boot/dts/renesas/r8a77970.dtsi | 2 +-
>  arch/arm64/boot/dts/renesas/r8a77980.dtsi | 2 +-
>  arch/arm64/boot/dts/renesas/r8a77990.dtsi | 2 +-
>  arch/arm64/boot/dts/renesas/r8a77995.dtsi | 2 +-
>  12 files changed, 12 insertions(+), 12 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> index ed99863f1dd09fd0..0806446228ec8f14 100644
> --- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> @@ -408,7 +408,7 @@
>  			resets = <&cpg 905>;
>  		};
>  
> -		pfc: pin-controller@e6060000 {
> +		pfc: pinctrl@e6060000 {
>  			compatible = "renesas,pfc-r8a774a1";
>  			reg = <0 0xe6060000 0 0x50c>;
>  		};
> diff --git a/arch/arm64/boot/dts/renesas/r8a774b1.dtsi b/arch/arm64/boot/dts/renesas/r8a774b1.dtsi
> index 1c76de24d3ea4844..40d87baa2431edfe 100644
> --- a/arch/arm64/boot/dts/renesas/r8a774b1.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a774b1.dtsi
> @@ -282,7 +282,7 @@
>  			resets = <&cpg 905>;
>  		};
>  
> -		pfc: pin-controller@e6060000 {
> +		pfc: pinctrl@e6060000 {
>  			compatible = "renesas,pfc-r8a774b1";
>  			reg = <0 0xe6060000 0 0x50c>;
>  		};
> diff --git a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
> index 9fdca4c55ba95608..f2a93f83781dba04 100644
> --- a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
> @@ -256,7 +256,7 @@
>  			resets = <&cpg 906>;
>  		};
>  
> -		pfc: pin-controller@e6060000 {
> +		pfc: pinctrl@e6060000 {
>  			compatible = "renesas,pfc-r8a774c0";
>  			reg = <0 0xe6060000 0 0x508>;
>  		};
> diff --git a/arch/arm64/boot/dts/renesas/r8a774e1.dtsi b/arch/arm64/boot/dts/renesas/r8a774e1.dtsi
> index 415727c9f23200dd..c4cd05470ed7e19d 100644
> --- a/arch/arm64/boot/dts/renesas/r8a774e1.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a774e1.dtsi
> @@ -427,7 +427,7 @@
>  			resets = <&cpg 905>;
>  		};
>  
> -		pfc: pin-controller@e6060000 {
> +		pfc: pinctrl@e6060000 {
>  			compatible = "renesas,pfc-r8a774e1";
>  			reg = <0 0xe6060000 0 0x50c>;
>  		};
> diff --git a/arch/arm64/boot/dts/renesas/r8a77951.dtsi b/arch/arm64/boot/dts/renesas/r8a77951.dtsi
> index 1b1a014c829a2e2a..644308dd886c4baa 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77951.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77951.dtsi
> @@ -490,7 +490,7 @@
>  			resets = <&cpg 905>;
>  		};
>  
> -		pfc: pin-controller@e6060000 {
> +		pfc: pinctrl@e6060000 {
>  			compatible = "renesas,pfc-r8a7795";
>  			reg = <0 0xe6060000 0 0x50c>;
>  		};
> diff --git a/arch/arm64/boot/dts/renesas/r8a77960.dtsi b/arch/arm64/boot/dts/renesas/r8a77960.dtsi
> index e6c88a748692b212..53b9aa26c9b13fa7 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77960.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77960.dtsi
> @@ -459,7 +459,7 @@
>  			resets = <&cpg 905>;
>  		};
>  
> -		pfc: pin-controller@e6060000 {
> +		pfc: pinctrl@e6060000 {
>  			compatible = "renesas,pfc-r8a7796";
>  			reg = <0 0xe6060000 0 0x50c>;
>  		};
> diff --git a/arch/arm64/boot/dts/renesas/r8a77961.dtsi b/arch/arm64/boot/dts/renesas/r8a77961.dtsi
> index 6fdc28a6d2cf0354..3ff2729528aeaeab 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77961.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77961.dtsi
> @@ -448,7 +448,7 @@
>  			resets = <&cpg 905>;
>  		};
>  
> -		pfc: pin-controller@e6060000 {
> +		pfc: pinctrl@e6060000 {
>  			compatible = "renesas,pfc-r8a77961";
>  			reg = <0 0xe6060000 0 0x50c>;
>  		};
> diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> index 6206e28f37efae73..bfffc5b6104e2dfc 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> @@ -329,7 +329,7 @@
>  			resets = <&cpg 905>;
>  		};
>  
> -		pfc: pin-controller@e6060000 {
> +		pfc: pinctrl@e6060000 {
>  			compatible = "renesas,pfc-r8a77965";
>  			reg = <0 0xe6060000 0 0x50c>;
>  		};
> diff --git a/arch/arm64/boot/dts/renesas/r8a77970.dtsi b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> index 7be8ad1ca4646d79..5a5d5649332a8b1d 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> @@ -204,7 +204,7 @@
>  			resets = <&cpg 907>;
>  		};
>  
> -		pfc: pin-controller@e6060000 {
> +		pfc: pinctrl@e6060000 {
>  			compatible = "renesas,pfc-r8a77970";
>  			reg = <0 0xe6060000 0 0x504>;
>  		};
> diff --git a/arch/arm64/boot/dts/renesas/r8a77980.dtsi b/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> index f573dc0552272195..ec7ca72399ec4d54 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> @@ -234,7 +234,7 @@
>  			resets = <&cpg 907>;
>  		};
>  
> -		pfc: pin-controller@e6060000 {
> +		pfc: pinctrl@e6060000 {
>  			compatible = "renesas,pfc-r8a77980";
>  			reg = <0 0xe6060000 0 0x50c>;
>  		};
> diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> index 07c35e9b049ae151..d1615474be67bac3 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> @@ -282,7 +282,7 @@
>  			resets = <&cpg 906>;
>  		};
>  
> -		pfc: pin-controller@e6060000 {
> +		pfc: pinctrl@e6060000 {
>  			compatible = "renesas,pfc-r8a77990";
>  			reg = <0 0xe6060000 0 0x508>;
>  		};
> diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> index 624aaa6d7f20d6d4..e1af7c4782f4d768 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> @@ -188,7 +188,7 @@
>  			resets = <&cpg 906>;
>  		};
>  
> -		pfc: pin-controller@e6060000 {
> +		pfc: pinctrl@e6060000 {
>  			compatible = "renesas,pfc-r8a77995";
>  			reg = <0 0xe6060000 0 0x508>;
>  		};
> -- 
> 2.17.1
> 

-- 
Regards,
Niklas Söderlund

WARNING: multiple messages have this Message-ID
From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org,
	Magnus Damm <magnus.damm@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: renesas: Fix pin controller node names
Date: Fri, 21 Aug 2020 20:20:17 +0200	[thread overview]
Message-ID: <20200821182017.GB69748@oden.dyn.berto.se> (raw)
In-Reply-To: <20200821112433.5652-1-geert+renesas@glider.be>

Hi Geert,

Thanks for your patch.

On 2020-08-21 13:24:33 +0200, Geert Uytterhoeven wrote:
> According to Devicetree Specification v0.2 and later, Section "Generic
> Names Recommendation", the node name for a pin controller device node
> should be "pinctrl".
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

> ---
> To be queued in renesas-devel for v5.10.
> 
>  arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 2 +-
>  arch/arm64/boot/dts/renesas/r8a774b1.dtsi | 2 +-
>  arch/arm64/boot/dts/renesas/r8a774c0.dtsi | 2 +-
>  arch/arm64/boot/dts/renesas/r8a774e1.dtsi | 2 +-
>  arch/arm64/boot/dts/renesas/r8a77951.dtsi | 2 +-
>  arch/arm64/boot/dts/renesas/r8a77960.dtsi | 2 +-
>  arch/arm64/boot/dts/renesas/r8a77961.dtsi | 2 +-
>  arch/arm64/boot/dts/renesas/r8a77965.dtsi | 2 +-
>  arch/arm64/boot/dts/renesas/r8a77970.dtsi | 2 +-
>  arch/arm64/boot/dts/renesas/r8a77980.dtsi | 2 +-
>  arch/arm64/boot/dts/renesas/r8a77990.dtsi | 2 +-
>  arch/arm64/boot/dts/renesas/r8a77995.dtsi | 2 +-
>  12 files changed, 12 insertions(+), 12 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> index ed99863f1dd09fd0..0806446228ec8f14 100644
> --- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> @@ -408,7 +408,7 @@
>  			resets = <&cpg 905>;
>  		};
>  
> -		pfc: pin-controller@e6060000 {
> +		pfc: pinctrl@e6060000 {
>  			compatible = "renesas,pfc-r8a774a1";
>  			reg = <0 0xe6060000 0 0x50c>;
>  		};
> diff --git a/arch/arm64/boot/dts/renesas/r8a774b1.dtsi b/arch/arm64/boot/dts/renesas/r8a774b1.dtsi
> index 1c76de24d3ea4844..40d87baa2431edfe 100644
> --- a/arch/arm64/boot/dts/renesas/r8a774b1.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a774b1.dtsi
> @@ -282,7 +282,7 @@
>  			resets = <&cpg 905>;
>  		};
>  
> -		pfc: pin-controller@e6060000 {
> +		pfc: pinctrl@e6060000 {
>  			compatible = "renesas,pfc-r8a774b1";
>  			reg = <0 0xe6060000 0 0x50c>;
>  		};
> diff --git a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
> index 9fdca4c55ba95608..f2a93f83781dba04 100644
> --- a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
> @@ -256,7 +256,7 @@
>  			resets = <&cpg 906>;
>  		};
>  
> -		pfc: pin-controller@e6060000 {
> +		pfc: pinctrl@e6060000 {
>  			compatible = "renesas,pfc-r8a774c0";
>  			reg = <0 0xe6060000 0 0x508>;
>  		};
> diff --git a/arch/arm64/boot/dts/renesas/r8a774e1.dtsi b/arch/arm64/boot/dts/renesas/r8a774e1.dtsi
> index 415727c9f23200dd..c4cd05470ed7e19d 100644
> --- a/arch/arm64/boot/dts/renesas/r8a774e1.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a774e1.dtsi
> @@ -427,7 +427,7 @@
>  			resets = <&cpg 905>;
>  		};
>  
> -		pfc: pin-controller@e6060000 {
> +		pfc: pinctrl@e6060000 {
>  			compatible = "renesas,pfc-r8a774e1";
>  			reg = <0 0xe6060000 0 0x50c>;
>  		};
> diff --git a/arch/arm64/boot/dts/renesas/r8a77951.dtsi b/arch/arm64/boot/dts/renesas/r8a77951.dtsi
> index 1b1a014c829a2e2a..644308dd886c4baa 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77951.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77951.dtsi
> @@ -490,7 +490,7 @@
>  			resets = <&cpg 905>;
>  		};
>  
> -		pfc: pin-controller@e6060000 {
> +		pfc: pinctrl@e6060000 {
>  			compatible = "renesas,pfc-r8a7795";
>  			reg = <0 0xe6060000 0 0x50c>;
>  		};
> diff --git a/arch/arm64/boot/dts/renesas/r8a77960.dtsi b/arch/arm64/boot/dts/renesas/r8a77960.dtsi
> index e6c88a748692b212..53b9aa26c9b13fa7 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77960.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77960.dtsi
> @@ -459,7 +459,7 @@
>  			resets = <&cpg 905>;
>  		};
>  
> -		pfc: pin-controller@e6060000 {
> +		pfc: pinctrl@e6060000 {
>  			compatible = "renesas,pfc-r8a7796";
>  			reg = <0 0xe6060000 0 0x50c>;
>  		};
> diff --git a/arch/arm64/boot/dts/renesas/r8a77961.dtsi b/arch/arm64/boot/dts/renesas/r8a77961.dtsi
> index 6fdc28a6d2cf0354..3ff2729528aeaeab 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77961.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77961.dtsi
> @@ -448,7 +448,7 @@
>  			resets = <&cpg 905>;
>  		};
>  
> -		pfc: pin-controller@e6060000 {
> +		pfc: pinctrl@e6060000 {
>  			compatible = "renesas,pfc-r8a77961";
>  			reg = <0 0xe6060000 0 0x50c>;
>  		};
> diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> index 6206e28f37efae73..bfffc5b6104e2dfc 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> @@ -329,7 +329,7 @@
>  			resets = <&cpg 905>;
>  		};
>  
> -		pfc: pin-controller@e6060000 {
> +		pfc: pinctrl@e6060000 {
>  			compatible = "renesas,pfc-r8a77965";
>  			reg = <0 0xe6060000 0 0x50c>;
>  		};
> diff --git a/arch/arm64/boot/dts/renesas/r8a77970.dtsi b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> index 7be8ad1ca4646d79..5a5d5649332a8b1d 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> @@ -204,7 +204,7 @@
>  			resets = <&cpg 907>;
>  		};
>  
> -		pfc: pin-controller@e6060000 {
> +		pfc: pinctrl@e6060000 {
>  			compatible = "renesas,pfc-r8a77970";
>  			reg = <0 0xe6060000 0 0x504>;
>  		};
> diff --git a/arch/arm64/boot/dts/renesas/r8a77980.dtsi b/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> index f573dc0552272195..ec7ca72399ec4d54 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> @@ -234,7 +234,7 @@
>  			resets = <&cpg 907>;
>  		};
>  
> -		pfc: pin-controller@e6060000 {
> +		pfc: pinctrl@e6060000 {
>  			compatible = "renesas,pfc-r8a77980";
>  			reg = <0 0xe6060000 0 0x50c>;
>  		};
> diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> index 07c35e9b049ae151..d1615474be67bac3 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> @@ -282,7 +282,7 @@
>  			resets = <&cpg 906>;
>  		};
>  
> -		pfc: pin-controller@e6060000 {
> +		pfc: pinctrl@e6060000 {
>  			compatible = "renesas,pfc-r8a77990";
>  			reg = <0 0xe6060000 0 0x508>;
>  		};
> diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> index 624aaa6d7f20d6d4..e1af7c4782f4d768 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> @@ -188,7 +188,7 @@
>  			resets = <&cpg 906>;
>  		};
>  
> -		pfc: pin-controller@e6060000 {
> +		pfc: pinctrl@e6060000 {
>  			compatible = "renesas,pfc-r8a77995";
>  			reg = <0 0xe6060000 0 0x508>;
>  		};
> -- 
> 2.17.1
> 

-- 
Regards,
Niklas Söderlund

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-08-21 18:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-21 11:24 [PATCH] arm64: dts: renesas: Fix pin controller node names Geert Uytterhoeven
2020-08-21 11:24 ` Geert Uytterhoeven
2020-08-21 18:20 ` Niklas Söderlund [this message]
2020-08-21 18:20   ` Niklas Söderlund
2021-12-16 15:04 Geert Uytterhoeven
2021-12-16 15:04 ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200821182017.GB69748@oden.dyn.berto.se \
    --to=niklas.soderlund@ragnatech.se \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.