From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52D56C433DF for ; Sat, 22 Aug 2020 13:14:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 32625207DF for ; Sat, 22 Aug 2020 13:14:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="C4Y072XU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728097AbgHVNOC (ORCPT ); Sat, 22 Aug 2020 09:14:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728083AbgHVNN5 (ORCPT ); Sat, 22 Aug 2020 09:13:57 -0400 Received: from mail-pf1-x441.google.com (mail-pf1-x441.google.com [IPv6:2607:f8b0:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12A27C061575 for ; Sat, 22 Aug 2020 06:13:56 -0700 (PDT) Received: by mail-pf1-x441.google.com with SMTP id f193so2430749pfa.12 for ; Sat, 22 Aug 2020 06:13:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=xQFZ3Sv5y18I7wZ9EvV1kNK7LL9SLdrdcRtoUoCFnvA=; b=C4Y072XUAIYZyfmRrshf5l95PKNCWRwbELitDleGUvIdERcUpFcVgCGYWWXxXo3+vG 8BPaFHw/m1aeMNF8psDMprEv/tZXx39vj8amuMaLWdebvAPjysgxNmt9sgLSGkgHWp3B jAxXX1Y8EbBER6csHNYJU8QIxOfMbOMxBINcNC+g+re1je9Nf3dv3BOl7mseXgz0Hjnu uSyzMi3CyCgojgN13U2OTkpESZnzjTZHY+oZpPCO3Vjw2KnMMb7QaRtY2DmA2zTyxVFy y3bYbFtml8cHTQYaSw+yThBfrEO0DpO9OZMCcddOhggEtsLenCi93krz/vdgD6d5nbsP 3+sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=xQFZ3Sv5y18I7wZ9EvV1kNK7LL9SLdrdcRtoUoCFnvA=; b=gDLMDXcx8N/qP+xg6M+aM6KtbsHHAOya8tQwA5HBkjLAje3XvIKweb2GMV1yMVPMVf V7xvEFfIYXnIRzv9w8QgyN4ULYcehMh1I2ztcDs/9h4X5LwcJhuPBv38XCNhFeCLOFKO KS/8R3qwDsfUuRKaXKjR4NKNlTEFbvxXWdXjqhBQPxukuqUk1IzDSomU5CtVdzWzKscz S/u18hpUQGxg04ARQmx6XJ1t4kunsDBQYZtavDZsyG2SaIxaTKIYEPKQAPdC7NUT3nVm rh70NMmDLGlZw8hozEYvcTfGTCtUmraym5RnQn1EJ/nzqM6/zgzbWkRoRkWkuEgSOmg8 yr0g== X-Gm-Message-State: AOAM530zm6xWr4gN1P1kWpuKwSxpVkJoHl2yAwl6XFg0J9ONIcrxQEXw DkBlNk+7Gc5RX5SRwSVfw4eQ X-Google-Smtp-Source: ABdhPJyRlCojM5NMEXP9w3XIS/sCcanKf8LrNsIJpeQOfBQ0femryhqcgTQIORPf0+wab+FZ1K3W0A== X-Received: by 2002:aa7:8a0d:: with SMTP id m13mr6118466pfa.13.1598102035821; Sat, 22 Aug 2020 06:13:55 -0700 (PDT) Received: from Mani-XPS-13-9360 ([2409:4072:6d94:5e90:8021:8773:d646:5b0b]) by smtp.gmail.com with ESMTPSA id ha17sm580529pjb.6.2020.08.22.06.13.46 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 22 Aug 2020 06:13:54 -0700 (PDT) Date: Sat, 22 Aug 2020 18:43:43 +0530 From: Manivannan Sadhasivam To: Cristian Ciocaltea Cc: Lee Jones , Rob Herring , Dmitry Torokhov , Sebastian Reichel , Liam Girdwood , Mark Brown , Andreas =?iso-8859-1?Q?F=E4rber?= , linux-actions@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v2 0/6] Add initial support for ATC260x PMICs Message-ID: <20200822131343.GA5954@Mani-XPS-13-9360> References: <20200821222653.GA2255465@BV030612LT> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200821222653.GA2255465@BV030612LT> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Cristi, Thanks for the series! I'll take a look soon but there is a quick comment below. On Sat, Aug 22, 2020 at 01:26:53AM +0300, Cristian Ciocaltea wrote: > I have just realized I had omitted the changelog - sorry: > > Changes in v2: > - Reworked MFD core & I2C driver > * Integrated Lee's feedback > * Added support for using the regmap within atomic contexts > * Added support for ATC2603C chip variant > * Reorganized KConfig entries > - Improved regulator driver > * Added support for ATC2603C variant > * Used helper macros for more compact specification of regulator_desc items > * Added more regulator capabilities > - Added power controller driver > * Provides system poweroff/reboot functionalities > * Requires support for I2C Atomic transfers in the Owl driver (already submitted) > - Added onkey driver: exposes the power button as an input device > - Added yaml binding doc > - Rebased patchset on kernel v5.9-rc1 > > Kind regards, > Cristi > > On Sat, Aug 22, 2020 at 01:19:46AM +0300, Cristian Ciocaltea wrote: > > This is re-spin of the patch series submitted some time ago by Mani, > > who added initial support (MFD core and regulators) for the Actions > > Semi ATC260x PMICs: > > https://lore.kernel.org/lkml/20190617155011.15376-1-manivannan.sadhasivam@linaro.org/ > > > > The ATC260x family of PMICs integrates Audio Codec, Power management, > > Clock generation and GPIO controller blocks. There are currently 3 > > variants: ATC2603A, ATC2603C and ATC2609A. > > > > In addition to the ATC2609A regulator functionality provided that time, > > this patchset adds support for the ATC2603C variant, together with some > > new functionalities for both chips: power controller and onkey input. > > The ATC2603A variant remains unsupported for the moment. > > > > This has been tested on RoseapplePi, a SBC based on the Action Semi S500 > > SoC, which integrates ATC2603C PMIC. An initial support for this board > > has been already submitted: > > https://lore.kernel.org/lkml/cover.1592123160.git.cristian.ciocaltea@gmail.com/ > > > > Please note that enabling the ATC260x PMICs on the compatible Actions > > Semi Owl SoC based boards depends on the following: > > > > * Actions Semi SIRQ driver (for PMIC DTS setup): > > https://lore.kernel.org/lkml/cover.1597852360.git.cristian.ciocaltea@gmail.com/ > > > > * I2C Atomic transfers in Actions Semi Owl driver (for proper operation > > of the power controller driver): > > https://lore.kernel.org/lkml/b086ef6d355d9730c839359e15eb06175283e323.1596485741.git.cristian.ciocaltea@gmail.com/ > > > > Thanks, > > Cristi > > > > Cristian Ciocaltea (6): > > dt-bindings: mfd: Add Actions Semi ATC260x PMIC binding > > mfd: Add MFD driver for ATC260x PMICs > > regulator: Add regulator driver for ATC260x PMICs You need to preserve my authorship for above two patches. Adding the signed-off-by is not enough. > > power: reset: Add poweroff driver for ATC260x PMICs > > input: atc260x: Add onkey driver for ATC260x PMICs > > MAINTAINERS: Add entry for ATC260x PMIC I think this one too. Thanks, Mani > > > > .../bindings/mfd/actions,atc260x.yaml | 221 ++++++++ > > MAINTAINERS | 12 + > > drivers/input/misc/Kconfig | 11 + > > drivers/input/misc/Makefile | 2 +- > > drivers/input/misc/atc260x-onkey.c | 304 +++++++++++ > > drivers/mfd/Kconfig | 18 + > > drivers/mfd/Makefile | 3 + > > drivers/mfd/atc260x-core.c | 290 ++++++++++ > > drivers/mfd/atc260x-i2c.c | 73 +++ > > drivers/power/reset/Kconfig | 8 +- > > drivers/power/reset/Makefile | 1 + > > drivers/power/reset/atc260x-poweroff.c | 274 ++++++++++ > > drivers/regulator/Kconfig | 8 + > > drivers/regulator/Makefile | 1 + > > drivers/regulator/atc260x-regulator.c | 511 ++++++++++++++++++ > > include/linux/mfd/atc260x/atc2603c.h | 281 ++++++++++ > > include/linux/mfd/atc260x/atc2609a.h | 308 +++++++++++ > > include/linux/mfd/atc260x/core.h | 86 +++ > > 18 files changed, 2410 insertions(+), 2 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/mfd/actions,atc260x.yaml > > create mode 100644 drivers/input/misc/atc260x-onkey.c > > create mode 100644 drivers/mfd/atc260x-core.c > > create mode 100644 drivers/mfd/atc260x-i2c.c > > create mode 100644 drivers/power/reset/atc260x-poweroff.c > > create mode 100644 drivers/regulator/atc260x-regulator.c > > create mode 100644 include/linux/mfd/atc260x/atc2603c.h > > create mode 100644 include/linux/mfd/atc260x/atc2609a.h > > create mode 100644 include/linux/mfd/atc260x/core.h > > > > -- > > 2.28.0 > >