All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] rtc: sun6i: Fix memleak in sun6i_rtc_clk_init
@ 2020-08-23  7:58 ` Dinghao Liu
  0 siblings, 0 replies; 10+ messages in thread
From: Dinghao Liu @ 2020-08-23  7:58 UTC (permalink / raw)
  To: dinghao.liu, kjlu
  Cc: Alessandro Zummo, Alexandre Belloni, Maxime Ripard, Chen-Yu Tsai,
	linux-rtc, linux-arm-kernel, linux-kernel

When clk_hw_register_fixed_rate_with_accuracy() fails,
clk_data should be freed. It's the same for the subsequent
error paths.

Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
---
 drivers/rtc/rtc-sun6i.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/rtc/rtc-sun6i.c b/drivers/rtc/rtc-sun6i.c
index e2b8b150bcb4..a837c5a40508 100644
--- a/drivers/rtc/rtc-sun6i.c
+++ b/drivers/rtc/rtc-sun6i.c
@@ -272,7 +272,7 @@ static void __init sun6i_rtc_clk_init(struct device_node *node,
 								300000000);
 	if (IS_ERR(rtc->int_osc)) {
 		pr_crit("Couldn't register the internal oscillator\n");
-		return;
+		goto err;
 	}
 
 	parents[0] = clk_hw_get_name(rtc->int_osc);
@@ -290,7 +290,7 @@ static void __init sun6i_rtc_clk_init(struct device_node *node,
 	rtc->losc = clk_register(NULL, &rtc->hw);
 	if (IS_ERR(rtc->losc)) {
 		pr_crit("Couldn't register the LOSC clock\n");
-		return;
+		goto err;
 	}
 
 	of_property_read_string_index(node, "clock-output-names", 1,
@@ -301,7 +301,7 @@ static void __init sun6i_rtc_clk_init(struct device_node *node,
 					  &rtc->lock);
 	if (IS_ERR(rtc->ext_losc)) {
 		pr_crit("Couldn't register the LOSC external gate\n");
-		return;
+		goto err;
 	}
 
 	clk_data->num = 2;
-- 
2.17.1


^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2020-10-18  6:20 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-23  7:58 [PATCH] rtc: sun6i: Fix memleak in sun6i_rtc_clk_init Dinghao Liu
2020-08-23  7:58 ` Dinghao Liu
2020-08-25 14:51 ` Chen-Yu Tsai
2020-08-25 14:51   ` Chen-Yu Tsai
2020-08-26  8:55   ` dinghao.liu
2020-08-26  8:55     ` dinghao.liu
2020-10-09 20:57     ` Alexandre Belloni
2020-10-09 20:57       ` Alexandre Belloni
2020-10-18  6:00       ` dinghao.liu
2020-10-18  6:00         ` dinghao.liu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.