From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D49BC433DF for ; Sun, 23 Aug 2020 10:46:24 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 043EB2072D for ; Sun, 23 Aug 2020 10:46:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lVmKX6xI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 043EB2072D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6E5856E4BA; Sun, 23 Aug 2020 10:46:16 +0000 (UTC) Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id 711696E4A2 for ; Sun, 23 Aug 2020 10:46:06 +0000 (UTC) Received: by mail-lj1-x241.google.com with SMTP id f26so6430842ljc.8 for ; Sun, 23 Aug 2020 03:46:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7lWhA0BYbPCSLHXU1/4K+CyGmerfjzXfaP8MVDvqeBE=; b=lVmKX6xInmUbmU2AWmtGLOMZW0ujNTCEYxhdlWCaobw/U8i7o6AxjleoDkaGd95J90 I+BYeVEySTUAuGEwTPmCaSJgjzWoA8f6QPTNi3QqfFr+Ts561guyTqr2k/OEZC6dA8Xe MF63v66UmCMDmGYrB8M9nIhj1js/CRPksJ62yuDeG4rPA7/jp5FshEz6ni+VTLQ+dhla +03M+raqQG/NIlKFmoT45SqDW5XckoMGx9eVEUopslEsE+7ZCK1gxUuX9Mnu8bLwoVwI Bv9+SEwTnzD6/UuoYTTCha7iKSO/J5BXW9DsIOJPH0BGcc1xB5CkewxOpC0/un4n+JUm g5qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=7lWhA0BYbPCSLHXU1/4K+CyGmerfjzXfaP8MVDvqeBE=; b=bu7lbyXsD7Mj7U6vCPOKhymN8VYFStF8ZKp7JunimBaBp0wFrIpgGYAoaXwRBwUu9Y cD4UMvsE2KvEhkDjZ6pTUf1GRAQPJmwNQkudYiqlH/R/sg80DoGTxWbfsHMZd3MEjTT+ Evg/ak4QFD/ZJCyK9n+GwCp69L7Kuz6WgYV+mt6Racv182at3CSdOevGW/JBD2onxeKX nLYidZ06byQBYIE6TajyA9PNzGOvTcu3qssWCqzMHRF0ElRjrJu46v0gF75MA2TDqU7r sBiGjd7ABtxXXsNi4d0lSflw5aED5Es0ELmyno9/RGQdheK76o0cT83R2Gm3AwfklZHx psFw== X-Gm-Message-State: AOAM5313FvlmLRDZpcurbgSxbQm9DH1nIj+VU3lKmqVoTvIqxrTv4Sge y60zVGztRSuCx0SyszlmzGfslYVPZOLLug== X-Google-Smtp-Source: ABdhPJwg1brrxjpNESG1fQGbFoD+LVBGn8t93D1s5RCtW1PPt9ivoEAQtEaBcUJpKpCxqxiHjWiI3g== X-Received: by 2002:a05:651c:294:: with SMTP id b20mr421482ljo.4.1598179564700; Sun, 23 Aug 2020 03:46:04 -0700 (PDT) Received: from saturn.localdomain ([2a00:fd00:805f:db00:2509:20d7:e461:9c16]) by smtp.gmail.com with ESMTPSA id h13sm1516301lji.134.2020.08.23.03.46.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Aug 2020 03:46:04 -0700 (PDT) From: Sam Ravnborg To: dri-devel@lists.freedesktop.org, Jingoo Han , Lee Jones , Daniel Thompson Subject: [PATCH v2 10/24] drm/panel: novatek-nt35510: Backlight update Date: Sun, 23 Aug 2020 12:45:18 +0200 Message-Id: <20200823104532.1024798-11-sam@ravnborg.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200823104532.1024798-1-sam@ravnborg.org> References: <20200823104532.1024798-1-sam@ravnborg.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Thierry Reding , Sam Ravnborg Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" - Replace direct access to backlight_properties with backlight_get_brightness(). - Drop debug printout - Use macro for initialization Signed-off-by: Sam Ravnborg Cc: Linus Walleij Cc: Thierry Reding Cc: Sam Ravnborg --- drivers/gpu/drm/panel/panel-novatek-nt35510.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-novatek-nt35510.c b/drivers/gpu/drm/panel/panel-novatek-nt35510.c index 4a8fa908a2cf..ee4919a27480 100644 --- a/drivers/gpu/drm/panel/panel-novatek-nt35510.c +++ b/drivers/gpu/drm/panel/panel-novatek-nt35510.c @@ -654,10 +654,9 @@ static int nt35510_set_brightness(struct backlight_device *bl) { struct nt35510 *nt = bl_get_data(bl); struct mipi_dsi_device *dsi = to_mipi_dsi_device(nt->dev); - u8 brightness = bl->props.brightness; + u8 brightness = backlight_get_brightness(bl); int ret; - DRM_DEV_DEBUG(nt->dev, "set brightness %d\n", brightness); ret = mipi_dsi_dcs_write(dsi, MIPI_DCS_SET_DISPLAY_BRIGHTNESS, &brightness, sizeof(brightness)); @@ -943,16 +942,14 @@ static int nt35510_probe(struct mipi_dsi_device *dsi) } if (!nt->panel.backlight) { struct backlight_device *bl; + DECLARE_BACKLIGHT_INIT_RAW(props, 255, 255); bl = devm_backlight_device_register(dev, "nt35510", dev, nt, - &nt35510_bl_ops, NULL); + &nt35510_bl_ops, &props); if (IS_ERR(bl)) { DRM_DEV_ERROR(dev, "failed to register backlight device\n"); return PTR_ERR(bl); } - bl->props.max_brightness = 255; - bl->props.brightness = 255; - bl->props.power = FB_BLANK_POWERDOWN; nt->panel.backlight = bl; } -- 2.25.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel