From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1kA62X-0004DN-0t for mharc-grub-devel@gnu.org; Mon, 24 Aug 2020 02:33:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34964) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kA62V-0004D5-PK for grub-devel@gnu.org; Mon, 24 Aug 2020 02:33:07 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:50141) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kA62U-0007Md-AF for grub-devel@gnu.org; Mon, 24 Aug 2020 02:33:07 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id DD6B75C00DA; Mon, 24 Aug 2020 02:33:05 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Mon, 24 Aug 2020 02:33:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pks.im; h=date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=q6mlGfRd1ws8qGXANOF5ITr+bRq mjRtTaPQ+bvAUx8U=; b=a/7hlEk/qxPWzImLSke820Fu1FZqC2Uvo2ZQ3LPiKSz 9tpTuawPlalkcJJxzRCdH/ItnKMCLvEI405tCpgk7s/2OcP2Iy1AD2wq/aOBjUKM AohvRJ6ZhApD8wSOPderdaE6MF8TGpYBThg/B08OwEz9dAShHHCIBCFMhHYajZft bnP7W4Jclet5gDBWSlQMQ4PDqkrVRSXrVxOkiYFeFvtgoQ/Uy59KKI6MfB5kqwVV BHORJy+uBIvh9B2E6K1vcEUy2o82SL25gQDmHUbXIH+NV/Qq9mWPx1U0e75DW37y 8C6l/bLe8jMcRvQoYy8oujejxKObiWBnurVJ4fiBmmw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=q6mlGf Rd1ws8qGXANOF5ITr+bRqmjRtTaPQ+bvAUx8U=; b=XZd3pDLmVg6s7YQ+md3SMo Zz0f0MIkpfL0FyY4Ip3S09+UA298zeNObcG8N6XLao1B0vCf5r77UVxEEhGi0REU d/cjdxKOUbo099MR0ZumhLDHYgMdh87o1KyYx/KS7CTQV8j8dFvjtipxoFHInbGR HnK2N6n2cnQ6STC32aM3wX0SDXtRiIn5NYjov/XPw325wF0xGbJufFufikXyOZ65 ucVPpXxuA345xToinS23h16AZe99eoMHB5GsQyEL7R0mb0P6ehim04qaX3GQg1jQ kn+yj8SM220aMaoT5iXjuOLvvPS0yVE/dQH+4qchdylQf+7f/hNHovxotP3oi5FQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedruddujedgkeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefrrghtrhhi tghkucfuthgvihhnhhgrrhguthcuoehpshesphhkshdrihhmqeenucggtffrrghtthgvrh hnpeehgefhtdefueffheekgfffudelffejtdfhvdejkedthfehvdelgfetgfdvtedthfen ucfkphepjeejrdduuddrhedvrdejieenucevlhhushhtvghrufhiiigvpedunecurfgrrh grmhepmhgrihhlfhhrohhmpehpshesphhkshdrihhm X-ME-Proxy: Received: from vm-mail.pks.im (x4d0b344c.dyn.telefonica.de [77.11.52.76]) by mail.messagingengine.com (Postfix) with ESMTPA id A687030600A9; Mon, 24 Aug 2020 02:33:04 -0400 (EDT) Received: from localhost (tanuki [10.192.0.23]) by vm-mail.pks.im (OpenSMTPD) with ESMTPSA id e6870680 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 24 Aug 2020 06:33:03 +0000 (UTC) Date: Mon, 24 Aug 2020 08:33:08 +0200 From: Patrick Steinhardt To: Glenn Washburn Cc: The development of GNU GRUB , Denis 'GNUtoo' Carikli , Daniel Kiper Subject: Re: [PATCH 3/9] luks2: Fix use of incorrect index and some error messages Message-ID: <20200824063308.GC953@tanuki.pks.im> References: <7cf9d9526dbbc1df2ef2fc10062642d3689a1a54.1598179677.git.ps@pks.im> <20200824013005.42744105@crass-HP-ZBook-15-G2> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="H8ygTp4AXg6deix2" Content-Disposition: inline In-Reply-To: <20200824013005.42744105@crass-HP-ZBook-15-G2> Received-SPF: pass client-ip=66.111.4.27; envelope-from=ps@pks.im; helo=out3-smtp.messagingengine.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/24 02:31:46 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Aug 2020 06:33:08 -0000 --H8ygTp4AXg6deix2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Aug 24, 2020 at 01:30:05AM -0500, Glenn Washburn wrote: > Was it intentional to include the old/original version of this patch > which you requested to be changed to make it more readable? There is > an updated patch with subject "[CRYPTO-LUKS v1 18/19] luks2: Fix use of > incorrect index and some error messages.". Nope, not at all. I've briefly wondered about the `i = j` thing again but didn't connect the dots. I'll replace it with the newer version in v2 of this patch series. Patrick --H8ygTp4AXg6deix2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEF9hrgiFbCdvenl/rVbJhu7ckPpQFAl9DXyQACgkQVbJhu7ck PpQ0Mw//S5Ed9i88QkZUhU73Ei+f3E1aICE5LrSsdB9e72jz31oEUDUDY2baYBz9 CjWymFnQA1mbYhDV1KIUxi4qz5P42p5xGbHRLQPKLHlZ2iZx1NDQTz4uleUgUbhM Mz+i3VloQxVEhApYv3pmUQKTBWwVO6vOZesoZdl8NCgXXoqSDLQQjAo33nBPLOaf Q8+GT3ZWI+ccgEgCWhUPMvnrZATH/z/UH8fCfqIYB5jMLYlddnW54FC23mk5k8UA fxkf3ebPr1WdkWd85eGH1Wr/xwM6zozdhLAyUKJ20Zk+BxORW0pqyyzpLckV72XF MI0KZXdGor3Vfb4eWspKDhMUQ4yPUqteslgrHembyqYRQyP5vRHdHPKx7XsFiYqO Q9QQkamueIJvMlJSfncNx5KXja/KwMsRrcEQB5voKXtqIKr2vPe4wB71CqIg4QMG hWFJqsdVsudnpKSEEQGLruvOvPhbmNiM6lU5hDvRZoxkDy1HOSIe928Ia4RzksyC i/y4uohWijlmDgR5QEY3vFk3v0oFDrNQD7Us1pHAkRCs7ymyBGATIvmFjraXAO5G 8lah32hd/BEWHwZHAAku12phYPvqMQe4xTQUcx69nqgDn6UEZmF1Hh8l8yvnAWhw BQynXwn25FR2jQn/k8zotk1ftdsD3hErEu5pMz88DmBT1l72ryk= =zZJq -----END PGP SIGNATURE----- --H8ygTp4AXg6deix2--