From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A968C433DF for ; Mon, 24 Aug 2020 09:11:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4AD262075B for ; Mon, 24 Aug 2020 09:11:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598260291; bh=yC4JaXoKNf09Y0qzawwSDFabUkiWka/yjmUa9jFldxI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=1HMeexzvYiqQttakLkfXvaaOej10TkFsZmX8ecXFEpj3VUMNR1r4TvvU1zCcdkJJg dqvikLq2meId1I13nKrUYCZclnczIFy+hOWIiWj/TT5sCc8Ux94MyilwUXXTEUvx7Z wxYq/DsUaJItlfGS3M/H2RjFhOlexU18TYXnh6gM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729549AbgHXJLa (ORCPT ); Mon, 24 Aug 2020 05:11:30 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:34220 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728511AbgHXJLJ (ORCPT ); Mon, 24 Aug 2020 05:11:09 -0400 Received: by mail-wr1-f67.google.com with SMTP id f7so7916161wrw.1; Mon, 24 Aug 2020 02:11:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=pUF3QN5qpBvG5fN8G2Ybjf+ixCnkDOi3rCaIBYZPN7k=; b=ouW01Ugyoltiz0Tx3d9PGq3yilZvXygJuQHcRAAJ9HRDxccD35sORb7bGyMHOGRuc4 /tDhxaT+pfJvDL5DhOzwyUDvgxNkE08LfpHx1xYYFauC9GcBu4yGLqKdHtOdYTLfogpu s4XQbNccL/KuCNmRQ1xC8AkUcj8kdoCuMRKuSslnpIvwWxoylFLUnSmjRmLY3EeUtzP4 qAdjf+udAjrsgY2JGo05AzLad6qApmRkflnVDfeszoJk2L5EVve/gSromwZ3AYfwSqtc RF83qvovbQ2PmWgIEeXsaGOhK+AUrWU1uU83cnUPepa6TB3iiUXxA17IqhxqV4PFrAWY UldQ== X-Gm-Message-State: AOAM531YOWNKYyGkZoiFt4aTQW1TkcRsR4Ia3vhcAObpZlYiB3iaefGS 4VuhqXZTDFBb0FY8N3hQs8s= X-Google-Smtp-Source: ABdhPJwE3kGFDhN1s/hoJjFR2sSwbpKpOgvJl8AK3ZwbGzN+OM9ankAAiOzMdDiYIc2qELP19gLoww== X-Received: by 2002:adf:ea4f:: with SMTP id j15mr4845334wrn.253.1598260266068; Mon, 24 Aug 2020 02:11:06 -0700 (PDT) Received: from kozik-lap ([194.230.155.216]) by smtp.googlemail.com with ESMTPSA id y24sm21368601wmi.17.2020.08.24.02.11.04 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 24 Aug 2020 02:11:05 -0700 (PDT) Date: Mon, 24 Aug 2020 11:11:02 +0200 From: Krzysztof Kozlowski To: Aisheng Dong Cc: Rob Herring , Linus Walleij , Bartosz Golaszewski , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , dl-linux-imx , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-mmc@vger.kernel.org" , "linux-mtd@lists.infradead.org" , "linux-pwm@vger.kernel.org" , "linux-serial@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-watchdog@vger.kernel.org" , Thierry Reding , Anson Huang Subject: Re: [PATCH 21/22] arm64: dts: imx8qxp: Remove i.MX7 compatible from USDHC Message-ID: <20200824091102.GA20819@kozik-lap> References: <20200823161550.3981-1-krzk@kernel.org> <20200823161550.3981-21-krzk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Mon, Aug 24, 2020 at 09:00:19AM +0000, Aisheng Dong wrote: > > From: Krzysztof Kozlowski > > Sent: Monday, August 24, 2020 12:16 AM > > > > The USDHC on i.MX 8QXP has its own compatible described in bindings and > > used in the driver (with its own quirks). Remove additional fsl,imx7d-usdhc > > compatible to fix dtbs_check warnings like: > > > > arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dt.yaml: mmc@5b010000: > > compatible: ['fsl,imx8qxp-usdhc', 'fsl,imx7d-usdhc'] is too long > > From schema: > > /ocumentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml > > > > arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dt.yaml: mmc@5b010000: > > compatible: Additional items are not allowed ('fsl,imx7d-usdhc' was > > unexpected) > > > > Signed-off-by: Krzysztof Kozlowski > > For Patch 19-22, I think we should fix dt binding doc. Are you sure that these USDHC controllers are compatible with i.MX 7D? Could they really run with fsl,imx7d-usdhc compatible? The implementation (Linux kernel driver) is different, I guess on purpose... Best regards, Krzysztof > > Regards > Aisheng > > > --- > > arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > > b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > > index 61bccb69f09e..26c4fcdfe290 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > > @@ -362,7 +362,7 @@ > > }; > > > > usdhc1: mmc@5b010000 { > > - compatible = "fsl,imx8qxp-usdhc", "fsl,imx7d-usdhc"; > > + compatible = "fsl,imx8qxp-usdhc"; > > interrupts = ; > > reg = <0x5b010000 0x10000>; > > clocks = <&conn_lpcg IMX_CONN_LPCG_SDHC0_IPG_CLK>, @@ > > -374,7 +374,7 @@ > > }; > > > > usdhc2: mmc@5b020000 { > > - compatible = "fsl,imx8qxp-usdhc", "fsl,imx7d-usdhc"; > > + compatible = "fsl,imx8qxp-usdhc"; > > interrupts = ; > > reg = <0x5b020000 0x10000>; > > clocks = <&conn_lpcg IMX_CONN_LPCG_SDHC1_IPG_CLK>, @@ > > -388,7 +388,7 @@ > > }; > > > > usdhc3: mmc@5b030000 { > > - compatible = "fsl,imx8qxp-usdhc", "fsl,imx7d-usdhc"; > > + compatible = "fsl,imx8qxp-usdhc"; > > interrupts = ; > > reg = <0x5b030000 0x10000>; > > clocks = <&conn_lpcg IMX_CONN_LPCG_SDHC2_IPG_CLK>, > > -- > > 2.17.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 955A8C433E1 for ; Mon, 24 Aug 2020 09:12:17 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 66D8B206F0 for ; Mon, 24 Aug 2020 09:12:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="emT7vmhV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 66D8B206F0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QkqNshQiCk83sf/MNusly8uLhL8HKaR8Hn83g76PHlw=; b=emT7vmhVSVddtDRUYZEIeK+2G hPdZQDwt/Gcc/pTq3ODDhxI9iQ7uZuaB9nkHf5r58PlpUsJqiET1SKsIw5PLal7ZlAVRWFjmGCLvn CHTDrJWxVbO0Ev4pjGqZnZNN3A49amHzOcDYm9oaVbXqGZjhVaZHScgDsYo4sX2SU1YZ4NOpiQSpL VJqXG1e0bEyXVxJpAGgZCMqQpoBTyBd50fAGtbu19XQzHV1Wp1tc26ODW4s6x7smUXilOj13Y8QO5 8CU77BX9T10X63GZ7LsCxSa2JiGaUt1AqOcpreQLqpEmA4RdVo9DAEykZn1QhRDmlWN9iKEZ2Ca/a pugpAbhmA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kA8VW-00077X-2P; Mon, 24 Aug 2020 09:11:14 +0000 Received: from mail-wr1-f67.google.com ([209.85.221.67]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kA8VP-00074c-KM; Mon, 24 Aug 2020 09:11:08 +0000 Received: by mail-wr1-f67.google.com with SMTP id a15so7874145wrh.10; Mon, 24 Aug 2020 02:11:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=pUF3QN5qpBvG5fN8G2Ybjf+ixCnkDOi3rCaIBYZPN7k=; b=FYgNPMRObWuMT6UG2AhAauPa4BIovwrhvlzfDU+NGCd5p4BIrT7y8ETmH4gvK0nJzc BJ8TFW4wGOz7bjY3gcWYq7ZKA8ILbk9PXCiRwtp1e2/V26eSsw3FeNTyY0yyo6gXb5Ri SN3rEFgnAI4BbSqlL+d09pNn0coTmRGd0xCyOBrd9xI6LlTASrfn+UC0YhwPnXSHO92q oqdrn7gWqCX/cWXfAgzb6xOpqZ94a/v8Y+5F5DnhYvbunKaxpN6wXKsZ+EPLf1lpFPA2 D3hYbSpJDarE4S0z2Hu0n7Zw5Sa5vl25IQeaQqNWPlyWc31N97FqIsQsSQiPlKXOZ0yU +ShQ== X-Gm-Message-State: AOAM531LsJJ9e4t1bFprNPkU/e2uJgwX5QRqfWZoGyqdQo+8hYeEcvk1 E8NdXtMOREynCWZaoXMbL4Q= X-Google-Smtp-Source: ABdhPJwE3kGFDhN1s/hoJjFR2sSwbpKpOgvJl8AK3ZwbGzN+OM9ankAAiOzMdDiYIc2qELP19gLoww== X-Received: by 2002:adf:ea4f:: with SMTP id j15mr4845334wrn.253.1598260266068; Mon, 24 Aug 2020 02:11:06 -0700 (PDT) Received: from kozik-lap ([194.230.155.216]) by smtp.googlemail.com with ESMTPSA id y24sm21368601wmi.17.2020.08.24.02.11.04 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 24 Aug 2020 02:11:05 -0700 (PDT) Date: Mon, 24 Aug 2020 11:11:02 +0200 From: Krzysztof Kozlowski To: Aisheng Dong Subject: Re: [PATCH 21/22] arm64: dts: imx8qxp: Remove i.MX7 compatible from USDHC Message-ID: <20200824091102.GA20819@kozik-lap> References: <20200823161550.3981-1-krzk@kernel.org> <20200823161550.3981-21-krzk@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200824_051107_747434_55DF9E4D X-CRM114-Status: GOOD ( 22.48 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , "linux-serial@vger.kernel.org" , Anson Huang , "linux-gpio@vger.kernel.org" , Fabio Estevam , Linus Walleij , "linux-pm@vger.kernel.org" , "linux-mmc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-pwm@vger.kernel.org" , Bartosz Golaszewski , Rob Herring , "linux-mtd@lists.infradead.org" , dl-linux-imx , Pengutronix Kernel Team , Thierry Reding , Shawn Guo , Sascha Hauer , "linux-arm-kernel@lists.infradead.org" , "linux-watchdog@vger.kernel.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Mon, Aug 24, 2020 at 09:00:19AM +0000, Aisheng Dong wrote: > > From: Krzysztof Kozlowski > > Sent: Monday, August 24, 2020 12:16 AM > > > > The USDHC on i.MX 8QXP has its own compatible described in bindings and > > used in the driver (with its own quirks). Remove additional fsl,imx7d-usdhc > > compatible to fix dtbs_check warnings like: > > > > arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dt.yaml: mmc@5b010000: > > compatible: ['fsl,imx8qxp-usdhc', 'fsl,imx7d-usdhc'] is too long > > From schema: > > /ocumentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml > > > > arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dt.yaml: mmc@5b010000: > > compatible: Additional items are not allowed ('fsl,imx7d-usdhc' was > > unexpected) > > > > Signed-off-by: Krzysztof Kozlowski > > For Patch 19-22, I think we should fix dt binding doc. Are you sure that these USDHC controllers are compatible with i.MX 7D? Could they really run with fsl,imx7d-usdhc compatible? The implementation (Linux kernel driver) is different, I guess on purpose... Best regards, Krzysztof > > Regards > Aisheng > > > --- > > arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > > b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > > index 61bccb69f09e..26c4fcdfe290 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > > @@ -362,7 +362,7 @@ > > }; > > > > usdhc1: mmc@5b010000 { > > - compatible = "fsl,imx8qxp-usdhc", "fsl,imx7d-usdhc"; > > + compatible = "fsl,imx8qxp-usdhc"; > > interrupts = ; > > reg = <0x5b010000 0x10000>; > > clocks = <&conn_lpcg IMX_CONN_LPCG_SDHC0_IPG_CLK>, @@ > > -374,7 +374,7 @@ > > }; > > > > usdhc2: mmc@5b020000 { > > - compatible = "fsl,imx8qxp-usdhc", "fsl,imx7d-usdhc"; > > + compatible = "fsl,imx8qxp-usdhc"; > > interrupts = ; > > reg = <0x5b020000 0x10000>; > > clocks = <&conn_lpcg IMX_CONN_LPCG_SDHC1_IPG_CLK>, @@ > > -388,7 +388,7 @@ > > }; > > > > usdhc3: mmc@5b030000 { > > - compatible = "fsl,imx8qxp-usdhc", "fsl,imx7d-usdhc"; > > + compatible = "fsl,imx8qxp-usdhc"; > > interrupts = ; > > reg = <0x5b030000 0x10000>; > > clocks = <&conn_lpcg IMX_CONN_LPCG_SDHC2_IPG_CLK>, > > -- > > 2.17.1 > ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EE8AC433E1 for ; Mon, 24 Aug 2020 09:12:38 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EB513206F0 for ; Mon, 24 Aug 2020 09:12:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IUif0oiI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EB513206F0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lIuxtb3k5nXwBCKgv1KE+P5rrHNhCt1FKEshGeLEBFg=; b=IUif0oiIxT7sSmllnX+hEhTo6 IkVj//qdC0dbBIHgPbES1nwcyRjeaKtICxGFBLCrKiS7UXiqRUHaGHaienIpF5/BCiCGGnh4noJr8 vNymvHah0OBKQYqgo5mH5ZwyLZ+Is3sElWjc8tsUxZA7lCf4MZ6hXnE1atfAZj1Xq33F/7/MDtJUS IA9m1mMrLzH0mQtdrWqnyL08fgsDL07SvzcZKG0KlEwmN7FsOmmTmqwcZegBv847Ldhn8gVphlW93 S0dOzS+WKv478VDDICBkim8dB7QClUb5RapquDrKXHmnnmXNpXfiHTIa+4Zn7yLOzfaw4oueAj8EX 2YjC+4cnw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kA8VT-00076U-3f; Mon, 24 Aug 2020 09:11:11 +0000 Received: from mail-wr1-f67.google.com ([209.85.221.67]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kA8VP-00074c-KM; Mon, 24 Aug 2020 09:11:08 +0000 Received: by mail-wr1-f67.google.com with SMTP id a15so7874145wrh.10; Mon, 24 Aug 2020 02:11:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=pUF3QN5qpBvG5fN8G2Ybjf+ixCnkDOi3rCaIBYZPN7k=; b=FYgNPMRObWuMT6UG2AhAauPa4BIovwrhvlzfDU+NGCd5p4BIrT7y8ETmH4gvK0nJzc BJ8TFW4wGOz7bjY3gcWYq7ZKA8ILbk9PXCiRwtp1e2/V26eSsw3FeNTyY0yyo6gXb5Ri SN3rEFgnAI4BbSqlL+d09pNn0coTmRGd0xCyOBrd9xI6LlTASrfn+UC0YhwPnXSHO92q oqdrn7gWqCX/cWXfAgzb6xOpqZ94a/v8Y+5F5DnhYvbunKaxpN6wXKsZ+EPLf1lpFPA2 D3hYbSpJDarE4S0z2Hu0n7Zw5Sa5vl25IQeaQqNWPlyWc31N97FqIsQsSQiPlKXOZ0yU +ShQ== X-Gm-Message-State: AOAM531LsJJ9e4t1bFprNPkU/e2uJgwX5QRqfWZoGyqdQo+8hYeEcvk1 E8NdXtMOREynCWZaoXMbL4Q= X-Google-Smtp-Source: ABdhPJwE3kGFDhN1s/hoJjFR2sSwbpKpOgvJl8AK3ZwbGzN+OM9ankAAiOzMdDiYIc2qELP19gLoww== X-Received: by 2002:adf:ea4f:: with SMTP id j15mr4845334wrn.253.1598260266068; Mon, 24 Aug 2020 02:11:06 -0700 (PDT) Received: from kozik-lap ([194.230.155.216]) by smtp.googlemail.com with ESMTPSA id y24sm21368601wmi.17.2020.08.24.02.11.04 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 24 Aug 2020 02:11:05 -0700 (PDT) Date: Mon, 24 Aug 2020 11:11:02 +0200 From: Krzysztof Kozlowski To: Aisheng Dong Subject: Re: [PATCH 21/22] arm64: dts: imx8qxp: Remove i.MX7 compatible from USDHC Message-ID: <20200824091102.GA20819@kozik-lap> References: <20200823161550.3981-1-krzk@kernel.org> <20200823161550.3981-21-krzk@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200824_051107_747434_55DF9E4D X-CRM114-Status: GOOD ( 22.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , "linux-serial@vger.kernel.org" , Anson Huang , "linux-gpio@vger.kernel.org" , Fabio Estevam , Linus Walleij , "linux-pm@vger.kernel.org" , "linux-mmc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-pwm@vger.kernel.org" , Bartosz Golaszewski , Rob Herring , "linux-mtd@lists.infradead.org" , dl-linux-imx , Pengutronix Kernel Team , Thierry Reding , Shawn Guo , Sascha Hauer , "linux-arm-kernel@lists.infradead.org" , "linux-watchdog@vger.kernel.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 24, 2020 at 09:00:19AM +0000, Aisheng Dong wrote: > > From: Krzysztof Kozlowski > > Sent: Monday, August 24, 2020 12:16 AM > > > > The USDHC on i.MX 8QXP has its own compatible described in bindings and > > used in the driver (with its own quirks). Remove additional fsl,imx7d-usdhc > > compatible to fix dtbs_check warnings like: > > > > arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dt.yaml: mmc@5b010000: > > compatible: ['fsl,imx8qxp-usdhc', 'fsl,imx7d-usdhc'] is too long > > From schema: > > /ocumentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml > > > > arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dt.yaml: mmc@5b010000: > > compatible: Additional items are not allowed ('fsl,imx7d-usdhc' was > > unexpected) > > > > Signed-off-by: Krzysztof Kozlowski > > For Patch 19-22, I think we should fix dt binding doc. Are you sure that these USDHC controllers are compatible with i.MX 7D? Could they really run with fsl,imx7d-usdhc compatible? The implementation (Linux kernel driver) is different, I guess on purpose... Best regards, Krzysztof > > Regards > Aisheng > > > --- > > arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > > b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > > index 61bccb69f09e..26c4fcdfe290 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > > @@ -362,7 +362,7 @@ > > }; > > > > usdhc1: mmc@5b010000 { > > - compatible = "fsl,imx8qxp-usdhc", "fsl,imx7d-usdhc"; > > + compatible = "fsl,imx8qxp-usdhc"; > > interrupts = ; > > reg = <0x5b010000 0x10000>; > > clocks = <&conn_lpcg IMX_CONN_LPCG_SDHC0_IPG_CLK>, @@ > > -374,7 +374,7 @@ > > }; > > > > usdhc2: mmc@5b020000 { > > - compatible = "fsl,imx8qxp-usdhc", "fsl,imx7d-usdhc"; > > + compatible = "fsl,imx8qxp-usdhc"; > > interrupts = ; > > reg = <0x5b020000 0x10000>; > > clocks = <&conn_lpcg IMX_CONN_LPCG_SDHC1_IPG_CLK>, @@ > > -388,7 +388,7 @@ > > }; > > > > usdhc3: mmc@5b030000 { > > - compatible = "fsl,imx8qxp-usdhc", "fsl,imx7d-usdhc"; > > + compatible = "fsl,imx8qxp-usdhc"; > > interrupts = ; > > reg = <0x5b030000 0x10000>; > > clocks = <&conn_lpcg IMX_CONN_LPCG_SDHC2_IPG_CLK>, > > -- > > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel