From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1108CC433E1 for ; Mon, 24 Aug 2020 20:40:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D34C02072D for ; Mon, 24 Aug 2020 20:40:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598301646; bh=VsjLaXv58uApo39XrXjCyhP6BZ6IBLyE8ahQ0IUsBm0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=OQnqzvJgC8r1Sv11vaZuVGTjiEd/uSFueW0DnDNaqNdwMrwPvPw1bRv5mdd7l5mRj 2vD/st7RGUFyZWrff9sM1P8OH1Csclbw4e0qmJI9yKXDRtG4v6a9lKzE+K+Qx0sO1Z S4dpyYkFdtZRRsr0PpgAaKgpniXBBLs+ZZ/a2fLc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726856AbgHXUko (ORCPT ); Mon, 24 Aug 2020 16:40:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:54160 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726303AbgHXUko (ORCPT ); Mon, 24 Aug 2020 16:40:44 -0400 Received: from kicinski-fedora-PC1C0HJN (unknown [163.114.132.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 51544205CB; Mon, 24 Aug 2020 20:40:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598301643; bh=VsjLaXv58uApo39XrXjCyhP6BZ6IBLyE8ahQ0IUsBm0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hjZs1DmXmfk8MzdH0EJ65hDd9XXpNrrx67bE9AJn0BG3+9g5E2XhYgaU/WcSCFQV9 77z2GdKbiDpUY7yVoyZ4zfrnWw6c6pSgRTUvQtc5CvOUIz7TnL/feuTqp8xj20bcsZ 8p7iXr3/Jqqq2M3TPI2ZT5P48YHR7Med+T38B4XY= Date: Mon, 24 Aug 2020 13:40:41 -0700 From: Jakub Kicinski To: "Brady, Alan" Cc: "Nguyen, Anthony L" , "davem@davemloft.net" , "Michael, Alice" , "netdev@vger.kernel.org" , "nhorman@redhat.com" , "sassmann@redhat.com" , "Kirsher, Jeffrey T" , "Burra, Phani R" , "Hay, Joshua A" , "Chittim, Madhu" , "Linga, Pavan Kumar" , "Skidmore, Donald C" , "Brandeburg, Jesse" , "Samudrala, Sridhar" Subject: Re: [net-next v5 06/15] iecm: Implement mailbox functionality Message-ID: <20200824134041.4249c0bd@kicinski-fedora-PC1C0HJN> In-Reply-To: References: <20200824173306.3178343-1-anthony.l.nguyen@intel.com> <20200824173306.3178343-7-anthony.l.nguyen@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 24 Aug 2020 20:35:51 +0000 Brady, Alan wrote: > > @@ -28,7 +36,32 @@ static enum iecm_status iecm_ctlq_init_regs(struct > > iecm_hw *hw, > > struct iecm_ctlq_info *cq, > > I believe we have made a grave error and sent the wrong version. > iecm_status enum should be completely removed. Sincere apologies for > the thrash. Will be sending another version up soon. Ugh, I was half way through review. Let me send my comments and you can see how many of them apply.