From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46ADDC433E3 for ; Mon, 24 Aug 2020 23:59:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 00F45206EB for ; Mon, 24 Aug 2020 23:59:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598313553; bh=7d8WMLdODpJNkIccXAg6ivHrSuBGOipL/H+ZTpnhSlw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=rsV2gQjEHvsJ22MF60jmxkMKgHGjrAoEqKMiSz8GNAa9Ygw7mzkJ57U30UcX/+nly VoKFx/7GePkg3tjBMXdc9Imf62azs53bVhQDnIR/BgJspnJRR1HIda96zz2NupjCGw 2aH618g+jgKlg2gKR1VFNzjEqwscg9s6+tkVjdRg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726189AbgHXX7M (ORCPT ); Mon, 24 Aug 2020 19:59:12 -0400 Received: from mail-il1-f193.google.com ([209.85.166.193]:44729 "EHLO mail-il1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726113AbgHXX7L (ORCPT ); Mon, 24 Aug 2020 19:59:11 -0400 Received: by mail-il1-f193.google.com with SMTP id j9so8871522ilc.11 for ; Mon, 24 Aug 2020 16:59:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=QWRCgizJKKL/2uZPzhKI1Q4OtzQpPo/3bVjEjcjzVBk=; b=ek4j6B+2HBTMThhyA/HPP+AifiAMuYRW86/+RB7K9q6e/VA8GGGAzQ1JL460aWDcHn ugDCT2OGOmrz20ZVwfthJDNnOrsKE/MBDBCe3Vnl/JCZ4D1cMIZLZ6O7AG/YnYqvJdwK cETdRUNwC3Xj5G7N8ZWeMYkxcicx3aZgrh97uHwYjgqG8c8C28GAh55VP9CLmdvENTTx CzlOi4zlS2L1HkcX7cKZjOcCFBphuPD6jSB2xpQ1olN1x8CJeB1H/9dlXtAa+P8f0Glh lM8noPdnpv4FeMqzPwsJnJ4TgOUdOfQ4UnyqhM4OptOiu/zoTUTQeUXHufl+DLptFDxp +Gyw== X-Gm-Message-State: AOAM531MsSS+ZIsY/NYmeZ6E7gt0DJ3hclKO/wjku5teYPohaier0F7O uPsLxP6guBHZX77Ome1nCA== X-Google-Smtp-Source: ABdhPJzBQZNc4oS7FJptwvx6rym4kg7JJWpKb28yBiw39tWuAvgQsLAA9wQ1ArK6XdryTZ7Tn0ixPA== X-Received: by 2002:a92:9151:: with SMTP id t78mr6615103ild.65.1598313550166; Mon, 24 Aug 2020 16:59:10 -0700 (PDT) Received: from xps15 ([64.188.179.249]) by smtp.gmail.com with ESMTPSA id q19sm8173858ilj.85.2020.08.24.16.59.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Aug 2020 16:59:09 -0700 (PDT) Received: (nullmailer pid 3584196 invoked by uid 1000); Mon, 24 Aug 2020 23:59:07 -0000 Date: Mon, 24 Aug 2020 17:59:07 -0600 From: Rob Herring To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, Marek Vasut , Stefan Agner , Pengutronix Kernel Team , linux-arm-kernel@lists.infradead.org, Guido =?iso-8859-1?Q?G=FCnther?= Subject: Re: [PATCH 1/8] dt-bindings: display: mxsfb: Convert binding to YAML Message-ID: <20200824235907.GB3579749@bogus> References: <20200813012910.13576-1-laurent.pinchart@ideasonboard.com> <20200813012910.13576-2-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200813012910.13576-2-laurent.pinchart@ideasonboard.com> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Aug 13, 2020 at 04:29:03AM +0300, Laurent Pinchart wrote: > Convert the mxsfb binding to YAML. The deprecated binding is dropped, as > neither the DT sources nor the driver support it anymore. Ah, the first display controller I worked on... > > The compatible strings are messy, and DT sources use different kinds of > combination of documented and undocumented values. Keep it simple for > now, and update the example to make it valid. Aligning the binding with > the existing DT sources will be performed separately. > > Signed-off-by: Laurent Pinchart > --- > .../devicetree/bindings/display/mxsfb.txt | 87 ------------- > .../devicetree/bindings/display/mxsfb.yaml | 115 ++++++++++++++++++ > MAINTAINERS | 2 +- > 3 files changed, 116 insertions(+), 88 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/display/mxsfb.txt > create mode 100644 Documentation/devicetree/bindings/display/mxsfb.yaml > > diff --git a/Documentation/devicetree/bindings/display/mxsfb.txt b/Documentation/devicetree/bindings/display/mxsfb.txt > deleted file mode 100644 > index c985871c46b3..000000000000 > --- a/Documentation/devicetree/bindings/display/mxsfb.txt > +++ /dev/null > @@ -1,87 +0,0 @@ > -* Freescale MXS LCD Interface (LCDIF) > - > -New bindings: > -============= > -Required properties: > -- compatible: Should be "fsl,imx23-lcdif" for i.MX23. > - Should be "fsl,imx28-lcdif" for i.MX28. > - Should be "fsl,imx6sx-lcdif" for i.MX6SX. > - Should be "fsl,imx8mq-lcdif" for i.MX8MQ. > -- reg: Address and length of the register set for LCDIF > -- interrupts: Should contain LCDIF interrupt > -- clocks: A list of phandle + clock-specifier pairs, one for each > - entry in 'clock-names'. > -- clock-names: A list of clock names. For MXSFB it should contain: > - - "pix" for the LCDIF block clock > - - (MX6SX-only) "axi", "disp_axi" for the bus interface clock > - > -Required sub-nodes: > - - port: The connection to an encoder chip. > - > -Example: > - > - lcdif1: display-controller@2220000 { > - compatible = "fsl,imx6sx-lcdif", "fsl,imx28-lcdif"; > - reg = <0x02220000 0x4000>; > - interrupts = ; > - clocks = <&clks IMX6SX_CLK_LCDIF1_PIX>, > - <&clks IMX6SX_CLK_LCDIF_APB>, > - <&clks IMX6SX_CLK_DISPLAY_AXI>; > - clock-names = "pix", "axi", "disp_axi"; > - > - port { > - parallel_out: endpoint { > - remote-endpoint = <&panel_in_parallel>; > - }; > - }; > - }; > - > -Deprecated bindings: > -==================== > -Required properties: > -- compatible: Should be "fsl,imx23-lcdif" for i.MX23. > - Should be "fsl,imx28-lcdif" for i.MX28. > -- reg: Address and length of the register set for LCDIF > -- interrupts: Should contain LCDIF interrupts > -- display: phandle to display node (see below for details) > - > -* display node > - > -Required properties: > -- bits-per-pixel: <16> for RGB565, <32> for RGB888/666. > -- bus-width: number of data lines. Could be <8>, <16>, <18> or <24>. > - > -Required sub-node: > -- display-timings: Refer to binding doc display-timing.txt for details. > - > -Examples: > - > -lcdif@80030000 { > - compatible = "fsl,imx28-lcdif"; > - reg = <0x80030000 2000>; > - interrupts = <38 86>; > - > - display: display { > - bits-per-pixel = <32>; > - bus-width = <24>; > - > - display-timings { > - native-mode = <&timing0>; > - timing0: timing0 { > - clock-frequency = <33500000>; > - hactive = <800>; > - vactive = <480>; > - hfront-porch = <164>; > - hback-porch = <89>; > - hsync-len = <10>; > - vback-porch = <23>; > - vfront-porch = <10>; > - vsync-len = <10>; > - hsync-active = <0>; > - vsync-active = <0>; > - de-active = <1>; > - pixelclk-active = <0>; > - }; > - }; > - }; > -}; > diff --git a/Documentation/devicetree/bindings/display/mxsfb.yaml b/Documentation/devicetree/bindings/display/mxsfb.yaml > new file mode 100644 > index 000000000000..202381ec5bb7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/mxsfb.yaml > @@ -0,0 +1,115 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/mxsfb.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Freescale/NXP i.MX LCD Interface (LCDIF) > + > +maintainers: > + - Marek Vasut > + - Stefan Agner > + > +description: | > + (e)LCDIF display controller found in the Freescale/NXP i.MX SoCs. > + > +properties: > + compatible: > + enum: > + - fsl,imx23-lcdif > + - fsl,imx28-lcdif > + - fsl,imx6sx-lcdif > + - fsl,imx8mq-lcdif > + > + reg: > + maxItems: 1 > + > + clocks: > + items: > + - description: Pixel clock > + - description: Bus clock > + - description: Display AXI clock > + minItems: 1 > + > + clock-names: > + items: > + - const: "pix" > + - const: "axi" > + - const: "disp_axi" Don't need quotes here. > + minItems: 1 > + > + interrupts: > + maxItems: 1 > + > + port: > + description: The LCDIF output port > + type: object > + > + properties: > + endpoint: > + type: object > + > + properties: > + remote-endpoint: > + $ref: /schemas/types.yaml#/definitions/phandle > + > + required: > + - remote-endpoint > + > + additionalProperties: false > + > + additionalProperties: false > + > +required: > + - compatible > + - reg > + - clocks > + - interrupts > + - port > + > +additionalProperties: false > + > +allOf: > + - if: > + properties: > + compatible: > + contains: > + const: fsl,imx6sx-lcdif > + then: > + properties: > + clocks: > + minItems: 2 > + maxItems: 3 > + clock-names: > + minItems: 2 > + maxItems: 3 > + required: > + - clock-names > + else: > + properties: > + clocks: > + minItems: 1 > + clock-names: > + minItems: 1 > + > +examples: > + - | > + #include > + #include > + > + display-controller@2220000 { > + compatible = "fsl,imx6sx-lcdif"; > + reg = <0x02220000 0x4000>; > + interrupts = ; > + clocks = <&clks IMX6SX_CLK_LCDIF1_PIX>, > + <&clks IMX6SX_CLK_LCDIF_APB>, > + <&clks IMX6SX_CLK_DISPLAY_AXI>; > + clock-names = "pix", "axi", "disp_axi"; > + > + port { > + endpoint { > + remote-endpoint = <&panel_in>; > + }; > + }; > + }; > +... > diff --git a/MAINTAINERS b/MAINTAINERS > index e3467e88714f..e3fac23383d2 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -11757,7 +11757,7 @@ M: Stefan Agner > L: dri-devel@lists.freedesktop.org > S: Supported > T: git git://anongit.freedesktop.org/drm/drm-misc > -F: Documentation/devicetree/bindings/display/mxsfb.txt > +F: Documentation/devicetree/bindings/display/mxsfb.yaml > F: drivers/gpu/drm/mxsfb/ > > MYLEX DAC960 PCI RAID Controller > -- > Regards, > > Laurent Pinchart > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7983BC433DF for ; Tue, 25 Aug 2020 00:00:37 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 39150206BE for ; Tue, 25 Aug 2020 00:00:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qmXRl4Dv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 39150206BE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bpZSbUBBBmzedhCAS0wlE2xELRYVLzIutcUgD7gfROo=; b=qmXRl4DvuYSqHREj//qtzaaBe JnJ9B6/ekrZjCQaH9XnCgb4Y0ybghDDYH7HOqlMtD1130QaUYYzpQBz97Gsc4Znnb3lCrTtwvVLHv BeFVJK4uC+JDY4RwIre2CfPHoXDDHHQB5bZUxpHAr2m6uEWimDZEMu7cw7TLC4oJRgGGtZhcjmt7x dt1cl8oYDpg17A69Dzk5lzdk+o4KNxrFPofEt/jmvjEYjePpCTYsmxp6Sb+LFQ5cFxaB9jmV3xO8g 2ffPBcHqKlXT9yZnVDAJVURnG/8+J4Aelb2OhA+77yT5PTH6DyESTQjMbyUQqCKREA9rlApv4XCiM MvR83Pmzw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kAMMr-0000Dk-0J; Mon, 24 Aug 2020 23:59:13 +0000 Received: from mail-il1-f193.google.com ([209.85.166.193]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kAMMo-0000D9-Vo for linux-arm-kernel@lists.infradead.org; Mon, 24 Aug 2020 23:59:12 +0000 Received: by mail-il1-f193.google.com with SMTP id r13so8907900iln.0 for ; Mon, 24 Aug 2020 16:59:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=QWRCgizJKKL/2uZPzhKI1Q4OtzQpPo/3bVjEjcjzVBk=; b=ErLj3atMz5o1qQb6FtlNT9cJwVyC/hBhaN8HW60S/ywIHV09/TCdXPO6A8URQyF+xC 8d5dVMivOljS3VtvLG12M/ikMvLQYjS0L+Tx0CGhwtXN68zaagTkQ3bTsb7XMEdlx3Ll PjOz1rknVyR4/BvVbQa6bk+ToaTiMYt9U+CQmETL7Dklb/RygsifDssowNmRSt1dBJV3 FKdDMJRDermqJr5voGlKrjVoVY6fp/yE7tLE+jf/A8fTsjfWsDKO5cDg9/op2egkeUgw aW01bjI39MJvoQXR59vEr/2K/ujI6qa08ElJQ9y7wbwmV1ObA/vKSKHzRQ2/1Db4a5Ie Xsbg== X-Gm-Message-State: AOAM530CCQEQoeYhxr+EYrYFH7QdDWlsUw/53jqi5MuDzGrEbpW2B+x7 jsj41FuIj/q+V0ngaRT+Vg== X-Google-Smtp-Source: ABdhPJzBQZNc4oS7FJptwvx6rym4kg7JJWpKb28yBiw39tWuAvgQsLAA9wQ1ArK6XdryTZ7Tn0ixPA== X-Received: by 2002:a92:9151:: with SMTP id t78mr6615103ild.65.1598313550166; Mon, 24 Aug 2020 16:59:10 -0700 (PDT) Received: from xps15 ([64.188.179.249]) by smtp.gmail.com with ESMTPSA id q19sm8173858ilj.85.2020.08.24.16.59.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Aug 2020 16:59:09 -0700 (PDT) Received: (nullmailer pid 3584196 invoked by uid 1000); Mon, 24 Aug 2020 23:59:07 -0000 Date: Mon, 24 Aug 2020 17:59:07 -0600 From: Rob Herring To: Laurent Pinchart Subject: Re: [PATCH 1/8] dt-bindings: display: mxsfb: Convert binding to YAML Message-ID: <20200824235907.GB3579749@bogus> References: <20200813012910.13576-1-laurent.pinchart@ideasonboard.com> <20200813012910.13576-2-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200813012910.13576-2-laurent.pinchart@ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200824_195911_081830_FA931BAE X-CRM114-Status: GOOD ( 25.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , devicetree@vger.kernel.org, Guido =?iso-8859-1?Q?G=FCnther?= , Stefan Agner , dri-devel@lists.freedesktop.org, Pengutronix Kernel Team , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 13, 2020 at 04:29:03AM +0300, Laurent Pinchart wrote: > Convert the mxsfb binding to YAML. The deprecated binding is dropped, as > neither the DT sources nor the driver support it anymore. Ah, the first display controller I worked on... > > The compatible strings are messy, and DT sources use different kinds of > combination of documented and undocumented values. Keep it simple for > now, and update the example to make it valid. Aligning the binding with > the existing DT sources will be performed separately. > > Signed-off-by: Laurent Pinchart > --- > .../devicetree/bindings/display/mxsfb.txt | 87 ------------- > .../devicetree/bindings/display/mxsfb.yaml | 115 ++++++++++++++++++ > MAINTAINERS | 2 +- > 3 files changed, 116 insertions(+), 88 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/display/mxsfb.txt > create mode 100644 Documentation/devicetree/bindings/display/mxsfb.yaml > > diff --git a/Documentation/devicetree/bindings/display/mxsfb.txt b/Documentation/devicetree/bindings/display/mxsfb.txt > deleted file mode 100644 > index c985871c46b3..000000000000 > --- a/Documentation/devicetree/bindings/display/mxsfb.txt > +++ /dev/null > @@ -1,87 +0,0 @@ > -* Freescale MXS LCD Interface (LCDIF) > - > -New bindings: > -============= > -Required properties: > -- compatible: Should be "fsl,imx23-lcdif" for i.MX23. > - Should be "fsl,imx28-lcdif" for i.MX28. > - Should be "fsl,imx6sx-lcdif" for i.MX6SX. > - Should be "fsl,imx8mq-lcdif" for i.MX8MQ. > -- reg: Address and length of the register set for LCDIF > -- interrupts: Should contain LCDIF interrupt > -- clocks: A list of phandle + clock-specifier pairs, one for each > - entry in 'clock-names'. > -- clock-names: A list of clock names. For MXSFB it should contain: > - - "pix" for the LCDIF block clock > - - (MX6SX-only) "axi", "disp_axi" for the bus interface clock > - > -Required sub-nodes: > - - port: The connection to an encoder chip. > - > -Example: > - > - lcdif1: display-controller@2220000 { > - compatible = "fsl,imx6sx-lcdif", "fsl,imx28-lcdif"; > - reg = <0x02220000 0x4000>; > - interrupts = ; > - clocks = <&clks IMX6SX_CLK_LCDIF1_PIX>, > - <&clks IMX6SX_CLK_LCDIF_APB>, > - <&clks IMX6SX_CLK_DISPLAY_AXI>; > - clock-names = "pix", "axi", "disp_axi"; > - > - port { > - parallel_out: endpoint { > - remote-endpoint = <&panel_in_parallel>; > - }; > - }; > - }; > - > -Deprecated bindings: > -==================== > -Required properties: > -- compatible: Should be "fsl,imx23-lcdif" for i.MX23. > - Should be "fsl,imx28-lcdif" for i.MX28. > -- reg: Address and length of the register set for LCDIF > -- interrupts: Should contain LCDIF interrupts > -- display: phandle to display node (see below for details) > - > -* display node > - > -Required properties: > -- bits-per-pixel: <16> for RGB565, <32> for RGB888/666. > -- bus-width: number of data lines. Could be <8>, <16>, <18> or <24>. > - > -Required sub-node: > -- display-timings: Refer to binding doc display-timing.txt for details. > - > -Examples: > - > -lcdif@80030000 { > - compatible = "fsl,imx28-lcdif"; > - reg = <0x80030000 2000>; > - interrupts = <38 86>; > - > - display: display { > - bits-per-pixel = <32>; > - bus-width = <24>; > - > - display-timings { > - native-mode = <&timing0>; > - timing0: timing0 { > - clock-frequency = <33500000>; > - hactive = <800>; > - vactive = <480>; > - hfront-porch = <164>; > - hback-porch = <89>; > - hsync-len = <10>; > - vback-porch = <23>; > - vfront-porch = <10>; > - vsync-len = <10>; > - hsync-active = <0>; > - vsync-active = <0>; > - de-active = <1>; > - pixelclk-active = <0>; > - }; > - }; > - }; > -}; > diff --git a/Documentation/devicetree/bindings/display/mxsfb.yaml b/Documentation/devicetree/bindings/display/mxsfb.yaml > new file mode 100644 > index 000000000000..202381ec5bb7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/mxsfb.yaml > @@ -0,0 +1,115 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/mxsfb.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Freescale/NXP i.MX LCD Interface (LCDIF) > + > +maintainers: > + - Marek Vasut > + - Stefan Agner > + > +description: | > + (e)LCDIF display controller found in the Freescale/NXP i.MX SoCs. > + > +properties: > + compatible: > + enum: > + - fsl,imx23-lcdif > + - fsl,imx28-lcdif > + - fsl,imx6sx-lcdif > + - fsl,imx8mq-lcdif > + > + reg: > + maxItems: 1 > + > + clocks: > + items: > + - description: Pixel clock > + - description: Bus clock > + - description: Display AXI clock > + minItems: 1 > + > + clock-names: > + items: > + - const: "pix" > + - const: "axi" > + - const: "disp_axi" Don't need quotes here. > + minItems: 1 > + > + interrupts: > + maxItems: 1 > + > + port: > + description: The LCDIF output port > + type: object > + > + properties: > + endpoint: > + type: object > + > + properties: > + remote-endpoint: > + $ref: /schemas/types.yaml#/definitions/phandle > + > + required: > + - remote-endpoint > + > + additionalProperties: false > + > + additionalProperties: false > + > +required: > + - compatible > + - reg > + - clocks > + - interrupts > + - port > + > +additionalProperties: false > + > +allOf: > + - if: > + properties: > + compatible: > + contains: > + const: fsl,imx6sx-lcdif > + then: > + properties: > + clocks: > + minItems: 2 > + maxItems: 3 > + clock-names: > + minItems: 2 > + maxItems: 3 > + required: > + - clock-names > + else: > + properties: > + clocks: > + minItems: 1 > + clock-names: > + minItems: 1 > + > +examples: > + - | > + #include > + #include > + > + display-controller@2220000 { > + compatible = "fsl,imx6sx-lcdif"; > + reg = <0x02220000 0x4000>; > + interrupts = ; > + clocks = <&clks IMX6SX_CLK_LCDIF1_PIX>, > + <&clks IMX6SX_CLK_LCDIF_APB>, > + <&clks IMX6SX_CLK_DISPLAY_AXI>; > + clock-names = "pix", "axi", "disp_axi"; > + > + port { > + endpoint { > + remote-endpoint = <&panel_in>; > + }; > + }; > + }; > +... > diff --git a/MAINTAINERS b/MAINTAINERS > index e3467e88714f..e3fac23383d2 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -11757,7 +11757,7 @@ M: Stefan Agner > L: dri-devel@lists.freedesktop.org > S: Supported > T: git git://anongit.freedesktop.org/drm/drm-misc > -F: Documentation/devicetree/bindings/display/mxsfb.txt > +F: Documentation/devicetree/bindings/display/mxsfb.yaml > F: drivers/gpu/drm/mxsfb/ > > MYLEX DAC960 PCI RAID Controller > -- > Regards, > > Laurent Pinchart > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.0 required=3.0 tests=BAYES_00,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8A83C433E1 for ; Mon, 24 Aug 2020 23:59:12 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 78D302063A for ; Mon, 24 Aug 2020 23:59:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 78D302063A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BED156E7D5; Mon, 24 Aug 2020 23:59:11 +0000 (UTC) Received: from mail-il1-f194.google.com (mail-il1-f194.google.com [209.85.166.194]) by gabe.freedesktop.org (Postfix) with ESMTPS id D904D6E7D5 for ; Mon, 24 Aug 2020 23:59:10 +0000 (UTC) Received: by mail-il1-f194.google.com with SMTP id e11so8893772ils.10 for ; Mon, 24 Aug 2020 16:59:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=QWRCgizJKKL/2uZPzhKI1Q4OtzQpPo/3bVjEjcjzVBk=; b=J8Eu+bPWMldvmXPdGDzOFUuWZJ+mOSke5ZCq8pHmm1dqNc91HIkd1JTGNZETrNQH5u jzdGIWBHsASyQRYU5d8KpWYaiom1H9yz/DtLgbvreU78dpNbBXSbC2qQ+/hEzi7uz80G Emsaxm/8JZBYaaCjOZ3M+M3JJcPP/sCvWY42nRkKIao2HyLseV7jZcJS6/Bi5UXVP4jv JWBB9D3nGs8SuICDa7W7lvdiU7hwilYCw6OUt0uP6A9rRzAEv4zguhMOEZCsBMyl4bpB 2m4c8xPWyKS2+tgLcqSrLmz18P9mlkiQznXQgiDzH3cmDHco7jO2bbfDsruf2KRH9Iuf l9/g== X-Gm-Message-State: AOAM5300uM1Ad0HizdeImvp3zPfwFJJLVinT8mMgWw0FF9vRj1mykVeT 9F6J6YSkI5KqUl7uQ4n1aw== X-Google-Smtp-Source: ABdhPJzBQZNc4oS7FJptwvx6rym4kg7JJWpKb28yBiw39tWuAvgQsLAA9wQ1ArK6XdryTZ7Tn0ixPA== X-Received: by 2002:a92:9151:: with SMTP id t78mr6615103ild.65.1598313550166; Mon, 24 Aug 2020 16:59:10 -0700 (PDT) Received: from xps15 ([64.188.179.249]) by smtp.gmail.com with ESMTPSA id q19sm8173858ilj.85.2020.08.24.16.59.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Aug 2020 16:59:09 -0700 (PDT) Received: (nullmailer pid 3584196 invoked by uid 1000); Mon, 24 Aug 2020 23:59:07 -0000 Date: Mon, 24 Aug 2020 17:59:07 -0600 From: Rob Herring To: Laurent Pinchart Subject: Re: [PATCH 1/8] dt-bindings: display: mxsfb: Convert binding to YAML Message-ID: <20200824235907.GB3579749@bogus> References: <20200813012910.13576-1-laurent.pinchart@ideasonboard.com> <20200813012910.13576-2-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200813012910.13576-2-laurent.pinchart@ideasonboard.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , devicetree@vger.kernel.org, Guido =?iso-8859-1?Q?G=FCnther?= , dri-devel@lists.freedesktop.org, Pengutronix Kernel Team , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Aug 13, 2020 at 04:29:03AM +0300, Laurent Pinchart wrote: > Convert the mxsfb binding to YAML. The deprecated binding is dropped, as > neither the DT sources nor the driver support it anymore. Ah, the first display controller I worked on... > > The compatible strings are messy, and DT sources use different kinds of > combination of documented and undocumented values. Keep it simple for > now, and update the example to make it valid. Aligning the binding with > the existing DT sources will be performed separately. > > Signed-off-by: Laurent Pinchart > --- > .../devicetree/bindings/display/mxsfb.txt | 87 ------------- > .../devicetree/bindings/display/mxsfb.yaml | 115 ++++++++++++++++++ > MAINTAINERS | 2 +- > 3 files changed, 116 insertions(+), 88 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/display/mxsfb.txt > create mode 100644 Documentation/devicetree/bindings/display/mxsfb.yaml > > diff --git a/Documentation/devicetree/bindings/display/mxsfb.txt b/Documentation/devicetree/bindings/display/mxsfb.txt > deleted file mode 100644 > index c985871c46b3..000000000000 > --- a/Documentation/devicetree/bindings/display/mxsfb.txt > +++ /dev/null > @@ -1,87 +0,0 @@ > -* Freescale MXS LCD Interface (LCDIF) > - > -New bindings: > -============= > -Required properties: > -- compatible: Should be "fsl,imx23-lcdif" for i.MX23. > - Should be "fsl,imx28-lcdif" for i.MX28. > - Should be "fsl,imx6sx-lcdif" for i.MX6SX. > - Should be "fsl,imx8mq-lcdif" for i.MX8MQ. > -- reg: Address and length of the register set for LCDIF > -- interrupts: Should contain LCDIF interrupt > -- clocks: A list of phandle + clock-specifier pairs, one for each > - entry in 'clock-names'. > -- clock-names: A list of clock names. For MXSFB it should contain: > - - "pix" for the LCDIF block clock > - - (MX6SX-only) "axi", "disp_axi" for the bus interface clock > - > -Required sub-nodes: > - - port: The connection to an encoder chip. > - > -Example: > - > - lcdif1: display-controller@2220000 { > - compatible = "fsl,imx6sx-lcdif", "fsl,imx28-lcdif"; > - reg = <0x02220000 0x4000>; > - interrupts = ; > - clocks = <&clks IMX6SX_CLK_LCDIF1_PIX>, > - <&clks IMX6SX_CLK_LCDIF_APB>, > - <&clks IMX6SX_CLK_DISPLAY_AXI>; > - clock-names = "pix", "axi", "disp_axi"; > - > - port { > - parallel_out: endpoint { > - remote-endpoint = <&panel_in_parallel>; > - }; > - }; > - }; > - > -Deprecated bindings: > -==================== > -Required properties: > -- compatible: Should be "fsl,imx23-lcdif" for i.MX23. > - Should be "fsl,imx28-lcdif" for i.MX28. > -- reg: Address and length of the register set for LCDIF > -- interrupts: Should contain LCDIF interrupts > -- display: phandle to display node (see below for details) > - > -* display node > - > -Required properties: > -- bits-per-pixel: <16> for RGB565, <32> for RGB888/666. > -- bus-width: number of data lines. Could be <8>, <16>, <18> or <24>. > - > -Required sub-node: > -- display-timings: Refer to binding doc display-timing.txt for details. > - > -Examples: > - > -lcdif@80030000 { > - compatible = "fsl,imx28-lcdif"; > - reg = <0x80030000 2000>; > - interrupts = <38 86>; > - > - display: display { > - bits-per-pixel = <32>; > - bus-width = <24>; > - > - display-timings { > - native-mode = <&timing0>; > - timing0: timing0 { > - clock-frequency = <33500000>; > - hactive = <800>; > - vactive = <480>; > - hfront-porch = <164>; > - hback-porch = <89>; > - hsync-len = <10>; > - vback-porch = <23>; > - vfront-porch = <10>; > - vsync-len = <10>; > - hsync-active = <0>; > - vsync-active = <0>; > - de-active = <1>; > - pixelclk-active = <0>; > - }; > - }; > - }; > -}; > diff --git a/Documentation/devicetree/bindings/display/mxsfb.yaml b/Documentation/devicetree/bindings/display/mxsfb.yaml > new file mode 100644 > index 000000000000..202381ec5bb7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/mxsfb.yaml > @@ -0,0 +1,115 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/mxsfb.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Freescale/NXP i.MX LCD Interface (LCDIF) > + > +maintainers: > + - Marek Vasut > + - Stefan Agner > + > +description: | > + (e)LCDIF display controller found in the Freescale/NXP i.MX SoCs. > + > +properties: > + compatible: > + enum: > + - fsl,imx23-lcdif > + - fsl,imx28-lcdif > + - fsl,imx6sx-lcdif > + - fsl,imx8mq-lcdif > + > + reg: > + maxItems: 1 > + > + clocks: > + items: > + - description: Pixel clock > + - description: Bus clock > + - description: Display AXI clock > + minItems: 1 > + > + clock-names: > + items: > + - const: "pix" > + - const: "axi" > + - const: "disp_axi" Don't need quotes here. > + minItems: 1 > + > + interrupts: > + maxItems: 1 > + > + port: > + description: The LCDIF output port > + type: object > + > + properties: > + endpoint: > + type: object > + > + properties: > + remote-endpoint: > + $ref: /schemas/types.yaml#/definitions/phandle > + > + required: > + - remote-endpoint > + > + additionalProperties: false > + > + additionalProperties: false > + > +required: > + - compatible > + - reg > + - clocks > + - interrupts > + - port > + > +additionalProperties: false > + > +allOf: > + - if: > + properties: > + compatible: > + contains: > + const: fsl,imx6sx-lcdif > + then: > + properties: > + clocks: > + minItems: 2 > + maxItems: 3 > + clock-names: > + minItems: 2 > + maxItems: 3 > + required: > + - clock-names > + else: > + properties: > + clocks: > + minItems: 1 > + clock-names: > + minItems: 1 > + > +examples: > + - | > + #include > + #include > + > + display-controller@2220000 { > + compatible = "fsl,imx6sx-lcdif"; > + reg = <0x02220000 0x4000>; > + interrupts = ; > + clocks = <&clks IMX6SX_CLK_LCDIF1_PIX>, > + <&clks IMX6SX_CLK_LCDIF_APB>, > + <&clks IMX6SX_CLK_DISPLAY_AXI>; > + clock-names = "pix", "axi", "disp_axi"; > + > + port { > + endpoint { > + remote-endpoint = <&panel_in>; > + }; > + }; > + }; > +... > diff --git a/MAINTAINERS b/MAINTAINERS > index e3467e88714f..e3fac23383d2 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -11757,7 +11757,7 @@ M: Stefan Agner > L: dri-devel@lists.freedesktop.org > S: Supported > T: git git://anongit.freedesktop.org/drm/drm-misc > -F: Documentation/devicetree/bindings/display/mxsfb.txt > +F: Documentation/devicetree/bindings/display/mxsfb.yaml > F: drivers/gpu/drm/mxsfb/ > > MYLEX DAC960 PCI RAID Controller > -- > Regards, > > Laurent Pinchart > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel