From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7CB8C433E1 for ; Tue, 25 Aug 2020 00:18:26 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9D2A4207D3 for ; Tue, 25 Aug 2020 00:18:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="W4L3amHR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9D2A4207D3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=nongnu.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55436 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kAMfR-0005Tg-PK for qemu-devel@archiver.kernel.org; Mon, 24 Aug 2020 20:18:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45068) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <3klhEXwsKClU4F75AA19B1A3BB381.zB9D19H-01I18ABA3AH.BE3@flex--hskinnemoen.bounces.google.com>) id 1kAMeV-0003jX-Eg for qemu-devel@nongnu.org; Mon, 24 Aug 2020 20:17:27 -0400 Received: from mail-qt1-x849.google.com ([2607:f8b0:4864:20::849]:37024) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <3klhEXwsKClU4F75AA19B1A3BB381.zB9D19H-01I18ABA3AH.BE3@flex--hskinnemoen.bounces.google.com>) id 1kAMeS-00066I-Dw for qemu-devel@nongnu.org; Mon, 24 Aug 2020 20:17:27 -0400 Received: by mail-qt1-x849.google.com with SMTP id w1so5543634qto.4 for ; Mon, 24 Aug 2020 17:17:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:date:message-id:mime-version:subject:from:to:cc :content-transfer-encoding; bh=HDMqF15ByzdtnVRrzeEz//4hsMrvWD9k/IiV1FE6IJ8=; b=W4L3amHREKEd0GUye/hQ+PNhtg04yF7mnhh34udI66FNcMqLFL4djzo5ZidFRflpaC t7wrH1Ctpar4DrzTpJ7nW0UznaOhPmnl7RvAQm0+rZvY99Qp4OEh6x0GvWzecH//9QYV 6GHJPzJoTV4M3Esh7eKU972eUJskg1bwtBt1ztVjFkYlIGUmDwXbRGP8tSBZVqwWPTLy u7/TmmBPn05k0kiR34yr4pGSkt9S5ZMAY5HmtnpR5T0u9+KY3azxQ7TvPQB4T/IJmwyX RZe5/ZO4Njk4ohJy85fSo8Y3EPQhecLE0+Rr7BHzABFMVnRViMFgiJYqqT6T3jUwgKNi FQsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:message-id:mime-version:subject:from :to:cc:content-transfer-encoding; bh=HDMqF15ByzdtnVRrzeEz//4hsMrvWD9k/IiV1FE6IJ8=; b=RPuo9KXkBY73hhLMf/AZEajhU3IEH6JcLtwFxa0SBTJ9TMmRCJCR3NxXYV1ADAZfdI Ps9oidi0BZnt5X1vim9VpKfBGgAjpSQIGXFynp0IIgUgVf3HYnYb3icsFpU3hr51yO/F tCRh6LxMvrJT9mbbNpsqBVfzShJYyLGJT0yy4NM6yl3Pfq1bhQgxyTgWMhD5mkyz8pNg ed4Hlruw8LrW6ufC7jr5PUziNmK3kWQYcqoOdaCoJUgj9Eq6GajDHwilpdwTTzpjjNQy 6+L3QOI2PdAc75EiOnb9SQ22xH0LktFLShIR4WIr2ylVx1b7rixGab9RDz6yHIrYqPib BH1w== X-Gm-Message-State: AOAM533sF+z7e7vYMVL2z/b442PJDsea2Q83JC81KGBdilzChPJzgEzJ +PqcdvweYdt0c6DcB25JgKkdofHP+P74Zdcddg== X-Google-Smtp-Source: ABdhPJy99xlnjjt7s7QcUf0IqbpjFge+8e83Mue6H+AKXxSyrK9xtdtEJMnZzBBjXe/yNbbKvPQiUhuNeKuhKaCzpg== X-Received: from skybert.c.googlers.com ([fda3:e722:ac3:10:24:72f4:c0a8:3107]) (user=hskinnemoen job=sendgmr) by 2002:ad4:438f:: with SMTP id s15mr7459372qvr.164.1598314642182; Mon, 24 Aug 2020 17:17:22 -0700 (PDT) Date: Mon, 24 Aug 2020 17:16:57 -0700 Message-Id: <20200825001711.1340443-1-hskinnemoen@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.28.0.297.g1956fa8f8d-goog Subject: [PATCH v8 00/14] Add Nuvoton NPCM730/NPCM750 SoCs and two BMC machines To: peter.maydell@linaro.org, f4bug@amsat.org Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, Avi.Fishman@nuvoton.com, kfting@nuvoton.com, Havard Skinnemoen Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::849; envelope-from=3klhEXwsKClU4F75AA19B1A3BB381.zB9D19H-01I18ABA3AH.BE3@flex--hskinnemoen.bounces.google.com; helo=mail-qt1-x849.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -95 X-Spam_score: -9.6 X-Spam_bar: --------- X-Spam_report: (-9.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Reply-to: Havard Skinnemoen From: Havard Skinnemoen via I also pushed this and the previous patchsets to my qemu fork on github. The branches are named npcm7xx-v[1-8]. https://github.com/hskinnemoen/qemu This patch series models enough of the Nuvoton NPCM730 and NPCM750 SoCs to = boot an OpenBMC image built for quanta-gsj. This includes device models for: - Global Configuration Registers - Clock Control - Timers - Fuses - Memory Controller - Flash Controller These modules, along with the existing Cortex A9 CPU cores and built-in peripherals, are integrated into a NPCM730 or NPCM750 SoC, which in turn fo= rm the foundation for the quanta-gsj and npcm750-evb machines, respectively. T= he two SoCs are very similar; the only difference is that NPCM730 is missing s= ome peripherals that NPCM750 has, and which are not considered essential for datacenter use (e.g. graphics controllers). For more information, see https://www.nuvoton.com/products/cloud-computing/ibmc/ Both quanta-gsj and npcm750-evb correspond to real boards supported by Open= BMC. At the end of the series, qemu can boot an OpenBMC image built for one of t= hese boards with some minor modifications. The patches in this series were developed by Google and reviewed by Nuvoton= . We will be maintaining the machine and peripheral support together. The data sheet for these SoCs is not generally available. Please let me kno= w if more comments are needed to understand the device behavior. Changes since v7: - Move register enums to .c files throughout, leaving a single NPCM7XX_FOO_NR_REGS definition behind in the .h file. A QEMU_BUILD_BUG_= ON should alert anyone accidentally expanding the register enum that they = need to update the corresponding NR_REGS define, which in turn has a comment reminding them to update the vmstate version_id as well. - Skip loading the bootrom if a kernel filename is provided by the user. - New patch adding a board setup stub to tweak clocks before booting dire= ctly into the kernel. - Add stuff to meson files instead of Makefiles. - Try to disable the slowest drivers and services to speed up the flash b= oot acceptance test a bit. This is somewhat based on the following systemd-analyze blame report: https://gist.github.com/hskinnemoen/475cb0676530cd2cebaa1754cf16ca97 Changes since v6: - Use size_to_str to report DRAM sizes in npcm7xx_gcr. - Simplify the interrupt logic in npcm7xx_timer. - Update global bios_name instead of temporary. - Add npcm7xx_bootrom to MAINTAINERS and pc-bios/README. - Use a predefined name for the gsj boot image in the acceptance test. Changes since v5: - Boot ROM included, as a git submodule and a binary blob, and loaded by default, so the -bios option is usually not necessary anymore. - Two acceptance tests added (openbmc image boot, and direct kernel boot)= . - npcm7xx_load_kernel() moved to SoC code. - NPCM7XX_TIMER_REF_HZ definition moved to CLK header. - Comments added clarifying available SPI flash chip selects. - Error handling adjustments: - Errors from CPU and GCR realization are propagated through the SoC since they may be triggered by user-configurable parameters. - Machine init uses error_fatal instead of error_abort for SoC realization flash init. This makes error messages more helpful. - Comments added to indicate whether peripherals may fail to realize. - Use ERRP_GUARD() instead of Error *err when possible. - Default CPU type is now set, and attempting to set it to anything else will fail. - Format string fixes (use HWADDR_PRIx, etc.) - Simplified memory size encoding and error checking in npcm7xx_gcr. - Encapsulate non-obvious pointer subtraction into helper functions in th= e FIU and TIMER modules. - Incorporate review feedback into the FIU module: - Add select/deselect trace events. - Use npcm7xx_fiu_{de,}select() consistently. - Use extract/deposit in more places for consistency. - Use -Wimplicit-fallthrough compatible fallthrough comments. - Use qdev_init_gpio_out_named instead of sysbus_init_irq for chip selects. - Incorporate review feedback into the TIMER module: - Assert that we never pause a timer that has already expired, instea= d of trying to handle it. This should be safe since QEMU_CLOCK_VIRTUAL i= s stopped while this code is running. - Simplify the switch blocks in the read and write handlers. I made a change to error out if a flash drive was not specified, but revert= ed it because it caused make check to fail (qom-test). When specifying a NULL block device, the m25p flash device initializes its in-memory storage with = 0xff and doesn't attempt to write anything back. This seems correct to me. Changes since v4: - OTP cleanups suggested by Philippe Mathieu-Daud=C3=A9. - Added fuse array definitions based on public Nuvoton bootblock code= . - Moved class structure to .c file since it's only used internally. - Readability improvements. - Split the first patch and folded parts of it into three other patches s= o that CONFIG_NPCM7XX is only enabled after the initial NPCM7xx machine support is added. - DRAM init moved to machine init code. - Consistently use lower-case hex literals. - Switched to fine-grained unimplemented devices, based on public bootblo= ck source code. Added a tiny SRAM that got left out previously. - Simplified error handling in npcm7xx_realize() since the board code wil= l abort anyway, and SoCs are not hot-pluggable. Changes since v3: - License headers are now GPL v2-or-later throughout. - Added vmstate throughout (except the memory controller, which doesn't really have any state worth saving). Successfully booted a gsj image with two stop/savevm/quit/loadvm cycles along the way. - JFFS2 really doesn't like it if I let qemu keep running after savev= m, and then jump back in time with loadvm. I assume this is expected. - Fixed an error API violation in npcm7xx_realize, removed pointless erro= r check after object_property_set_link(). - Switched the OTP device to use an embedded array instead of a g_malloc0= 'd one because I couldn't figure out how to set up vmstate for the latter. Changes since v2: - Simplified the MAINTAINERS entry. - Added link to OpenPOWER jenkins for gsj BMC images. - Reverted the smpboot change, back to byte swapping. - Adapted to upstream API changes: - sysbus_init_child_obj -> object_initialize_child - object_property_set_bool -> qdev_realize / sysbus_realize - ssi_create_slave_no_init -> qdev_new - qdev_init_nofail -> qdev_realize_and_unref - ssi_auto_connect_slaves removed - Moved Boot ROM loading from soc to machine init. - Plumbed power-on-straps property from GCR to the machine init code so i= t can be properly initialized. Turns out npcm750 memory init doesn't work without this. npcm730 is fine either way, though I'm not sure why. - Reworked the flash init code so it looks more like aspeed (i.e. the fla= sh device gets added even if there's no drive). Changes since v1 (requested by reviewers): - Clarify the source of CLK reset values. - Made smpboot a constant byte array, eliinated byte swapping. - NPCM7xxState now stores an array of ARMCPUs, not pointers to ARMCPUs. - Clarify why EL3 is disabled. - Introduce NPCM7XX_NUM_IRQ constant. - Set the number of CPUs according to SoC variant, and disallow command l= ine overrides (i.e. you can no longer override the number of CPUs with the = -smp parameter). This is trying to follow the spirit of https://patchwork.kernel.org/patch/11595407/. - Switch register operations to DEVICE_LITTLE_ENDIAN throughout. - Machine documentation added (new patch). Changes since v1 to support flash booting: - GCR reset value changes to get past memory initialization when booting from flash (patches 2 and 5): - INTCR2 now indicates that the DDR controller is initialized. - INTCR3 is initialized according to DDR memory size. A realize() method was implemented to achieve this. - Refactor the machine initialization a bit to make it easier to drop in machine-specific flash initialization (patch 6). - Extend the series with additional patches to enable booting from flash: - Boot ROM (through the -bios option). - OTP (fuse) controller. - Memory Controller stub (just enough to skip memory training). - Flash controller. - Board-specific flash initialization. Thanks for reviewing, Havard Havard Skinnemoen (14): hw/misc: Add NPCM7xx System Global Control Registers device model hw/misc: Add NPCM7xx Clock Controller device model hw/timer: Add NPCM7xx Timer device model hw/arm: Add NPCM730 and NPCM750 SoC models hw/arm: Add two NPCM7xx-based machines roms: Add virtual Boot ROM for NPCM7xx SoCs hw/arm: Load -bios image as a boot ROM for npcm7xx hw/nvram: NPCM7xx OTP device model hw/mem: Stubbed out NPCM7xx Memory Controller model hw/ssi: NPCM7xx Flash Interface Unit device model hw/arm: Wire up BMC boot flash for npcm750-evb and quanta-gsj hw/arm/npcm7xx: add board setup stub for CPU and UART clocks docs/system: Add Nuvoton machine documentation tests/acceptance: console boot tests for quanta-gsj docs/system/arm/nuvoton.rst | 90 ++++ docs/system/target-arm.rst | 1 + Makefile | 1 + default-configs/arm-softmmu.mak | 1 + include/hw/arm/npcm7xx.h | 112 +++++ include/hw/mem/npcm7xx_mc.h | 36 ++ include/hw/misc/npcm7xx_clk.h | 48 +++ include/hw/misc/npcm7xx_gcr.h | 43 ++ include/hw/nvram/npcm7xx_otp.h | 79 ++++ include/hw/ssi/npcm7xx_fiu.h | 73 ++++ include/hw/timer/npcm7xx_timer.h | 78 ++++ hw/arm/npcm7xx.c | 532 +++++++++++++++++++++++ hw/arm/npcm7xx_boards.c | 197 +++++++++ hw/mem/npcm7xx_mc.c | 84 ++++ hw/misc/npcm7xx_clk.c | 266 ++++++++++++ hw/misc/npcm7xx_gcr.c | 269 ++++++++++++ hw/nvram/npcm7xx_otp.c | 439 +++++++++++++++++++ hw/ssi/npcm7xx_fiu.c | 572 +++++++++++++++++++++++++ hw/timer/npcm7xx_timer.c | 509 ++++++++++++++++++++++ .gitmodules | 3 + MAINTAINERS | 10 + hw/arm/Kconfig | 9 + hw/arm/meson.build | 1 + hw/mem/meson.build | 1 + hw/misc/meson.build | 4 + hw/misc/trace-events | 8 + hw/nvram/meson.build | 1 + hw/ssi/meson.build | 1 + hw/ssi/trace-events | 11 + hw/timer/meson.build | 1 + hw/timer/trace-events | 5 + pc-bios/README | 6 + pc-bios/npcm7xx_bootrom.bin | Bin 0 -> 768 bytes roms/Makefile | 7 + roms/vbootrom | 1 + tests/acceptance/boot_linux_console.py | 83 ++++ 36 files changed, 3582 insertions(+) create mode 100644 docs/system/arm/nuvoton.rst create mode 100644 include/hw/arm/npcm7xx.h create mode 100644 include/hw/mem/npcm7xx_mc.h create mode 100644 include/hw/misc/npcm7xx_clk.h create mode 100644 include/hw/misc/npcm7xx_gcr.h create mode 100644 include/hw/nvram/npcm7xx_otp.h create mode 100644 include/hw/ssi/npcm7xx_fiu.h create mode 100644 include/hw/timer/npcm7xx_timer.h create mode 100644 hw/arm/npcm7xx.c create mode 100644 hw/arm/npcm7xx_boards.c create mode 100644 hw/mem/npcm7xx_mc.c create mode 100644 hw/misc/npcm7xx_clk.c create mode 100644 hw/misc/npcm7xx_gcr.c create mode 100644 hw/nvram/npcm7xx_otp.c create mode 100644 hw/ssi/npcm7xx_fiu.c create mode 100644 hw/timer/npcm7xx_timer.c create mode 100644 pc-bios/npcm7xx_bootrom.bin create mode 160000 roms/vbootrom --=20 2.28.0.297.g1956fa8f8d-goog