From: Alan Stern <stern@rowland.harvard.edu>
To: Tom Rix <trix@redhat.com>
Cc: Vito Caputo <vcaputo@pengaru.com>,
gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
usb-storage@lists.one-eyed-alien.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] usb: storage: initialize variable
Date: Mon, 24 Aug 2020 20:36:33 -0400 [thread overview]
Message-ID: <20200825003633.GB350601@rowland.harvard.edu> (raw)
In-Reply-To: <c9c4fca2-d04a-1bf9-e90e-9476392c1662@redhat.com>
On Mon, Aug 24, 2020 at 02:31:01PM -0700, Tom Rix wrote:
>
> On 8/24/20 2:18 PM, Vito Caputo wrote:
> > On Mon, Aug 24, 2020 at 02:10:27PM -0700, trix@redhat.com wrote:
> >> From: Tom Rix <trix@redhat.com>
> >>
> >> clang static analysis reports this representative problem
> >>
> >> transport.c:495:15: warning: Assigned value is garbage or
> >> undefined
> >> length_left -= partial;
> >> ^ ~~~~~~~
> >> partial is set only when usb_stor_bulk_transfer_sglist()
> >> is successful.
> >>
> >> So set partial on entry to 0.
> >>
> >> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> >> Signed-off-by: Tom Rix <trix@redhat.com>
> >> ---
> >> drivers/usb/storage/transport.c | 3 +++
> >> 1 file changed, 3 insertions(+)
> >>
> >> diff --git a/drivers/usb/storage/transport.c b/drivers/usb/storage/transport.c
> >> index 238a8088e17f..044429717dcc 100644
> >> --- a/drivers/usb/storage/transport.c
> >> +++ b/drivers/usb/storage/transport.c
> >> @@ -414,6 +414,9 @@ static int usb_stor_bulk_transfer_sglist(struct us_data *us, unsigned int pipe,
> >> {
> >> int result;
> >>
> >> + if (act_len)
> >> + *act_len = 0;
> >> +
> >> /* don't submit s-g requests during abort processing */
> >> if (test_bit(US_FLIDX_ABORTING, &us->dflags))
> >> return USB_STOR_XFER_ERROR;
> > At a glance this seems odd to me. If the caller insists on ignoring
> > the return value, shouldn't it just initialize partial to zero?
> >
> > In my experience it's generally frowned upon for functions to store
> > results in error paths.
>
> Then maybe v1 is more appropriate.
>
> Else i can spin a v3.
>
> My preference is v1 as it doesn't add any runtime if-checks.
If you really want to get rid of the runtime check (both the one you
added and the one already present), you can audit all the callers of
this routine to make certain that none of them pass a NULL pointer for
act_len.
Alan Stern
next prev parent reply other threads:[~2020-08-25 0:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-24 21:10 [PATCH v2] usb: storage: initialize variable trix
2020-08-24 21:18 ` Vito Caputo
2020-08-24 21:31 ` Tom Rix
2020-08-25 0:36 ` Alan Stern [this message]
2020-08-25 0:35 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200825003633.GB350601@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=trix@redhat.com \
--cc=usb-storage@lists.one-eyed-alien.net \
--cc=vcaputo@pengaru.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.