All of lore.kernel.org
 help / color / mirror / Atom feed
From: Javed Hasan <jhasan@marvell.com>
To: <martin.petersen@oracle.com>
Cc: <linux-scsi@vger.kernel.org>,
	<GR-QLogic-Storage-Upstream@marvell.com>, <jhasan@marvell.com>
Subject: [PATCH 3/8] qedf: Fix for the session’s E_D_TOV value.
Date: Mon, 24 Aug 2020 23:43:49 -0700	[thread overview]
Message-ID: <20200825064354.16361-4-jhasan@marvell.com> (raw)
In-Reply-To: <20200825064354.16361-1-jhasan@marvell.com>

  -FW expects E_D_TOV field in connection offload
   parameters as “msec”.
  -Earlier incorrect value(100ms), was leading
   to abort from driver in the case when data
   frames for read take more than 100ms from target side,
   resulting in FW reporting E_D_TOV expiration.

Signed-off-by: Javed Hasan <jhasan@marvell.com>
---
 drivers/scsi/qedf/qedf_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c
index 5770692..ccf6a99 100644
--- a/drivers/scsi/qedf/qedf_main.c
+++ b/drivers/scsi/qedf/qedf_main.c
@@ -1311,7 +1311,7 @@ static int qedf_offload_connection(struct qedf_ctx *qedf,
 	ether_addr_copy(conn_info.dst_mac, qedf->ctlr.dest_addr);
 
 	conn_info.tx_max_fc_pay_len = fcport->rdata->maxframe_size;
-	conn_info.e_d_tov_timer_val = qedf->lport->e_d_tov / 20;
+	conn_info.e_d_tov_timer_val = qedf->lport->e_d_tov;
 	conn_info.rec_tov_timer_val = 3; /* I think this is what E3 was */
 	conn_info.rx_max_fc_pay_len = fcport->rdata->maxframe_size;
 
-- 
1.8.3.1


  parent reply	other threads:[~2020-08-25  6:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-25  6:43 [PATCH 0/8] qedf: Misc fixes for the driver Javed Hasan
2020-08-25  6:43 ` [PATCH 1/8] qedf: Changed the debug parameter permission from read to read & write Javed Hasan
2020-08-25  6:43 ` [PATCH 2/8] qedf: Correct the comment in qedf_initiate_els Javed Hasan
2020-08-25  6:43 ` Javed Hasan [this message]
2020-08-25  6:43 ` [PATCH 4/8] qedf: FDMI Enhancement Javed Hasan
2020-08-25  6:43 ` [PATCH 5/8] qedf: Return SUCCESS if stale rport in encounteredon eh_abort Javed Hasan
2020-08-25  6:43 ` [PATCH 6/8] qedf: Add schedule_hw_err_handler callback for fan failure Javed Hasan
2020-08-25  6:43 ` [PATCH 7/8] qedf: Retry qed->probe during recovery Javed Hasan
2020-08-25  6:43 ` [PATCH 8/8] qedf: Changes the %p to %px to print pointers Javed Hasan
2020-09-01  2:24 ` [PATCH 0/8] qedf: Misc fixes for the driver Martin K. Petersen
2020-09-07 12:14 Javed Hasan
2020-09-07 12:14 ` [PATCH 3/8] qedf: Fix for the session’s E_D_TOV value Javed Hasan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200825064354.16361-4-jhasan@marvell.com \
    --to=jhasan@marvell.com \
    --cc=GR-QLogic-Storage-Upstream@marvell.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.