From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32A61C433E1 for ; Tue, 25 Aug 2020 07:32:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0313620578 for ; Tue, 25 Aug 2020 07:32:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729490AbgHYHc1 (ORCPT ); Tue, 25 Aug 2020 03:32:27 -0400 Received: from honk.sigxcpu.org ([24.134.29.49]:45522 "EHLO honk.sigxcpu.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729194AbgHYHcY (ORCPT ); Tue, 25 Aug 2020 03:32:24 -0400 Received: from localhost (localhost [127.0.0.1]) by honk.sigxcpu.org (Postfix) with ESMTP id C94C3FB03; Tue, 25 Aug 2020 09:32:21 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at honk.sigxcpu.org Received: from honk.sigxcpu.org ([127.0.0.1]) by localhost (honk.sigxcpu.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jxse1rfQBwXr; Tue, 25 Aug 2020 09:32:19 +0200 (CEST) Received: by bogon.sigxcpu.org (Postfix, from userid 1000) id 2B0CD4593E; Tue, 25 Aug 2020 09:32:19 +0200 (CEST) Date: Tue, 25 Aug 2020 09:32:19 +0200 From: Guido =?iso-8859-1?Q?G=FCnther?= To: Swapnil Kashinath Jakhade Cc: Tomi Valkeinen , "airlied@linux.ie" , "daniel@ffwll.ch" , "Laurent.pinchart@ideasonboard.com" , "robh+dt@kernel.org" , "a.hajda@samsung.com" , "narmstrong@baylibre.com" , "jonas@kwiboo.se" , "jernej.skrabec@siol.net" , "dri-devel@lists.freedesktop.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Milind Parab , Yuti Suresh Amonkar , "praneeth@ti.com" , "nsekhar@ti.com" , "jsarha@ti.com" , "sandor.yu@nxp.com" Subject: Re: [PATCH v8 0/3] drm: Add support for Cadence MHDP DPI/DP bridge and J721E wrapper. Message-ID: <20200825073219.GA5528@bogon.m.sigxcpu.org> References: <1596713672-8146-1-git-send-email-sjakhade@cadence.com> <20200812083937.GA8816@bogon.m.sigxcpu.org> <3bcbbb0b-ee04-0f1e-6c54-97b01c552d82@ti.com> <20200812135637.GA107602@bogon.m.sigxcpu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Swapnil, On Mon, Aug 24, 2020 at 07:16:31AM +0000, Swapnil Kashinath Jakhade wrote: [..snip..] > Following are the differences between MHDP IPs from Cadence for Rockchip, TI and NxP: > > The Rockchip and NXP MHDP Core shares the same part (IP8501) which is DP v1.3 SST > Controller with HDCP 2.2/1.x. NXP's version additionally supports HDMI. > TI uses a different part (IP8546A), which is DP v1.4 with HDCP 2.2/1.x. > TI DP Controller adds support for additional features such as Multi Stream Support (MST), > Forward Error Correction (FEC) and Compression (DSC). > > Also, FW used for TI has significant differences than FW used for Rockchip or NXP. > NxP and TI firmware are developed and maintained separately by Cadence and are in > active support. > > From the Linux driver perspective, given the differences, it would make sense to have > TI driver maintained separately. Thanks for the clarification, that indeed helps a lot. So the rockchip and nxp drivers can be merged while the ti one should stay separate. Cheers, -- Guido > > Thanks, > Swapnil > > > > > > I'm worried that if there are IP differences, even if not great ones, > > > and if the FWs are different and developed separately, it'll be a > > > constant "fix X for SoC A, and accidentally break Y for SoC B and C", > > especially if too much code is shared. > > > > > > In the long run I'm all for a single driver (or large shared parts), > > > but I'm not sure if we should start with that approach. > > > > > > > > > > > > > > Tomi > > > > > > -- > > > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. > > > Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97AA2C433DF for ; Tue, 25 Aug 2020 07:32:26 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 722EE20578 for ; Tue, 25 Aug 2020 07:32:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 722EE20578 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sigxcpu.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BF4A089EA3; Tue, 25 Aug 2020 07:32:25 +0000 (UTC) Received: from honk.sigxcpu.org (honk.sigxcpu.org [24.134.29.49]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7A49689EA3 for ; Tue, 25 Aug 2020 07:32:24 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by honk.sigxcpu.org (Postfix) with ESMTP id C94C3FB03; Tue, 25 Aug 2020 09:32:21 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at honk.sigxcpu.org Received: from honk.sigxcpu.org ([127.0.0.1]) by localhost (honk.sigxcpu.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jxse1rfQBwXr; Tue, 25 Aug 2020 09:32:19 +0200 (CEST) Received: by bogon.sigxcpu.org (Postfix, from userid 1000) id 2B0CD4593E; Tue, 25 Aug 2020 09:32:19 +0200 (CEST) Date: Tue, 25 Aug 2020 09:32:19 +0200 From: Guido =?iso-8859-1?Q?G=FCnther?= To: Swapnil Kashinath Jakhade Subject: Re: [PATCH v8 0/3] drm: Add support for Cadence MHDP DPI/DP bridge and J721E wrapper. Message-ID: <20200825073219.GA5528@bogon.m.sigxcpu.org> References: <1596713672-8146-1-git-send-email-sjakhade@cadence.com> <20200812083937.GA8816@bogon.m.sigxcpu.org> <3bcbbb0b-ee04-0f1e-6c54-97b01c552d82@ti.com> <20200812135637.GA107602@bogon.m.sigxcpu.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , "jernej.skrabec@siol.net" , "praneeth@ti.com" , Yuti Suresh Amonkar , "narmstrong@baylibre.com" , "airlied@linux.ie" , Tomi Valkeinen , "jonas@kwiboo.se" , "nsekhar@ti.com" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "a.hajda@samsung.com" , "robh+dt@kernel.org" , "Laurent.pinchart@ideasonboard.com" , "sandor.yu@nxp.com" , "jsarha@ti.com" , Milind Parab Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Swapnil, On Mon, Aug 24, 2020 at 07:16:31AM +0000, Swapnil Kashinath Jakhade wrote: [..snip..] > Following are the differences between MHDP IPs from Cadence for Rockchip, TI and NxP: > > The Rockchip and NXP MHDP Core shares the same part (IP8501) which is DP v1.3 SST > Controller with HDCP 2.2/1.x. NXP's version additionally supports HDMI. > TI uses a different part (IP8546A), which is DP v1.4 with HDCP 2.2/1.x. > TI DP Controller adds support for additional features such as Multi Stream Support (MST), > Forward Error Correction (FEC) and Compression (DSC). > > Also, FW used for TI has significant differences than FW used for Rockchip or NXP. > NxP and TI firmware are developed and maintained separately by Cadence and are in > active support. > > From the Linux driver perspective, given the differences, it would make sense to have > TI driver maintained separately. Thanks for the clarification, that indeed helps a lot. So the rockchip and nxp drivers can be merged while the ti one should stay separate. Cheers, -- Guido > > Thanks, > Swapnil > > > > > > I'm worried that if there are IP differences, even if not great ones, > > > and if the FWs are different and developed separately, it'll be a > > > constant "fix X for SoC A, and accidentally break Y for SoC B and C", > > especially if too much code is shared. > > > > > > In the long run I'm all for a single driver (or large shared parts), > > > but I'm not sure if we should start with that approach. > > > > > > > > > > > > > > Tomi > > > > > > -- > > > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. > > > Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki > > > > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel