From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A07FBC433E1 for ; Tue, 25 Aug 2020 11:32:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 784632068E for ; Tue, 25 Aug 2020 11:32:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729710AbgHYLcB (ORCPT ); Tue, 25 Aug 2020 07:32:01 -0400 Received: from foss.arm.com ([217.140.110.172]:56696 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730037AbgHYLbe (ORCPT ); Tue, 25 Aug 2020 07:31:34 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9BE1830E; Tue, 25 Aug 2020 04:31:33 -0700 (PDT) Received: from localhost (unknown [10.1.199.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3CF913F66B; Tue, 25 Aug 2020 04:31:33 -0700 (PDT) Date: Tue, 25 Aug 2020 12:31:31 +0100 From: Ionela Voinescu To: Viresh Kumar Cc: rjw@rjwysocki.net, dietmar.eggemann@arm.com, catalin.marinas@arm.com, sudeep.holla@arm.com, will@kernel.org, valentin.schneider@arm.com, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/5] arch_topology: validate input frequencies to arch_set_freq_scale() Message-ID: <20200825113131.GB12506@arm.com> References: <20200824210252.27486-1-ionela.voinescu@arm.com> <20200824210252.27486-2-ionela.voinescu@arm.com> <20200825055618.ybght3enlpuwo3va@vireshk-i7> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200825055618.ybght3enlpuwo3va@vireshk-i7> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 25 Aug 2020 at 11:26:18 (+0530), Viresh Kumar wrote: > On 24-08-20, 22:02, Ionela Voinescu wrote: > > The current frequency passed to arch_set_freq_scale() could end up > > being 0, signaling an error in setting a new frequency. Also, if the > > maximum frequency in 0, this will result in a division by 0 error. > > > > Therefore, validate these input values before using them for the > > setting of the frequency scale factor. > > > > Signed-off-by: Ionela Voinescu > > Cc: Sudeep Holla > > Cc: Rafael J. Wysocki > > --- > > drivers/base/arch_topology.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c > > index 75f72d684294..1aca82fcceb8 100644 > > --- a/drivers/base/arch_topology.c > > +++ b/drivers/base/arch_topology.c > > @@ -33,6 +33,9 @@ void arch_set_freq_scale(struct cpumask *cpus, unsigned long cur_freq, > > unsigned long scale; > > int i; > > > > + if (!cur_freq || !max_freq) > > We should probably use unlikely() here. > > Rafael: Shouldn't this have a WARN_ON_ONCE() as well ? > I'll add the unlikely() as it's definitely useful. I'm somewhat on the fence about WARN_ON_ONCE() here. Wouldn't it work better in cpufreq_driver_fast_switch()? It would cover scenarios where the default arch_set_freq_scale() is used and flag potential hardware issues with setting frequency that are currently just ignored both here and in sugov_fast_switch(). Thanks, Ionela. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01DE2C433DF for ; Tue, 25 Aug 2020 11:32:59 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BFAA52068E for ; Tue, 25 Aug 2020 11:32:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="y1CN1/eJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BFAA52068E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=grK2CY3bk5y9nIb/EmzHxJrogVz2IlkMJagzgLv/0as=; b=y1CN1/eJhz5leH9edgMiimwMw QW6aZejEhr+hspLB9OKcZDTLyQOO3ilq4c5cLx4lYV2Q3CGkbpluokIfGRJvgZUDDMuDfwJ+83Naq 9TYuldiTs2+xNTb1WTGBE3PNRgQ+C6LICvZsREVOcdMfGC2PKYntdNZ6EZzPA1vRKBgxow4SD93jP TxqcBLbXILppZ+ojV/+mhdMDW/737Qp9qthn8x6ZMbqwTghhPaVf2S3kcz5D8337Jsug6A7E+JCFe Bt3ZfRV1wSXN2aAHQRwo2rswD7Vf15tn6C56wdwvEUREwr/9VfFP3ti238lI+nezkY0vm6XPi6DoT 7GEzieSLw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kAXAv-0004ly-KG; Tue, 25 Aug 2020 11:31:37 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kAXAs-0004lI-Vh for linux-arm-kernel@lists.infradead.org; Tue, 25 Aug 2020 11:31:35 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9BE1830E; Tue, 25 Aug 2020 04:31:33 -0700 (PDT) Received: from localhost (unknown [10.1.199.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3CF913F66B; Tue, 25 Aug 2020 04:31:33 -0700 (PDT) Date: Tue, 25 Aug 2020 12:31:31 +0100 From: Ionela Voinescu To: Viresh Kumar Subject: Re: [PATCH v3 1/5] arch_topology: validate input frequencies to arch_set_freq_scale() Message-ID: <20200825113131.GB12506@arm.com> References: <20200824210252.27486-1-ionela.voinescu@arm.com> <20200824210252.27486-2-ionela.voinescu@arm.com> <20200825055618.ybght3enlpuwo3va@vireshk-i7> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200825055618.ybght3enlpuwo3va@vireshk-i7> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200825_073135_092289_6BC34907 X-CRM114-Status: GOOD ( 20.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pm@vger.kernel.org, catalin.marinas@arm.com, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, dietmar.eggemann@arm.com, sudeep.holla@arm.com, will@kernel.org, valentin.schneider@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tuesday 25 Aug 2020 at 11:26:18 (+0530), Viresh Kumar wrote: > On 24-08-20, 22:02, Ionela Voinescu wrote: > > The current frequency passed to arch_set_freq_scale() could end up > > being 0, signaling an error in setting a new frequency. Also, if the > > maximum frequency in 0, this will result in a division by 0 error. > > > > Therefore, validate these input values before using them for the > > setting of the frequency scale factor. > > > > Signed-off-by: Ionela Voinescu > > Cc: Sudeep Holla > > Cc: Rafael J. Wysocki > > --- > > drivers/base/arch_topology.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c > > index 75f72d684294..1aca82fcceb8 100644 > > --- a/drivers/base/arch_topology.c > > +++ b/drivers/base/arch_topology.c > > @@ -33,6 +33,9 @@ void arch_set_freq_scale(struct cpumask *cpus, unsigned long cur_freq, > > unsigned long scale; > > int i; > > > > + if (!cur_freq || !max_freq) > > We should probably use unlikely() here. > > Rafael: Shouldn't this have a WARN_ON_ONCE() as well ? > I'll add the unlikely() as it's definitely useful. I'm somewhat on the fence about WARN_ON_ONCE() here. Wouldn't it work better in cpufreq_driver_fast_switch()? It would cover scenarios where the default arch_set_freq_scale() is used and flag potential hardware issues with setting frequency that are currently just ignored both here and in sugov_fast_switch(). Thanks, Ionela. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel