From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8AFCC433DF for ; Wed, 26 Aug 2020 03:44:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BEF6E20715 for ; Wed, 26 Aug 2020 03:44:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OvXEmpgA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726713AbgHZDox (ORCPT ); Tue, 25 Aug 2020 23:44:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726700AbgHZDov (ORCPT ); Tue, 25 Aug 2020 23:44:51 -0400 Received: from mail-oi1-x242.google.com (mail-oi1-x242.google.com [IPv6:2607:f8b0:4864:20::242]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68A4CC061574 for ; Tue, 25 Aug 2020 20:44:50 -0700 (PDT) Received: by mail-oi1-x242.google.com with SMTP id j18so354315oig.5 for ; Tue, 25 Aug 2020 20:44:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=vj9jHV3Nh5KlI/aHeO4Vw72Jl2llbstQbIn89ZgeTF8=; b=OvXEmpgA9rzoCBGMIr3Z/Y0sZa6QDHXNlqji2Lq8CTzC+GG8HIK6vYiQ9BLOXEHAhe cB8T1ocWUcH5iXddnTVdrYkF1mN8woDXJRGqeP8Y/HBY4YGibDA304UOUV+CZTl2wiTD WJ8qspN4pZD0UID2fs7LcNRuvgOn7T1NCaRE1p5wlpDAxmyYLOqZfjUzjqi6QBcDwuho cvoLzqFH+LSf43lQ9olZg/t54BfBCFz+zwmCAuCiuiDhcLjRTc5Skx21zLTWrU7RrJm6 +dnjrHs79Gv1s1mFCV4xEr7VO7N7S0VOIlK/XIjfiUHkievJZQ8VkhAMjVaJDsqsGOzr r9Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=vj9jHV3Nh5KlI/aHeO4Vw72Jl2llbstQbIn89ZgeTF8=; b=qwqqO/lreU1MVzOl+SO/7a28Zr0RJ2Ase12j/2HAH0As3MVZwsle23wLolJGz8bjS9 0cRDe8zNv6eW/rDAM+SnIGExUYIQJ1GlhcWaagyYmoft3ltJG6BShBl/xn/UqE/rO9pt 5dl/ruXNUg5AjmvdoDtGBxW+KCuXSi8EBonUI2wLQa61+kqnkB1RZDQQtZEAkqzkZHrm ipAEMwe1EvwJuiTz0C3Exmop+VpSZyD6mEvku0hsnB9H6P4HWjrDC267FvOgvHcH8EmP 615y6cYwocBhqC8O4VML/nTtMgmBVLJt48W1mXTJHQWRU651SLLhIkOKIXG9knuFBnpY Q2cw== X-Gm-Message-State: AOAM531a53RdaywLP9QE9AB1KPqdRJTwlDjBnYgVeTlWsGK2RgHBELM8 51CNLKirYKWjZ09AzNTBHEUZpg== X-Google-Smtp-Source: ABdhPJy3j8LJQFL8ybKeyBKKFeKk3XfOnAsGrQXI2jYprxc20qp9LlCi/15hLZePkPyAMba6XtIBRQ== X-Received: by 2002:aca:a9d0:: with SMTP id s199mr2680456oie.154.1598413489568; Tue, 25 Aug 2020 20:44:49 -0700 (PDT) Received: from yoga ([2605:6000:e5cb:c100:8898:14ff:fe6d:34e]) by smtp.gmail.com with ESMTPSA id y3sm83744ooc.48.2020.08.25.20.44.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Aug 2020 20:44:48 -0700 (PDT) Date: Tue, 25 Aug 2020 22:44:46 -0500 From: Bjorn Andersson To: Stephen Boyd Cc: Kishon Vijay Abraham I , Vinod Koul , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Jeykumar Sankaran , Chandan Uddaraju , Vara Reddy , Tanmay Shah , Manu Gautam , Sandeep Maheswaram , Douglas Anderson , Sean Paul , Jonathan Marek , Dmitry Baryshkov , Rob Clark Subject: Re: [PATCH v1 3/9] phy: qcom-qmp: Remove 'initialized' in favor of 'init_count' Message-ID: <20200826034446.GE3715@yoga> References: <20200826024711.220080-1-swboyd@chromium.org> <20200826024711.220080-4-swboyd@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200826024711.220080-4-swboyd@chromium.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue 25 Aug 21:47 CDT 2020, Stephen Boyd wrote: > We already track if any phy inside the qmp wrapper has been initialized > by means of the struct qcom_qmp::init_count member. Let's drop the > duplicate 'initialized' member to simplify the code a bit. > > Cc: Jeykumar Sankaran > Cc: Chandan Uddaraju > Cc: Vara Reddy > Cc: Tanmay Shah > Cc: Bjorn Andersson Reviewed-by: Bjorn Andersson Regards, Bjorn > Cc: Manu Gautam > Cc: Sandeep Maheswaram > Cc: Douglas Anderson > Cc: Sean Paul > Cc: Jonathan Marek > Cc: Dmitry Baryshkov > Cc: Rob Clark > Signed-off-by: Stephen Boyd > --- > drivers/phy/qualcomm/phy-qcom-qmp.c | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-) > > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c > index 7ee9e966dc6d..4a23ba9361b3 100644 > --- a/drivers/phy/qualcomm/phy-qcom-qmp.c > +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c > @@ -1844,7 +1844,6 @@ struct qmp_phy { > * @phys: array of per-lane phy descriptors > * @phy_mutex: mutex lock for PHY common block initialization > * @init_count: phy common block initialization count > - * @phy_initialized: indicate if PHY has been initialized > * @ufs_reset: optional UFS PHY reset handle > */ > struct qcom_qmp { > @@ -1861,7 +1860,6 @@ struct qcom_qmp { > > struct mutex phy_mutex; > int init_count; > - bool phy_initialized; > > struct reset_control *ufs_reset; > }; > @@ -2748,7 +2746,6 @@ static int qcom_qmp_phy_enable(struct phy *phy) > dev_err(qmp->dev, "phy initialization timed-out\n"); > goto err_pcs_ready; > } > - qmp->phy_initialized = true; > return 0; > > err_pcs_ready: > @@ -2792,8 +2789,6 @@ static int qcom_qmp_phy_disable(struct phy *phy) > > qcom_qmp_phy_com_exit(qmp); > > - qmp->phy_initialized = false; > - > return 0; > } > > @@ -2868,7 +2863,7 @@ static int __maybe_unused qcom_qmp_phy_runtime_suspend(struct device *dev) > if (cfg->type != PHY_TYPE_USB3) > return 0; > > - if (!qmp->phy_initialized) { > + if (!qmp->init_count) { > dev_vdbg(dev, "PHY not initialized, bailing out\n"); > return 0; > } > @@ -2894,7 +2889,7 @@ static int __maybe_unused qcom_qmp_phy_runtime_resume(struct device *dev) > if (cfg->type != PHY_TYPE_USB3) > return 0; > > - if (!qmp->phy_initialized) { > + if (!qmp->init_count) { > dev_vdbg(dev, "PHY not initialized, bailing out\n"); > return 0; > } > -- > Sent by a computer, using git, on the internet >