From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1kB3j7-0001eB-T3 for mharc-grub-devel@gnu.org; Wed, 26 Aug 2020 18:17:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45280) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kB3j5-0001c2-Uz for grub-devel@gnu.org; Wed, 26 Aug 2020 18:17:04 -0400 Received: from mail-ot1-x341.google.com ([2607:f8b0:4864:20::341]:44542) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kB3j4-0000zO-59 for grub-devel@gnu.org; Wed, 26 Aug 2020 18:17:03 -0400 Received: by mail-ot1-x341.google.com with SMTP id n23so2819965otq.11 for ; Wed, 26 Aug 2020 15:17:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficientek-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references:reply-to :mime-version:content-transfer-encoding; bh=+nlvXzC/uV3qB9fB8IpxrD/2CWVwtD6A5m6XKMXzWCs=; b=CSbAZCWi4bfFqA8j+bomReA3L7qUxlwK3h73QZhfR7WVqE8JqXqXb2v4gLK3dTELkg 7jyrsiXqpgWflOP3zi8sxzHFJir69Z8P53auOwDPblX7LNfoDmrZNMNON3TYxo1YootS 4AA98iJOZEu5FD+5YOSv9ufCS98SkVSWZUlXVGLKinmGCT91Gcc/bP1FTm5E0D/vbGxj E8kyzqbgqcM+q3XFcrRvWZH2oU3Gu4oxs4hY7gp0wUuDsP6dWI2iUxqlebObbGZV0cpC 4NmrQY2a3fmDK8aaC/Vb4x37ZGahZVTW5PQeeuhSK6lSS6KJ+pv986UkehHKvFXzXRgQ WBbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:reply-to:mime-version:content-transfer-encoding; bh=+nlvXzC/uV3qB9fB8IpxrD/2CWVwtD6A5m6XKMXzWCs=; b=NNcu9/c0/vppaCtFpaa0pWovQ5yqzA0TBqIaI+oPl9cpGo2NR2WoQQKsDKmcI+1qbT gxYhT2SPiScTU5fdmEu0kElJzX6Q8ghWoYXStDH49ERjcP5v/VAZVZncOkRmiZjzens3 qePsufqbiwY4MonyUm/RTJ4/pmI013luw7tXiFV/uOxb/doGraEokDN+tCusb3xAoblb rx1NwtQgLhFtgUynmMT9bt7hmunn7pxNxHvtB+Yfu0iA9pRbOzfvJ8R/mHkK4bI0vN1e u6xUpPFoOxnQetPArpNWYbw3WdAWs4UMZ+4pKDp/aDwBKCdpHrG1cc2DyRRLOkXjAq7r SDcg== X-Gm-Message-State: AOAM5330Yw8IqGXk69R7PQ32EnKtmNm1Xke1/owe0DsnXr4BNYp8JOrG HSLsm5bIUcqToykfzkR9a9HCEg== X-Google-Smtp-Source: ABdhPJxO9aEwK4K8kYHhJ1pM0XNBF+8G/IKIqb0hMUrh/5F+75wPa0f5t0PLguM37JFD3AwnhPFy/w== X-Received: by 2002:a9d:48d:: with SMTP id 13mr12187264otm.9.1598480220147; Wed, 26 Aug 2020 15:17:00 -0700 (PDT) Received: from crass-HP-ZBook-15-G2 ([2605:a601:aaec:9b00:fc1f:b488:83ac:101a]) by smtp.gmail.com with ESMTPSA id l5sm67053oov.3.2020.08.26.15.16.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 15:17:00 -0700 (PDT) Date: Wed, 26 Aug 2020 17:16:57 -0500 From: Glenn Washburn To: Patrick Steinhardt Cc: grub-devel@gnu.org, Denis GNUtoo Carikli , Daniel Kiper Subject: Re: [PATCH v2 0/9] Cryptodisk fixes for v2.06 Message-ID: <20200826171657.2741b3ac@crass-HP-ZBook-15-G2> In-Reply-To: References: Reply-To: development@efficientek.com X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::341; envelope-from=development@efficientek.com; helo=mail-ot1-x341.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Aug 2020 22:17:04 -0000 On Wed, 26 Aug 2020 10:13:18 +0200 Patrick Steinhardt wrote: > I didn't yet get your test series to work, Glenn. I'll try again on > another day as I'm not on top of things today. Meanwhile, could you > please give it a go with this updated patch series? I've tested with this patch series and all tests pass. Which part isn't working for the tests? The patchset (on the mailinglist) has expected failures for all LUKS2 tests because my LUKS2 keyfile patch is needed. So the tests should be able to verify that LUKS1 tests are passing before and after this patchset. Here's the branch I created that has your patch series, the v5 crypto keyfile and detached header patch series, my cryptomount test patches, my luks2 keyfile patch, and patches turning on tests now expecting to pass in that order applied to master. https://github.com/crass/grub/tree/cryptodisk-fixes-for-v2.06.v2+cryptodisk-v5+cryptodisk-tests Here is a command sequence that should show the cryptomount test as passing. You can look at some more details of the testing in the test log file grub_cmd_cryptomount.log. Once you see the tests passing, you can remove some of the commits in the patch series and verify that the test fails and that the appropriate subtest fails by checking the log file. ------------------------------------------- git clone https://github.com/crass/grub.git cd grub git checkout cryptodisk-fixes-for-v2.06.v2+cryptodisk-v5+cryptodisk-tests ./bootstrap && ./configure && make -j8 sudo env TESTS=grub_cmd_cryptomount make -e check VERBOSE=yes SUBDIRS= ------------------------------------------- Glenn