From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D4D2C433E1 for ; Thu, 27 Aug 2020 01:59:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5E93E2073A for ; Thu, 27 Aug 2020 01:59:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="TNH6cFFK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726967AbgH0B7r (ORCPT ); Wed, 26 Aug 2020 21:59:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726802AbgH0B7r (ORCPT ); Wed, 26 Aug 2020 21:59:47 -0400 Received: from mail-oo1-xc43.google.com (mail-oo1-xc43.google.com [IPv6:2607:f8b0:4864:20::c43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB0D7C061369 for ; Wed, 26 Aug 2020 18:59:46 -0700 (PDT) Received: by mail-oo1-xc43.google.com with SMTP id g1so887911oop.11 for ; Wed, 26 Aug 2020 18:59:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=/oidMW/W20jF+NxvzsE3dEflfMY2KxJGTLWf/bdubB0=; b=TNH6cFFKpY9pf8bAPVka2j/qvuFuZXl2oamyYo9KGpvLnkLd45PTDkWk7TDAsR8WmD wtmSVzjkxcu6nAodWjSOp5f4imTr7yio+1pWt+I4H67LtWRMcKZCrcxlMgMuCXLglTiu jrmrM41U1j6Uzck5OkbUSJlCvHBWL5pjqYbNQSPcEbqWF8DCpJDa3nSzJFbM3ChUbkXV NlDOkl/1QvcyGsfV8r9aAIMn/qPzeP73cwIbdApi7+SFAWoUFPlt87UfAbsGjhi5d/aQ MByJ66EvunTGaOFQXs0QNh4zOOGNp9TNmmHEKknOwQNKpctUr89yiS+piTm0tDBhRsKx e3PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/oidMW/W20jF+NxvzsE3dEflfMY2KxJGTLWf/bdubB0=; b=krxnnacHQgzwq0OQhqsxbtM2hfHQxb6vgqKxj86q2+SYqajTDZ1iR181iUQte8lqms YYuHmDyD7PSzk5WM9i5hN3/S7LerFSisrmEkQ2DUQrJVltiZjIZGyXN3rqthqSM6kIeg zzBtCHojZUqw1ri41pyyZBkh/GUGSo9xtN/zSN1zWPlgNVTEIEEgGeN6oZNZOkb0E0b5 nnwRH+numwPlJfqVX865xygcUsbMcHmrD3fByhjlv07kXddxC4BTs7cwhGEWJqYvkDw5 OD7dudyWsnc+WiCCdu0roz1kYjgJjMWOCmWUi9U27CJyLfj73+v0YtUzI0mg+Xx+VSi1 EgJg== X-Gm-Message-State: AOAM530Y6GiFFRAv08fMb5MIu9lbNbrXMVymOo3bwRF2Bx6gkDUxVHix 8Y2J8zd/62ES34pkGioZzIYM2w== X-Google-Smtp-Source: ABdhPJz1VZJHwh3gmPiQw0+0U/BOgIYqvt63leeGTunSeMa3alZx4TM5V6vrDU2f2Btu5AjcJXTfnw== X-Received: by 2002:a4a:aa0e:: with SMTP id x14mr12438488oom.27.1598493585763; Wed, 26 Aug 2020 18:59:45 -0700 (PDT) Received: from yoga ([2605:6000:e5cb:c100:8898:14ff:fe6d:34e]) by smtp.gmail.com with ESMTPSA id a16sm179248oop.17.2020.08.26.18.59.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Aug 2020 18:59:45 -0700 (PDT) Date: Wed, 26 Aug 2020 20:59:39 -0500 From: Bjorn Andersson To: Stephen Boyd Cc: Kishon Vijay Abraham I , Vinod Koul , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Jeykumar Sankaran , Chandan Uddaraju , Vara Reddy , Tanmay Shah , Manu Gautam , Sandeep Maheswaram , Douglas Anderson , Sean Paul , Jonathan Marek , Dmitry Baryshkov , Rob Clark Subject: Re: [PATCH v1 5/9] phy: qcom-qmp: Get dp_com I/O resource by index Message-ID: <20200827015939.GI3715@yoga> References: <20200826024711.220080-1-swboyd@chromium.org> <20200826024711.220080-6-swboyd@chromium.org> <20200826043616.GF3715@yoga> <159847755731.334488.13614233203912102191@swboyd.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <159847755731.334488.13614233203912102191@swboyd.mtv.corp.google.com> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed 26 Aug 16:32 CDT 2020, Stephen Boyd wrote: > Quoting Bjorn Andersson (2020-08-25 21:36:16) > > On Tue 25 Aug 21:47 CDT 2020, Stephen Boyd wrote: > > > > > The dp_com resource is always at index 1 according to the dts files in > > > the kernel. Get this resource by index so that we don't need to make > > > future additions to the DT binding use 'reg-names'. > > > > > > > Afaict the DT binding for the USB/DP phy defines that there should be a > > reg name of "dp_com" and the current dts files all specifies this. Am I > > missing something? > > Yes the binding enforces this but this patch is removing that > enforcement and instead mandating that dp_com is always at index 1 (i.e. > the second one) so that we can add the DP serdes region directly after > and avoid adding yet another reg-names property. I changed the binding > for this usb3-dp phy compatible to make reg-names optional as well. I > don't see any gain from using reg-names. > Thanks for the explanation, I don't have any objections to this. > > > > PS. Why isn't this a devm_platform_ioremap_resource{,_byname}()? > > Sure. I'll roll that into this patch. Thanks, Bjorn