From: Wei Liu <wl@xen.org>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org,
Ian Jackson <ian.jackson@eu.citrix.com>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v3 10/38] tools: tweak tools/libs/libs.mk for being able to support libxenctrl
Date: Thu, 27 Aug 2020 10:52:28 +0000 [thread overview]
Message-ID: <20200827105228.rybce2jytu2x7oof@liuwe-devbox-debian-v2> (raw)
In-Reply-To: <20200823093519.18386-11-jgross@suse.com>
On Sun, Aug 23, 2020 at 11:34:51AM +0200, Juergen Gross wrote:
> tools/libs/libs.mk needs to be modified for being able to support
> building libxenctrl, as the pkg-config file of that library is not
> following the same conventions as those of the other libraries.
>
> So add support for specifying PKG_CONFIG before including libs.mk.
>
> In order to make life easier for unstable libraries like libxenctrl
> set MAJOR and MINOR automatically to the Xen-version and 0 when not
> specified. This removes the need to bump the versions of unstable
> libraries when switching to a new Xen version.
>
> As all libraries built via libs.mk require a map file generate a dummy
> one in case there is none existing. This again will help avoiding the
> need to bump the libarary version in the map file of an unstable
> library in case it is exporting all symbols.
>
This is good. Much appreciated.
> The clean target is missing the removal of _paths.h.
>
> Finally drop the foreach loop when setting PKG_CONFIG_LOCAL, as there
> is always only one element in PKG_CONFIG.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
Acked-by: Wei Liu <wl@xen.org>
next prev parent reply other threads:[~2020-08-27 10:52 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-23 9:34 [PATCH v3 00/38] tools: move most libraries into tools/libs Juergen Gross
2020-08-23 9:34 ` [PATCH v3 01/38] stubdom: add stubdom/mini-os.mk for Xen paths used by Mini-OS Juergen Gross
2020-08-23 9:34 ` [PATCH v3 02/38] tools: switch XEN_LIBXEN* make variables to lower case (XEN_libxen*) Juergen Gross
2020-08-27 10:22 ` Wei Liu
2020-08-23 9:34 ` [PATCH v3 03/38] tools: add a copy of library headers in tools/include Juergen Gross
2020-08-27 10:25 ` Wei Liu
2020-08-23 9:34 ` [PATCH v3 04/38] tools: don't call make recursively from libs.mk Juergen Gross
2020-08-27 10:28 ` Wei Liu
2020-08-23 9:34 ` [PATCH v3 05/38] tools: define ROUNDUP() in tools/include/xen-tools/libs.h Juergen Gross
2020-08-27 10:22 ` Wei Liu
2020-08-23 9:34 ` [PATCH v3 06/38] tools: generate most contents of library make variables Juergen Gross
2020-08-27 10:28 ` Wei Liu
2020-08-23 9:34 ` [PATCH v3 07/38] stubdom: add correct dependencies for Xen libraries Juergen Gross
2020-08-23 9:47 ` Samuel Thibault
2020-08-23 9:51 ` Jürgen Groß
2020-08-23 9:34 ` [PATCH v3 08/38] stubdom: simplify building xen libraries for stubdoms Juergen Gross
2020-08-23 9:50 ` Samuel Thibault
2020-08-23 9:34 ` [PATCH v3 09/38] tools: drop explicit path specifications for qemu build Juergen Gross
2020-08-27 10:30 ` Wei Liu
2020-08-23 9:34 ` [PATCH v3 10/38] tools: tweak tools/libs/libs.mk for being able to support libxenctrl Juergen Gross
2020-08-27 10:52 ` Wei Liu [this message]
2020-08-23 9:34 ` [PATCH v3 11/38] tools/python: drop libxenguest from setup.py Juergen Gross
2020-08-25 11:07 ` Marek Marczykowski-Górecki
2020-08-23 9:34 ` [PATCH v3 12/38] tools: fix pkg-config file for libxenguest Juergen Gross
2020-08-27 10:34 ` Wei Liu
2020-08-23 9:34 ` [PATCH v3 13/38] tools: don't assume libxenguest and libxenctrl to be in same directory Juergen Gross
2020-08-27 10:36 ` Wei Liu
2020-08-23 9:34 ` [PATCH v3 14/38] tools/misc: don't use libxenctrl internals from xen-hptool Juergen Gross
2020-08-27 10:37 ` Wei Liu
2020-08-23 9:34 ` [PATCH v3 15/38] tools/misc: don't include xg_save_restore.h from xen-mfndump.c Juergen Gross
2020-08-27 10:37 ` Wei Liu
2020-08-23 9:34 ` [PATCH v3 16/38] tools/misc: replace PAGE_SIZE with XC_PAGE_SIZE in xen-mfndump.c Juergen Gross
2020-08-27 10:37 ` Wei Liu
2020-08-23 9:34 ` [PATCH v3 17/38] tools/misc: drop all libxc internals from xen-mfndump.c Juergen Gross
2020-08-27 10:38 ` Wei Liu
2020-08-23 9:34 ` [PATCH v3 18/38] tools/libxc: remove unused headers xc_efi.h and xc_elf.h Juergen Gross
2020-08-27 10:39 ` Wei Liu
2020-08-23 9:35 ` [PATCH v3 19/38] tools/libxc: move xc_[un]map_domain_meminfo() into new source xg_domain.c Juergen Gross
2020-08-27 10:39 ` Wei Liu
2020-08-23 9:35 ` [PATCH v3 20/38] tools/libxc: rename all libxenguest sources to xg_* Juergen Gross
2020-08-27 10:56 ` Wei Liu
2020-08-23 9:35 ` [PATCH v3 21/38] tools/libxc: rename libxenguest internal headers Juergen Gross
2020-08-27 10:56 ` Wei Liu
2020-08-23 9:35 ` [PATCH v3 22/38] tools/misc: rename xc_dom.h do xenctrl_dom.h Juergen Gross
2020-08-25 11:10 ` Marek Marczykowski-Górecki
2020-08-27 10:57 ` Wei Liu
2020-08-23 9:35 ` [PATCH v3 23/38] tools/libxc: untangle libxenctrl from libxenguest Juergen Gross
2020-08-27 11:23 ` Wei Liu
2020-08-23 9:35 ` [PATCH v3 24/38] tools/xcutils: use official headers in readnotes Juergen Gross
2020-08-27 11:27 ` Wei Liu
2020-08-23 9:35 ` [PATCH v3 25/38] tools/xenpaging: remove libxc internals Juergen Gross
2020-08-27 11:27 ` Wei Liu
2020-08-23 9:35 ` [PATCH v3 26/38] tools: move libxenctrl below tools/libs Juergen Gross
2020-08-25 11:16 ` Marek Marczykowski-Górecki
2020-08-25 11:26 ` Jürgen Groß
2020-08-27 11:33 ` Wei Liu
2020-08-23 9:35 ` [PATCH v3 27/38] tools/libxc: move libxenguest to tools/libs/guest Juergen Gross
2020-08-23 9:53 ` Samuel Thibault
2020-08-27 11:33 ` Wei Liu
2020-08-23 9:35 ` [PATCH v3 28/38] tools: split libxenstore into new tools/libs/store directory Juergen Gross
2020-08-27 11:34 ` Wei Liu
2020-08-23 9:35 ` [PATCH v3 29/38] tools: split libxenvchan into new tools/libs/vchan directory Juergen Gross
2020-08-27 11:35 ` Wei Liu
2020-08-23 9:35 ` [PATCH v3 30/38] tools: split libxenstat into new tools/libs/stat directory Juergen Gross
2020-08-27 11:36 ` Wei Liu
2020-08-23 9:35 ` [PATCH v3 31/38] tools/libxl: fix dependencies of libxl tests Juergen Gross
2020-08-27 11:36 ` Wei Liu
2020-08-23 9:35 ` [PATCH v3 32/38] tools/libxl: don't include libxl_osdeps.h from libxlutil sources Juergen Gross
2020-08-27 11:47 ` Wei Liu
2020-08-23 9:35 ` [PATCH v3 33/38] tools/libxl: add missing items to clean target Juergen Gross
2020-08-27 11:47 ` Wei Liu
2020-08-23 9:35 ` [PATCH v3 34/38] tools/libxl: move xl parsing checks to tools/xl Juergen Gross
2020-08-27 11:48 ` Wei Liu
2020-08-23 9:35 ` [PATCH v3 35/38] tools/xl: don't assume libxl and libxlutil are in one directory Juergen Gross
2020-08-27 11:49 ` Wei Liu
2020-08-23 9:35 ` [PATCH v3 36/38] tools/libxl: move libxenlight to tools/libs/light Juergen Gross
2020-08-27 11:51 ` Wei Liu
2020-08-23 9:35 ` [PATCH v3 37/38] tools: add support for library names other than libxen* Juergen Gross
2020-08-27 11:55 ` Wei Liu
2020-08-27 12:34 ` Jürgen Groß
2020-08-23 9:35 ` [PATCH v3 38/38] tools: move libxlutil to tools/libs/util Juergen Gross
2020-08-25 10:54 ` [PATCH v3 00/38] tools: move most libraries into tools/libs Christian Lindig
2020-08-27 11:07 ` Wei Liu
2020-08-27 11:24 ` Jürgen Groß
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200827105228.rybce2jytu2x7oof@liuwe-devbox-debian-v2 \
--to=wl@xen.org \
--cc=ian.jackson@eu.citrix.com \
--cc=jgross@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.