From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 156DAC433DF for ; Thu, 27 Aug 2020 14:56:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E96132054F for ; Thu, 27 Aug 2020 14:56:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727866AbgH0O4z (ORCPT ); Thu, 27 Aug 2020 10:56:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:60220 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728252AbgH0O4s (ORCPT ); Thu, 27 Aug 2020 10:56:48 -0400 Received: from gaia (unknown [46.69.195.127]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 178032054F; Thu, 27 Aug 2020 14:56:44 +0000 (UTC) Date: Thu, 27 Aug 2020 15:56:42 +0100 From: Catalin Marinas To: Andrey Konovalov Cc: Vincenzo Frascino , Dmitry Vyukov , kasan-dev , Andrey Ryabinin , Alexander Potapenko , Marco Elver , Evgenii Stepanov , Elena Petrova , Branislav Rankov , Kevin Brodsky , Will Deacon , Andrew Morton , Linux ARM , Linux Memory Management List , LKML Subject: Re: [PATCH 21/35] arm64: mte: Add in-kernel tag fault handler Message-ID: <20200827145642.GO29264@gaia> References: <20200827095429.GC29264@gaia> <20200827131045.GM29264@gaia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 27, 2020 at 03:34:42PM +0200, Andrey Konovalov wrote: > On Thu, Aug 27, 2020 at 3:10 PM Catalin Marinas wrote: > > On Thu, Aug 27, 2020 at 02:31:23PM +0200, Andrey Konovalov wrote: > > > On Thu, Aug 27, 2020 at 11:54 AM Catalin Marinas > > > wrote: > > > > On Fri, Aug 14, 2020 at 07:27:03PM +0200, Andrey Konovalov wrote: > > > > > +static int do_tag_recovery(unsigned long addr, unsigned int esr, > > > > > + struct pt_regs *regs) > > > > > +{ > > > > > + report_tag_fault(addr, esr, regs); > > > > > + > > > > > + /* Skip over the faulting instruction and continue: */ > > > > > + arm64_skip_faulting_instruction(regs, AARCH64_INSN_SIZE); > > > > > > > > Ooooh, do we expect the kernel to still behave correctly after this? I > > > > thought the recovery means disabling tag checking altogether and > > > > restarting the instruction rather than skipping over it. [...] > > > Can we disable MTE, reexecute the instruction, and then reenable MTE, > > > or something like that? > > > > If you want to preserve the MTE enabled, you could single-step the > > instruction or execute it out of line, though it's a bit more convoluted > > (we have a similar mechanism for kprobes/uprobes). > > > > Another option would be to attempt to set the matching tag in memory, > > under the assumption that it is writable (if it's not, maybe it's fine > > to panic). Not sure how this interacts with the slub allocator since, > > presumably, the logical tag in the pointer is wrong rather than the > > allocation one. > > > > Yet another option would be to change the tag in the register and > > re-execute but this may confuse the compiler. > > Which one of these would be simpler to implement? Either 2 or 3 would be simpler (re-tag the memory location or the pointer) with the caveats I mentioned. Also, does the slab allocator need to touch the memory on free with a tagged pointer? Otherwise slab may hit an MTE fault itself. > Perhaps we could somehow only skip faulting instructions that happen > in the KASAN test module?.. Decoding stack trace would be an option, > but that's a bit weird. If you want to restrict this to the KASAN tests, just add some MTE-specific accessors with a fixup entry similar to get_user/put_user. __do_kernel_fault() (if actually called) will invoke the fixup code which skips the access and returns an error. This way KASAN tests can actually verify that tag checking works, I'd find this a lot more useful. -- Catalin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D55B5C433E1 for ; Thu, 27 Aug 2020 14:58:03 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A7BEC2054F for ; Thu, 27 Aug 2020 14:58:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="xrF9MBNO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A7BEC2054F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+lA6finWFBZ70E7NmoxAn8dCe7kwr0WyPdd33cV8bmY=; b=xrF9MBNOey3XOiMhvH++T1BUk tL5NLOZEr4E+jgH6pJ2ygw5TdBhNNIbd8pajHd2wAEfN+GVWQCK7KT97OsZiYTlAiyl5NNvGouEf7 kZP2Ixfvbqex9LDDWxMoqJ60a9ZrQry1gJ+cu5uuO/tdpGl/1QJS59YzyvNuWurvascRFxjNL4Xge 5+oNY36qOjDn97D7YhJbBY+7Ru0oHlqz+pnjoabZSyozs8cNZjD3cQ4plTjXwQtv1i0eMABO6TihX 1q6UenYeUTMg58n1jf25iQhIupp/pXi9Wd+XFCagyQhdJp3UNpAUcE+ypCR06YKGZbaxGwAUPdGyk +7Yy2j7Xg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kBJKc-0000Yo-HF; Thu, 27 Aug 2020 14:56:50 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kBJKa-0000YF-CX for linux-arm-kernel@lists.infradead.org; Thu, 27 Aug 2020 14:56:49 +0000 Received: from gaia (unknown [46.69.195.127]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 178032054F; Thu, 27 Aug 2020 14:56:44 +0000 (UTC) Date: Thu, 27 Aug 2020 15:56:42 +0100 From: Catalin Marinas To: Andrey Konovalov Subject: Re: [PATCH 21/35] arm64: mte: Add in-kernel tag fault handler Message-ID: <20200827145642.GO29264@gaia> References: <20200827095429.GC29264@gaia> <20200827131045.GM29264@gaia> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200827_105648_585718_4E3EA0D8 X-CRM114-Status: GOOD ( 25.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux ARM , Marco Elver , Elena Petrova , Kevin Brodsky , Will Deacon , Branislav Rankov , kasan-dev , LKML , Linux Memory Management List , Alexander Potapenko , Evgenii Stepanov , Andrey Ryabinin , Andrew Morton , Vincenzo Frascino , Dmitry Vyukov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 27, 2020 at 03:34:42PM +0200, Andrey Konovalov wrote: > On Thu, Aug 27, 2020 at 3:10 PM Catalin Marinas wrote: > > On Thu, Aug 27, 2020 at 02:31:23PM +0200, Andrey Konovalov wrote: > > > On Thu, Aug 27, 2020 at 11:54 AM Catalin Marinas > > > wrote: > > > > On Fri, Aug 14, 2020 at 07:27:03PM +0200, Andrey Konovalov wrote: > > > > > +static int do_tag_recovery(unsigned long addr, unsigned int esr, > > > > > + struct pt_regs *regs) > > > > > +{ > > > > > + report_tag_fault(addr, esr, regs); > > > > > + > > > > > + /* Skip over the faulting instruction and continue: */ > > > > > + arm64_skip_faulting_instruction(regs, AARCH64_INSN_SIZE); > > > > > > > > Ooooh, do we expect the kernel to still behave correctly after this? I > > > > thought the recovery means disabling tag checking altogether and > > > > restarting the instruction rather than skipping over it. [...] > > > Can we disable MTE, reexecute the instruction, and then reenable MTE, > > > or something like that? > > > > If you want to preserve the MTE enabled, you could single-step the > > instruction or execute it out of line, though it's a bit more convoluted > > (we have a similar mechanism for kprobes/uprobes). > > > > Another option would be to attempt to set the matching tag in memory, > > under the assumption that it is writable (if it's not, maybe it's fine > > to panic). Not sure how this interacts with the slub allocator since, > > presumably, the logical tag in the pointer is wrong rather than the > > allocation one. > > > > Yet another option would be to change the tag in the register and > > re-execute but this may confuse the compiler. > > Which one of these would be simpler to implement? Either 2 or 3 would be simpler (re-tag the memory location or the pointer) with the caveats I mentioned. Also, does the slab allocator need to touch the memory on free with a tagged pointer? Otherwise slab may hit an MTE fault itself. > Perhaps we could somehow only skip faulting instructions that happen > in the KASAN test module?.. Decoding stack trace would be an option, > but that's a bit weird. If you want to restrict this to the KASAN tests, just add some MTE-specific accessors with a fixup entry similar to get_user/put_user. __do_kernel_fault() (if actually called) will invoke the fixup code which skips the access and returns an error. This way KASAN tests can actually verify that tag checking works, I'd find this a lot more useful. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel