From: "hch@infradead.org" <hch@infradead.org>
To: "Derrick, Jonathan" <jonathan.derrick@intel.com>
Cc: "hch@infradead.org" <hch@infradead.org>,
"wangxiongfeng2@huawei.com" <wangxiongfeng2@huawei.com>,
"kw@linux.com" <kw@linux.com>,
"hkallweit1@gmail.com" <hkallweit1@gmail.com>,
"kai.heng.feng@canonical.com" <kai.heng.feng@canonical.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mika.westerberg@linux.intel.com"
<mika.westerberg@linux.intel.com>,
"Mario.Limonciello@dell.com" <Mario.Limonciello@dell.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"Williams, Dan J" <dan.j.williams@intel.com>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"Huffman, Amber" <amber.huffman@intel.com>,
"Wysocki, Rafael J" <rafael.j.wysocki@intel.com>
Subject: Re: [PATCH] PCI/ASPM: Enable ASPM for links under VMD domain
Date: Thu, 27 Aug 2020 17:23:33 +0100 [thread overview]
Message-ID: <20200827162333.GA6822@infradead.org> (raw)
In-Reply-To: <660c8671a51eec447dc7fab22bacbc9c600508d9.camel@intel.com>
On Thu, Aug 27, 2020 at 04:13:44PM +0000, Derrick, Jonathan wrote:
> On Thu, 2020-08-27 at 06:34 +0000, hch@infradead.org wrote:
> > On Wed, Aug 26, 2020 at 09:43:27PM +0000, Derrick, Jonathan wrote:
> > > Feel free to review my set to disable the MSI remapping which will
> > > make
> > > it perform as well as direct-attached:
> > >
> > > https://patchwork.kernel.org/project/linux-pci/list/?series=325681
> >
> > So that then we have to deal with your schemes to make individual
> > device direct assignment work in a convoluted way?
>
> That's not the intent of that patchset -at all-. It was to address the
> performance bottlenecks with VMD that you constantly complain about.
I know. But once we fix that bottleneck we fix the next issue,
then to tackle the next. While at the same time VMD brings zero
actual benefits.
> > Please just give us
> > a disable nob for VMD, which solves _all_ these problems without
> > adding
> > any.
>
> I don't see the purpose of this line of discussion. VMD has been in the
> kernel for 5 years. We are constantly working on better support.
Please just work with the platform people to allow the host to disable
VMD. That is the only really useful value add here.
next prev parent reply other threads:[~2020-08-27 16:23 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 12:32 [PATCH] PCI/ASPM: Enable ASPM for links under VMD domain Kai-Heng Feng
2020-08-24 13:04 ` Mika Westerberg
2020-08-25 6:23 ` Christoph Hellwig
2020-08-25 6:39 ` Kai Heng Feng
2020-08-25 6:56 ` Christoph Hellwig
2020-08-26 5:53 ` Kai-Heng Feng
2020-09-02 19:48 ` David Fugate
2020-09-02 22:54 ` Keith Busch
2020-08-26 21:43 ` Derrick, Jonathan
2020-08-27 6:34 ` hch
2020-08-27 16:13 ` Derrick, Jonathan
2020-08-27 16:23 ` hch [this message]
2020-08-27 16:45 ` Derrick, Jonathan
2020-08-27 16:50 ` hch
2020-08-27 21:33 ` Dan Williams
2020-08-29 7:23 ` hch
2020-08-27 17:49 ` Limonciello, Mario
2020-08-29 7:24 ` hch
2020-09-10 1:55 ` Bjorn Helgaas
2020-09-10 16:33 ` Derrick, Jonathan
2020-09-10 17:38 ` Bjorn Helgaas
[not found] <0f902d555deb423ef1c79835b23c917be2633162.camel@intel.com>
2020-09-10 19:17 ` Bjorn Helgaas
2020-09-10 19:51 ` Derrick, Jonathan
2020-09-17 17:20 ` Bjorn Helgaas
2020-09-23 14:29 ` Kai-Heng Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200827162333.GA6822@infradead.org \
--to=hch@infradead.org \
--cc=Mario.Limonciello@dell.com \
--cc=amber.huffman@intel.com \
--cc=bhelgaas@google.com \
--cc=dan.j.williams@intel.com \
--cc=hkallweit1@gmail.com \
--cc=jonathan.derrick@intel.com \
--cc=kai.heng.feng@canonical.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=wangxiongfeng2@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.