From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17410C433E2 for ; Fri, 28 Aug 2020 06:40:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DC84F208CA for ; Fri, 28 Aug 2020 06:40:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598596853; bh=o0DvwBJycu4mClUYxJbCqVEQk81q47GMWC6SPnDCSnA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Fyt1E2rqLfKQq/4NVLTFV8yWqiB6snNNuPyTpXUpHv7jABNso72vIswPd2RNWKCig 9wGtLLyUIv5qt+J4vflntDyiNIo+XXZFX8cOdebMtZ2LgjTg/q5tq8gGawfC6BhOtl PcKUzfoEXzPk3nF6drl6G06DQPsrw1Lnl1j6g7Fg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726791AbgH1Gkv (ORCPT ); Fri, 28 Aug 2020 02:40:51 -0400 Received: from mail-ej1-f67.google.com ([209.85.218.67]:43184 "EHLO mail-ej1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725858AbgH1Gkv (ORCPT ); Fri, 28 Aug 2020 02:40:51 -0400 Received: by mail-ej1-f67.google.com with SMTP id m22so54395eje.10; Thu, 27 Aug 2020 23:40:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=CdphvIxkab/YX1ffuXPnoifp6qWQpQf0APCtuuMP1Lw=; b=nX03C9yhufTPAh5mHQQQTIQwn16/VdoduYkKzR9PyE7danmJlLzUlWR4AI7yPYJKgv tTy49WHYMQ+okTnF4hohwB1+EuqGjF0aj5SMsThA3QYl5sEl9RWSICe6olHvGiMnCq8d CEvNgDOcoc1SI7RwCblu/vcF7T6Ll0HwkQET8vsrs+M+u5x7ahTfocl6+vKPd+KJJL0Z Uy6goLsBykTThMqC731YeXo4SwY4oVcmzLqDJQgqnBvY0/tG6ooV7IzjOH2ZaWS/73nb aZJHAFAzry3eGtzWCtspwAxDmgOz1BvihfiqwNK7yrDFTwTrk6L4LipnqySG4mBOIpWg wkfw== X-Gm-Message-State: AOAM532Pp89juW6y8TBoi+An54BTV5KS1yT/vwUNQH5P4VcAYVUue0bP U8wYS5B71RGle1/qrKUjRUU= X-Google-Smtp-Source: ABdhPJwTxtk1I8/HNlEgrbvBSVMeu1t34ItwkeBp44qDs/tNjiLPiQBZ1khYH/UgBI7CkJn7BP42qQ== X-Received: by 2002:a17:906:970e:: with SMTP id k14mr291072ejx.417.1598596848763; Thu, 27 Aug 2020 23:40:48 -0700 (PDT) Received: from pi3 ([194.230.155.216]) by smtp.googlemail.com with ESMTPSA id 24sm162457edx.35.2020.08.27.23.40.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Aug 2020 23:40:48 -0700 (PDT) Date: Fri, 28 Aug 2020 08:40:45 +0200 From: Krzysztof Kozlowski To: Sylwester Nawrocki Cc: linux-clk@vger.kernel.org, Tomasz Figa , Chanwoo Choi , Michael Turquette , Stephen Boyd , Kukjin Kim , Rob Herring , linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, m.szyprowski@samsung.com, b.zolnierkie@samsung.com Subject: Re: [PATCH 3/3] clk: samsung: Use cached clk_hws instead of __clk_lookup() calls Message-ID: <20200828064045.GC17406@pi3> References: <20200826171529.23618-1-s.nawrocki@samsung.com> <20200826171529.23618-3-s.nawrocki@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200826171529.23618-3-s.nawrocki@samsung.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 26, 2020 at 07:15:29PM +0200, Sylwester Nawrocki wrote: > For the CPU clock registration two parent clocks are required, these > are now being passed as struct clk_hw pointers, rather than by the > global scope names. That allows us to avoid __clk_lookup() calls > and simplifies a bit the CPU clock registration function. > While at it drop unneeded extern keyword in the function declaration. > > Signed-off-by: Sylwester Nawrocki > --- > drivers/clk/samsung/clk-cpu.c | 37 +++++++++++++++--------------------- > drivers/clk/samsung/clk-cpu.h | 6 +++--- > drivers/clk/samsung/clk-exynos3250.c | 6 ++++-- > drivers/clk/samsung/clk-exynos4.c | 7 +++++-- > drivers/clk/samsung/clk-exynos5250.c | 4 +++- > drivers/clk/samsung/clk-exynos5420.c | 6 +++--- > drivers/clk/samsung/clk-exynos5433.c | 10 ++++++++-- > 7 files changed, 41 insertions(+), 35 deletions(-) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7A54C433E6 for ; Fri, 28 Aug 2020 06:42:08 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 70F422098B for ; Fri, 28 Aug 2020 06:42:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="0FO4Rsiw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 70F422098B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=npJPFgB9++f+CAlxdRWFAKay1auc4FaizlT5KpQQclU=; b=0FO4RsiwKmigK/zUxAkq0rI+O aETIxnk/Ol9rsAycbpywBBTbmL7yoZXlKEnMgDIyTJffkMTHR8NJ/mG2ByDFkps35uRNo1eqOCsfj lKllAp0a19VJ2WDqmxDRnUZ5/ehYoPDYS/oV88vGt+Bi8eSTWosdc4Lkd+TRGexdhxsj3VvWvQYH0 v/J8uAMX9XJftqiWLq2f8I++PkeSdn+Hf/KMlGMZpbrQ8j6ef79zTR2fzYPS7xAw1sPd41aHpsbCG BSzItimIX/uQbGbY9ClY3pLpo2c5ffn0umiGNbvSQdBShTaaMcvjGjlP8pxjzn2eRbtONs3qkKgty rdNTx3UMQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kBY4C-0000h1-0g; Fri, 28 Aug 2020 06:40:52 +0000 Received: from mail-ej1-f66.google.com ([209.85.218.66]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kBY4A-0000gU-0b for linux-arm-kernel@lists.infradead.org; Fri, 28 Aug 2020 06:40:50 +0000 Received: by mail-ej1-f66.google.com with SMTP id d11so37433ejt.13 for ; Thu, 27 Aug 2020 23:40:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=CdphvIxkab/YX1ffuXPnoifp6qWQpQf0APCtuuMP1Lw=; b=AIF5u3Bc4VcHopAIGK08fl7SnfB+cFyFCPmFYrIPIVKcHFbnxoH/sYQUQCzSeSVStI PXqDW6aF6j9CgwFepLc+ZNhqG6r1tNet8KRskqmd8W3Vu6rBmBwSDU7jWBPUQ31dpuGm yYWq79x6jHsHZR43C6vGLYSYposbA/eYtcVO4yTe/jeypLGFZWXnY+jbAMbWKnlTwmDg 5vEx/OWJWewhcTpIPV7UtWbzZQ2akVCiHExYw7wx7/mdVp1YzwAl3ruAw+sUEWSkn/Zb MxUyXysK68wTYwtYRAE7nQw00bTI4NzupEpIvzbdDI8LpOmCa7Vd739BYTEADR7DmWj0 F3Qg== X-Gm-Message-State: AOAM530x8hl4AClD3+ctKlqXgaFlmcDZQLiO6XJLxjHS/forc5AgKpXt xwqbSd2dbJ1YuIO4KtYove8= X-Google-Smtp-Source: ABdhPJwTxtk1I8/HNlEgrbvBSVMeu1t34ItwkeBp44qDs/tNjiLPiQBZ1khYH/UgBI7CkJn7BP42qQ== X-Received: by 2002:a17:906:970e:: with SMTP id k14mr291072ejx.417.1598596848763; Thu, 27 Aug 2020 23:40:48 -0700 (PDT) Received: from pi3 ([194.230.155.216]) by smtp.googlemail.com with ESMTPSA id 24sm162457edx.35.2020.08.27.23.40.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Aug 2020 23:40:48 -0700 (PDT) Date: Fri, 28 Aug 2020 08:40:45 +0200 From: Krzysztof Kozlowski To: Sylwester Nawrocki Subject: Re: [PATCH 3/3] clk: samsung: Use cached clk_hws instead of __clk_lookup() calls Message-ID: <20200828064045.GC17406@pi3> References: <20200826171529.23618-1-s.nawrocki@samsung.com> <20200826171529.23618-3-s.nawrocki@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200826171529.23618-3-s.nawrocki@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200828_024050_066911_4C3FF210 X-CRM114-Status: GOOD ( 15.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, b.zolnierkie@samsung.com, Stephen Boyd , Michael Turquette , Tomasz Figa , Rob Herring , linux-kernel@vger.kernel.org, Chanwoo Choi , Kukjin Kim , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 26, 2020 at 07:15:29PM +0200, Sylwester Nawrocki wrote: > For the CPU clock registration two parent clocks are required, these > are now being passed as struct clk_hw pointers, rather than by the > global scope names. That allows us to avoid __clk_lookup() calls > and simplifies a bit the CPU clock registration function. > While at it drop unneeded extern keyword in the function declaration. > > Signed-off-by: Sylwester Nawrocki > --- > drivers/clk/samsung/clk-cpu.c | 37 +++++++++++++++--------------------- > drivers/clk/samsung/clk-cpu.h | 6 +++--- > drivers/clk/samsung/clk-exynos3250.c | 6 ++++-- > drivers/clk/samsung/clk-exynos4.c | 7 +++++-- > drivers/clk/samsung/clk-exynos5250.c | 4 +++- > drivers/clk/samsung/clk-exynos5420.c | 6 +++--- > drivers/clk/samsung/clk-exynos5433.c | 10 ++++++++-- > 7 files changed, 41 insertions(+), 35 deletions(-) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel