From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1kBYZG-0007xW-6E for mharc-grub-devel@gnu.org; Fri, 28 Aug 2020 03:12:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46818) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBYZF-0007xO-3z for grub-devel@gnu.org; Fri, 28 Aug 2020 03:12:57 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:55241) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBYZC-0005Qm-HO for grub-devel@gnu.org; Fri, 28 Aug 2020 03:12:56 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id D68EEA68; Fri, 28 Aug 2020 03:12:50 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Fri, 28 Aug 2020 03:12:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pks.im; h=date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=I8Uy+jwFyZdAphSOX/sdKy8Vkyh k1Ng6wTCruqLI4a4=; b=BBXCtVk4u0xszl6EJQn74kQ0kyNHYwBi0iPrdmBLYo3 /y/9Ju839FInm1GAxdfZ11O0svFOx3nzZMEA6zD/eoaJXbmwJnZUHjzyoQMJi4Kq BoLJ8zKDUtlcCKjM25pGtY8cltXWxLIpKcahIJ8eWOgSq+JJaCnL9B64nkxTN84n /j6dAB7KhcbKDWtC/Eh0xuGO8xBobpXncG4MeJSg9z3pVU2vgqVrDfoKK5me+E6E siACL4hd/eG3YUeaPJf0ifpSsiUAhAngjk6STErwz1U0rdFB5Am+rNCcnQf5KP69 3ci/Wal6IGkWPPnQl40DatXUE0MQIMnAaGyCegdNZLA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=I8Uy+j wFyZdAphSOX/sdKy8Vkyhk1Ng6wTCruqLI4a4=; b=LmhsB+zqbxRqtTQS7e6qdp QPprfcQRNdCUmkGCn7QF/GnI6Rnmug3TvoO+SJf8fW3InHnp58kQ+WS3P5X/lyLO MEWgxp6jrzuoBBKMnpYjVKXDtPortrk7fluaD/GWIZKcaEBelGx7ARMh9ccpb2aB eVpte0Uwsj2QEqQiToEc4XAQGZTt0UtHF4ghFy0GRrRTJvlAvBqaxNHNjUGOpsCg qQ6PlZCcXW5XR+v1gqA+zhKoXq82kIwXDSOvtPDvQ2l+C9zbjZcOXd/hFL8IAWMw tNkpvaoAl1LdRhRYUii6Jismref1OSjwf1trozh/VSXG53hBpIFF9hukXiqDVkZg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedruddviedgudduvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfhfgggtuggjsehgtd erredttddvnecuhfhrohhmpefrrghtrhhitghkucfuthgvihhnhhgrrhguthcuoehpshes phhkshdrihhmqeenucggtffrrghtthgvrhhnpeehgefhtdefueffheekgfffudelffejtd fhvdejkedthfehvdelgfetgfdvtedthfenucfkphepjeekrdehgedrudduiedrvdegvden ucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehpshesph hkshdrihhm X-ME-Proxy: Received: from vm-mail.pks.im (x4e3674f2.dyn.telefonica.de [78.54.116.242]) by mail.messagingengine.com (Postfix) with ESMTPA id 8486B30600A3; Fri, 28 Aug 2020 03:12:49 -0400 (EDT) Received: from localhost (ncase [10.192.0.11]) by vm-mail.pks.im (OpenSMTPD) with ESMTPSA id 4ee938e8 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 28 Aug 2020 07:12:45 +0000 (UTC) Date: Fri, 28 Aug 2020 09:12:52 +0200 From: Patrick Steinhardt To: Glenn Washburn Cc: grub-devel@gnu.org Subject: Re: [PATCH] cryptodisk: Incorrect calculation of sector in grub_cryptodisk_read/write. Message-ID: <20200828071252.GA44736@ncase.pks.im> References: <20200826234435.2079207-1-development@efficientek.com> <20200826185029.7cb01a16@crass-HP-ZBook-15-G2> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="EeQfGwPcQSOJBaQU" Content-Disposition: inline In-Reply-To: <20200826185029.7cb01a16@crass-HP-ZBook-15-G2> Received-SPF: pass client-ip=64.147.123.24; envelope-from=ps@pks.im; helo=wout1-smtp.messagingengine.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/28 01:54:32 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Aug 2020 07:12:57 -0000 --EeQfGwPcQSOJBaQU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 26, 2020 at 06:50:29PM -0500, Glenn Washburn wrote: > On Wed, 26 Aug 2020 18:44:35 -0500 > Glenn Washburn wrote: >=20 > > Here dev is a grub_cryptodisk_t and dev->offset is offset in sectors > > of size native to the cryptodisk device. The function grub_disk_read > > expects that the given start sector is in the native grub sector > > size, so dev->offset must be converted as well. Create function > > grub_disk_from_native_sector to convert disk sectors to grub sectors. >=20 > Upon reviewing my previous patch, I realized that the updated commit > message had gotten lost. So this only changes the commit message and > not the diff itself. I don't think its imperative to have this updated > commit message, but I do think it more clearly and accurately describes > the patch. >=20 > Glenn I did already update the commit's title in v2 of my patch series, but not its body. I'll pick your improvement if there's a need for v3 of my patch series, thanks! Patrick --EeQfGwPcQSOJBaQU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEF9hrgiFbCdvenl/rVbJhu7ckPpQFAl9IrnMACgkQVbJhu7ck PpTuKw//Q9eKzgU9B7njihF6t9cqi1pfGtusdV66Tgj5VDqPfE3TDlOnuUkK+0O0 HuUPM+BHUQCQ/ll3Y45qB4hb/zzts/RGfX7mvgZG0XUwENp1Ggz1B3wtnuz9lXZ+ Z7jCclu2hoNCyxTartGtTrYUqxyyWKUHBjLGsBOz6vhbYQlseou8M9Tw0IdltfxM Y3JWsecgGdFDreKwea6T4jZ2QxvhNcHW8xYpK3jvElnYsH8bsz2sSrsTjnYrcYDY VwdQ7cDZsMqiS8U/0n6kNytQXJ6Rgcb1AblhsCxIVVy9tb1RUpdTuxnuO7repR8J Okuw0nkokQUZu6w+wM51P6xYprT5STnJzNLz8EA/q5w+ejIVZ2IOb26Ac0OSMd/J BEFsvhjGhMGr7Q2oWy5F3X5J8Yp57QcBTFZmXNG+SHgt5n6xfuOzom7tDSU8oMHE uJCUNbx2gX/rec2ykU2RXnUYsWiPT+pk3grhumtvpVF6mNxL/LKmHwlRUgd9AzMM uhZQ1UfHPFlhH5GdaRVghFw7arbdH+0fFfUXH8hUQg2Xzbr/bAlcR4YLzdfXqG6p Ehr7qD5T83u2s4YZEGP0xOS+xX4WCxVyOkZNY4Ne4Z0e08i+1TPmJWCyW9gC2J1Y J2yI3bXFT0Goq1eAMMMQL0ZWHkw3vPe7Fvz1fH2PXojWc2imYjk= =6Nit -----END PGP SIGNATURE----- --EeQfGwPcQSOJBaQU--