On Wed, Aug 26, 2020 at 05:16:57PM -0500, Glenn Washburn wrote: > On Wed, 26 Aug 2020 10:13:18 +0200 > Patrick Steinhardt wrote: > > > I didn't yet get your test series to work, Glenn. I'll try again on > > another day as I'm not on top of things today. Meanwhile, could you > > please give it a go with this updated patch series? > > I've tested with this patch series and all tests pass. Thanks for letting me know. > Which part isn't working for the tests? The patchset (on the > mailinglist) has expected failures for all LUKS2 tests because my LUKS2 > keyfile patch is needed. So the tests should be able to verify that > LUKS1 tests are passing before and after this patchset. As I said, it's mostly me not having the brain capacity right now. Next to the keyfile dependency I'd also have to change MAC policies on my system or set up a VM for it, but I don't feel too well this week and thus need to defer this. > Here's the branch I created that has your patch series, the v5 crypto > keyfile and detached header patch series, my cryptomount test patches, > my luks2 keyfile patch, and patches turning on tests now expecting to > pass in that order applied to master. > > https://github.com/crass/grub/tree/cryptodisk-fixes-for-v2.06.v2+cryptodisk-v5+cryptodisk-tests > > Here is a command sequence that should show the cryptomount test as > passing. You can look at some more details of the testing in the test > log file grub_cmd_cryptomount.log. Once you see the tests passing, you > can remove some of the commits in the patch series and verify that the > test fails and that the appropriate subtest fails by checking the log > file. > > ------------------------------------------- > git clone https://github.com/crass/grub.git > cd grub > git checkout > cryptodisk-fixes-for-v2.06.v2+cryptodisk-v5+cryptodisk-tests > ./bootstrap && ./configure && make -j8 > sudo env TESTS=grub_cmd_cryptomount make -e check VERBOSE=yes SUBDIRS= > ------------------------------------------- Thanks a lot for these! Patrick