From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1kBYdC-0000IY-4o for mharc-grub-devel@gnu.org; Fri, 28 Aug 2020 03:17:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47620) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBYd9-0000IH-Q9 for grub-devel@gnu.org; Fri, 28 Aug 2020 03:16:59 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:47943) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBYd8-00060y-04 for grub-devel@gnu.org; Fri, 28 Aug 2020 03:16:59 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 417518FE; Fri, 28 Aug 2020 03:16:56 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Fri, 28 Aug 2020 03:16:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pks.im; h=date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=4s1CElt3O/KBMrfvSyaZI/FYzYG hvnJl4wR35ZCig80=; b=Tr6wo5ntwdojzWfGxlv9uCLeFKM4ZWjB5DPefNzZLRa 9kCuzwDWKF6o6zC4kK9vbQJJJm26DN89oEBj0t1JOV0/1giRSJFQAMnxrYgYIHb+ wLSvJD1yuVfSOhMi75tdVzw29UmVnd0J/inffCrKKUFdq9FTNlPA3Qzh9dC7+DjW ibmHuvf2vGXjF68+43raGaolPJltEpSFCWBldwMGRGXge7zro035p1JWVpoPum6q LK9h2TY/MmjgSB/0Z/agpmdynOvIhpwc6jQwUDJQWoyGHYmfAB9WdTPjKn6IQIsS +BqpYCb27hwNc25xql81YDCNr/jcWkzpBG/GFF4DuKw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=4s1CEl t3O/KBMrfvSyaZI/FYzYGhvnJl4wR35ZCig80=; b=DLfXe3VjoCUKUzBJPeihAd XkEbEBbQeNJlFcfrIq+OhDHNphauuWBYGfsxgLvjvrDm3nyNaajoIiG7tBbDRawn EWU31XrFIbU0gUNTyjF/pN3q41Bw218y7je+gdLFhzEAabc+lbM7j/O68ji/WDaQ f//f7beNubbLbE9ub2Md+PI2CLgkEidMT04YKqDVriHchJmYwywJRsxEZWVtj33C RIEaLInYobcPaB7C26re3lqzElp1yoVjf9Yy3bsZRgnbt2k9ruKT4y7QHib7dXPv 0HMODrK23OK8CRdcfzIuSn5M73khdGlcmi6INCvVRZnMLRIeKoMv4lnnNw058hZg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedruddviedguddufecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomheprfgrthhr ihgtkhcuufhtvghinhhhrghrughtuceophhssehpkhhsrdhimheqnecuggftrfgrthhtvg hrnhephfdtvdduleegteeghfektdduleeuleeilefftdevleelveeuffeihfehfeekkeei necuffhomhgrihhnpehgihhthhhusgdrtghomhenucfkphepjeekrdehgedrudduiedrvd egvdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehp shesphhkshdrihhm X-ME-Proxy: Received: from vm-mail.pks.im (x4e3674f2.dyn.telefonica.de [78.54.116.242]) by mail.messagingengine.com (Postfix) with ESMTPA id A826E30600B2; Fri, 28 Aug 2020 03:16:54 -0400 (EDT) Received: from localhost (ncase [10.192.0.11]) by vm-mail.pks.im (OpenSMTPD) with ESMTPSA id 5be85895 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 28 Aug 2020 07:16:53 +0000 (UTC) Date: Fri, 28 Aug 2020 09:17:00 +0200 From: Patrick Steinhardt To: Glenn Washburn Cc: grub-devel@gnu.org, Denis GNUtoo Carikli , Daniel Kiper Subject: Re: [PATCH v2 0/9] Cryptodisk fixes for v2.06 Message-ID: <20200828071700.GB44736@ncase.pks.im> References: <20200826171657.2741b3ac@crass-HP-ZBook-15-G2> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ZfOjI3PrQbgiZnxM" Content-Disposition: inline In-Reply-To: <20200826171657.2741b3ac@crass-HP-ZBook-15-G2> Received-SPF: pass client-ip=64.147.123.24; envelope-from=ps@pks.im; helo=wout1-smtp.messagingengine.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/28 01:54:32 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Aug 2020 07:17:00 -0000 --ZfOjI3PrQbgiZnxM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 26, 2020 at 05:16:57PM -0500, Glenn Washburn wrote: > On Wed, 26 Aug 2020 10:13:18 +0200 > Patrick Steinhardt wrote: >=20 > > I didn't yet get your test series to work, Glenn. I'll try again on > > another day as I'm not on top of things today. Meanwhile, could you > > please give it a go with this updated patch series? >=20 > I've tested with this patch series and all tests pass. Thanks for letting me know. > Which part isn't working for the tests? The patchset (on the > mailinglist) has expected failures for all LUKS2 tests because my LUKS2 > keyfile patch is needed. So the tests should be able to verify that > LUKS1 tests are passing before and after this patchset. As I said, it's mostly me not having the brain capacity right now. Next to the keyfile dependency I'd also have to change MAC policies on my system or set up a VM for it, but I don't feel too well this week and thus need to defer this. > Here's the branch I created that has your patch series, the v5 crypto > keyfile and detached header patch series, my cryptomount test patches, > my luks2 keyfile patch, and patches turning on tests now expecting to > pass in that order applied to master. >=20 > https://github.com/crass/grub/tree/cryptodisk-fixes-for-v2.06.v2+cryptodi= sk-v5+cryptodisk-tests >=20 > Here is a command sequence that should show the cryptomount test as > passing. You can look at some more details of the testing in the test > log file grub_cmd_cryptomount.log. Once you see the tests passing, you > can remove some of the commits in the patch series and verify that the > test fails and that the appropriate subtest fails by checking the log > file. >=20 > ------------------------------------------- > git clone https://github.com/crass/grub.git > cd grub > git checkout > cryptodisk-fixes-for-v2.06.v2+cryptodisk-v5+cryptodisk-tests > ./bootstrap && ./configure && make -j8 > sudo env TESTS=3Dgrub_cmd_cryptomount make -e check VERBOSE=3Dyes SUBDIRS= =3D > ------------------------------------------- Thanks a lot for these! Patrick --ZfOjI3PrQbgiZnxM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEF9hrgiFbCdvenl/rVbJhu7ckPpQFAl9Ir2sACgkQVbJhu7ck PpSIig/+M0LGd/1GmKsCTZM7dKX9leWVhjQZwNa8d7tJz110r8UpnUqb5zw6NGpj 3a3+mRZgsSgJyahRPQTrAgPzlL2QwH2lLBabPNXVnSInd04fj5S5yqZQtutEO7Bi /mw+HdPmh2GbGthyBo5mMwS0CDaK12v8w6zNmPsa2yTpGtKQflm1WoWfIk+NFNb+ g/Yzg6CaQeBYhlaiNCDWUUPPZwiG/gnDozcDyUhdp5wMJYVokwOSrK64+d+oaozV TFn5TuozL1QjGGZ5NJRglZqg0190m2Pd/NlH3VSy+yWuj+eAP6/YxkS4x2Dd8ieK E9YyVCQP6rxAa1+wRuppuZQtwhLH4FATWzUmDQY5Mzpgt2TA2SVKRjHY3qBqZrkE ReRbBJgk1cqxxSi0QQuN6BIAJ4ocp7DykCu5K5xdY8Lp0zS58TcXFR3Bx/qQ6pCB Oogq2ziRn826HxEFLsrJVkKW20025r067LYYUokBqxL6gUT9ncGD9sYzrdNlvinS +V/PCFMHSVZNejO/bF2eWvI6iLvG2h9pcrAT51U2QSMyf75Vc7DQe+nIqdmNBSd/ Ik9XpjfJ9OyaKE9vtdP5CodH6OFoJNQdK389K1nobssBBK5Fu5NX+1wU35l+ejTI znm/T1kVLIumuiT8/ah/hoIoVI47lfQdlPQDPiV8dTObDjiMM08= =pdML -----END PGP SIGNATURE----- --ZfOjI3PrQbgiZnxM--