From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D49AFC433E2 for ; Fri, 28 Aug 2020 10:08:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A05982078A for ; Fri, 28 Aug 2020 10:08:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="kPoIVAiq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729027AbgH1KIp (ORCPT ); Fri, 28 Aug 2020 06:08:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729014AbgH1KIi (ORCPT ); Fri, 28 Aug 2020 06:08:38 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55586C061264 for ; Fri, 28 Aug 2020 03:08:38 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id x7so757578wro.3 for ; Fri, 28 Aug 2020 03:08:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=v5lZnMhxQ5xHaQDAvMt8o84hghDQ+psCSSy2/pA49/0=; b=kPoIVAiqq1QaZS578tG1TWbJT7hIKgNMnnpooLDBh97H/EMbG3iVtH5wj0bfTE86mG IxXT/saTC8D5kEgad8cU4Da0I0IcTci98+zeua0tD2+nPSoAu4MY8DYUUNzrUWHhnJqo cwh0iew9zJrJXF6YjIoLjrkxqZjmJfC7qx+L4uwzEc/PjO5dyMAhggI2KizmbfB87ZLE joIKezV6zFJq68p20wCYE08ZD2sgYJrh+r0jNVFcaSrnA7TedxHa4OtJXzI4Qhy2tQ1X DofqiSnbhcVP6SSruYC6CrHKgHDgFZBVacJcX189OpjMzoBgFKLysZoY2HdKE+vI3qy6 R1zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=v5lZnMhxQ5xHaQDAvMt8o84hghDQ+psCSSy2/pA49/0=; b=Y2opqvNPQiEOTr2706x5T5gacbB88/RhdmTXXxjh94ORCdn2m31zXmeNAWGtxGZ0Cj 0OdVMGqNfJ4rag5fi8qn/KJOVtrl5gd1H4H3QRgwPBvlb+5TWkfy+4jN40nInOPHYIFm JNk0JXcRQpi+E0TwKtBDiXC2LrV/XILuI3pneyLuact/HesModwObZOa/5lYMJCKhuJW aRU2ILiEJfci8JsrWODxIZHNKUNU49K0eR81kEVIGCbUEuB9loiBf0BsVjKnemrHuurF uJk4OS3lzAWgo+AX5VH5sILU7rx8+9Ubelr3Kq1VqkEy0h5QOH50T624EAMC8xGFBpW/ 39vg== X-Gm-Message-State: AOAM531g1K0yXEj2YWQMIzXqBoR9Xye/9O5BJmj7INj9Ig7NMrWN4fk3 EbRjPVGpwTKavARkUDzdhtPR2w== X-Google-Smtp-Source: ABdhPJwVvQEqQCgPU0h1cMou7BBaQ5dj2m3YsYRGYfBolRb7b1B/iW+2QQKgMONqUDvLgdIxn3DsDQ== X-Received: by 2002:a5d:5446:: with SMTP id w6mr770934wrv.349.1598609317023; Fri, 28 Aug 2020 03:08:37 -0700 (PDT) Received: from dell ([91.110.221.141]) by smtp.gmail.com with ESMTPSA id g3sm1242071wrb.59.2020.08.28.03.08.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Aug 2020 03:08:36 -0700 (PDT) Date: Fri, 28 Aug 2020 11:08:34 +0100 From: Lee Jones To: Kalle Valo Cc: Ondrej Zary , Jesse Brandeburg , davem@davemloft.net, kuba@kernel.org, linux-kernel@vger.kernel.org, Benjamin Reed , Javier Achirica , Jean Tourrilhes , Fabrice Bellet , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 12/30] net: wireless: cisco: airo: Fix a myriad of coding style issues Message-ID: <20200828100834.GG1826686@dell> References: <20200814113933.1903438-1-lee.jones@linaro.org> <202008172335.02988.linux@zary.sk> <87v9h4le9z.fsf@codeaurora.org> <202008272223.57461.linux@zary.sk> <87lfhz9mdi.fsf@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87lfhz9mdi.fsf@codeaurora.org> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Fri, 28 Aug 2020, Kalle Valo wrote: > Ondrej Zary writes: > > > On Thursday 27 August 2020 09:49:12 Kalle Valo wrote: > >> Ondrej Zary writes: > >> > >> > On Monday 17 August 2020 20:27:06 Jesse Brandeburg wrote: > >> >> On Mon, 17 Aug 2020 16:27:01 +0300 > >> >> Kalle Valo wrote: > >> >> > >> >> > I was surprised to see that someone was using this driver in 2015, so > >> >> > I'm not sure anymore what to do. Of course we could still just remove > >> >> > it and later revert if someone steps up and claims the driver is still > >> >> > usable. Hmm. Does anyone any users of this driver? > >> >> > >> >> What about moving the driver over into staging, which is generally the > >> >> way I understood to move a driver slowly out of the kernel? > >> > > >> > Please don't remove random drivers. > >> > >> We don't want to waste time on obsolete drivers and instead prefer to > >> use our time on more productive tasks. For us wireless maintainers it's > >> really hard to know if old drivers are still in use or if they are just > >> broken. > >> > >> > I still have the Aironet PCMCIA card and can test the driver. > >> > >> Great. Do you know if the airo driver still works with recent kernels? > > > > Yes, it does. > > Nice, I'm very surprised that so old and unmaintained driver still > works. Thanks for testing. That's awesome. Go Linux! So where does this leave us from a Maintainership perspective? Are you still treating the driver as obsolete? After this revelation, I suggest not. So let's make it better. :) -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog