Re: [RFC PATCH] KVM: x86: Support write protect huge pages lazily

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3276 bytes --]

Hi Keqian,

[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on kvm/linux-next]
[also build test ERROR on tip/auto-latest vhost/linux-next v5.9-rc2 next-20200828]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Keqian-Zhu/KVM-x86-Support-write-protect-huge-pages-lazily/20200828-161514
base:   https://git.kernel.org/pub/scm/virt/kvm/kvm.git linux-next
config: i386-randconfig-a006-20200828 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

   arch/x86/kvm/mmu/mmu.c: In function 'kvm_mmu_write_protect_largepage_masked':
>> arch/x86/kvm/mmu/mmu.c:1650:4: error: 'protectd' undeclared (first use in this function); did you mean 'protected'?
    1650 |    protectd |= __rmap_write_protect(kvm, rmap_head, false);
         |    ^~~~~~~~
         |    protected
   arch/x86/kvm/mmu/mmu.c:1650:4: note: each undeclared identifier is reported only once for each function it appears in
>> arch/x86/kvm/mmu/mmu.c:1641:7: warning: variable 'protected' set but not used [-Wunused-but-set-variable]
    1641 |  bool protected, all_protected;
         |       ^~~~~~~~~

# https://github.com/0day-ci/linux/commit/15b106ee1bd46b7f397218c23c63584ccad5dc3b
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Keqian-Zhu/KVM-x86-Support-write-protect-huge-pages-lazily/20200828-161514
git checkout 15b106ee1bd46b7f397218c23c63584ccad5dc3b
vim +1650 arch/x86/kvm/mmu/mmu.c

  1626	
  1627	/**
  1628	 * kvm_mmu_write_protect_largepage_masked - write protect selected largepages
  1629	 * @kvm: kvm instance
  1630	 * @slot: slot to protect
  1631	 * @gfn_offset: start of the BITS_PER_LONG pages we care about
  1632	 * @mask: indicates which pages we should protect
  1633	 *
  1634	 * @ret: true if all pages are write protected
  1635	 */
  1636	static bool kvm_mmu_write_protect_largepage_masked(struct kvm *kvm,
  1637					    struct kvm_memory_slot *slot,
  1638					    gfn_t gfn_offset, unsigned long mask)
  1639	{
  1640		struct kvm_rmap_head *rmap_head;
> 1641		bool protected, all_protected;
  1642		gfn_t start_gfn = slot->base_gfn + gfn_offset;
  1643		int i;
  1644	
  1645		all_protected = true;
  1646		while (mask) {
  1647			protected = false;
  1648			for (i = PG_LEVEL_2M; i <= KVM_MAX_HUGEPAGE_LEVEL; ++i) {
  1649				rmap_head = __gfn_to_rmap(start_gfn + __ffs(mask), i, slot);
> 1650				protectd |= __rmap_write_protect(kvm, rmap_head, false);
  1651			}
  1652	
  1653			all_protected &= protectd;
  1654			/* clear the first set bit */
  1655			mask &= mask - 1;
  1656		}
  1657	
  1658		return all_protected;
  1659	}
  1660	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 36826 bytes --]