From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 840B7C433E6 for ; Fri, 28 Aug 2020 22:50:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 59258208CA for ; Fri, 28 Aug 2020 22:50:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726748AbgH1WuE (ORCPT ); Fri, 28 Aug 2020 18:50:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:56736 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726928AbgH1Wt6 (ORCPT ); Fri, 28 Aug 2020 18:49:58 -0400 Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E6E44208A9; Fri, 28 Aug 2020 22:49:56 +0000 (UTC) Date: Fri, 28 Aug 2020 18:49:55 -0400 From: Steven Rostedt To: Wen Gong Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Andrew Morton , Alexei Starovoitov , linux-kernel-owner@vger.kernel.org, ath10k@lists.infradead.org, ath11k@lists.infradead.org, abhishekpandit@google.com, briannorris@google.com, drinkcat@google.com, tientzu@google.com Subject: Re: [for-next][PATCH 2/2] tracing: Use temp buffer when filtering events Message-ID: <20200828184955.6de9b54e@oasis.local.home> In-Reply-To: References: <20160504135202.422290539@goodmis.org> <20160504135241.308454993@goodmis.org> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 28 Aug 2020 15:53:06 +0800 Wen Gong wrote: > this patch commit id is : 0fc1b09ff1ff404ddf753f5ffa5cd0adc8fdcdc9 which > has upstream. > > how much size is the per cpu buffer? > seems it is initilized in trace_buffered_event_enable, > it is only 1 page size as below: > void trace_buffered_event_enable(void) > { > ... > for_each_tracing_cpu(cpu) { > page = alloc_pages_node(cpu_to_node(cpu), > GFP_KERNEL | __GFP_NORETRY, 0); > If the size of buffer to trace is more than 1 page, such as 46680, then > it trigger kernel crash/panic in my case while run trace-cmd. > After debugging, the trace_file->flags in > trace_event_buffer_lock_reserve is 0x40b while run trace-cmd, and it is > 0x403 while collecting ftrace log. > > Is it have any operation to disable this patch dynamically? It shouldn't be disabled, this is a bug that needs to be fixed. Also, if an event is more than a page, it wont be saved in the ftrace ring buffer, as events are limited by page size minus the headers. -- Steve From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Date: Fri, 28 Aug 2020 18:49:55 -0400 From: Steven Rostedt Subject: Re: [for-next][PATCH 2/2] tracing: Use temp buffer when filtering events Message-ID: <20200828184955.6de9b54e@oasis.local.home> In-Reply-To: References: <20160504135202.422290539@goodmis.org> <20160504135241.308454993@goodmis.org> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath11k" Errors-To: ath11k-bounces+kvalo=adurom.com@lists.infradead.org To: Wen Gong Cc: linux-kernel-owner@vger.kernel.org, tientzu@google.com, abhishekpandit@google.com, drinkcat@google.com, Alexei Starovoitov , ath10k@lists.infradead.org, linux-kernel@vger.kernel.org, ath11k@lists.infradead.org, briannorris@google.com, Andrew Morton , Ingo Molnar On Fri, 28 Aug 2020 15:53:06 +0800 Wen Gong wrote: > this patch commit id is : 0fc1b09ff1ff404ddf753f5ffa5cd0adc8fdcdc9 which > has upstream. > > how much size is the per cpu buffer? > seems it is initilized in trace_buffered_event_enable, > it is only 1 page size as below: > void trace_buffered_event_enable(void) > { > ... > for_each_tracing_cpu(cpu) { > page = alloc_pages_node(cpu_to_node(cpu), > GFP_KERNEL | __GFP_NORETRY, 0); > If the size of buffer to trace is more than 1 page, such as 46680, then > it trigger kernel crash/panic in my case while run trace-cmd. > After debugging, the trace_file->flags in > trace_event_buffer_lock_reserve is 0x40b while run trace-cmd, and it is > 0x403 while collecting ftrace log. > > Is it have any operation to disable this patch dynamically? It shouldn't be disabled, this is a bug that needs to be fixed. Also, if an event is more than a page, it wont be saved in the ftrace ring buffer, as events are limited by page size minus the headers. -- Steve -- ath11k mailing list ath11k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath11k From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Date: Fri, 28 Aug 2020 18:49:55 -0400 From: Steven Rostedt Subject: Re: [for-next][PATCH 2/2] tracing: Use temp buffer when filtering events Message-ID: <20200828184955.6de9b54e@oasis.local.home> In-Reply-To: References: <20160504135202.422290539@goodmis.org> <20160504135241.308454993@goodmis.org> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Wen Gong Cc: linux-kernel-owner@vger.kernel.org, tientzu@google.com, abhishekpandit@google.com, drinkcat@google.com, Alexei Starovoitov , ath10k@lists.infradead.org, linux-kernel@vger.kernel.org, ath11k@lists.infradead.org, briannorris@google.com, Andrew Morton , Ingo Molnar On Fri, 28 Aug 2020 15:53:06 +0800 Wen Gong wrote: > this patch commit id is : 0fc1b09ff1ff404ddf753f5ffa5cd0adc8fdcdc9 which > has upstream. > > how much size is the per cpu buffer? > seems it is initilized in trace_buffered_event_enable, > it is only 1 page size as below: > void trace_buffered_event_enable(void) > { > ... > for_each_tracing_cpu(cpu) { > page = alloc_pages_node(cpu_to_node(cpu), > GFP_KERNEL | __GFP_NORETRY, 0); > If the size of buffer to trace is more than 1 page, such as 46680, then > it trigger kernel crash/panic in my case while run trace-cmd. > After debugging, the trace_file->flags in > trace_event_buffer_lock_reserve is 0x40b while run trace-cmd, and it is > 0x403 while collecting ftrace log. > > Is it have any operation to disable this patch dynamically? It shouldn't be disabled, this is a bug that needs to be fixed. Also, if an event is more than a page, it wont be saved in the ftrace ring buffer, as events are limited by page size minus the headers. -- Steve _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k