From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05859C43461 for ; Sat, 29 Aug 2020 15:02:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CB34820EDD for ; Sat, 29 Aug 2020 15:02:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="ZH44e5BY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728146AbgH2PC3 (ORCPT ); Sat, 29 Aug 2020 11:02:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57658 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727772AbgH2PC3 (ORCPT ); Sat, 29 Aug 2020 11:02:29 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3D74C061236; Sat, 29 Aug 2020 08:02:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=d39SAF7s8f7x8GH2CWPNw/ILaZKmyMdbqFWhwl2+LCs=; b=ZH44e5BY2MtmgIjPdcAcIdaIuG zfEVVciaLe1Qx7dnPvqoozMtOR/geSvdpKnVHGxSw4OCNeRl1NH+lPPokB2G9dL/lyTQYaBVP+90G 0jncSypl+gJsj5cr41TTGUIAcBefNavmzH5n3pDoDKhjMhW8o5/e2xeqPYKlFTjO8UdytOVdo7o9Q UkFxf8ApBwKT/ssP+9OxuNkpEUixe5d0bw4EMDY/5R8CATcX+6bCz17YHze82TQOuvRKh2S+0DjYD PDm2GlmECVBHFEsbXDv+Adm9Yu2bZLll73UdTrLi9JMkDKgRjJPCuwrPZsnGk7ukdi3fykniJlVJE rNMf17Sw==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kC2N6-0003rR-1V; Sat, 29 Aug 2020 15:02:24 +0000 Date: Sat, 29 Aug 2020 16:02:23 +0100 From: Christoph Hellwig To: John Hubbard Cc: Andrew Morton , Alexander Viro , Christoph Hellwig , Ilya Dryomov , Jens Axboe , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, LKML Subject: Re: [PATCH v2 3/3] bio: convert get_user_pages_fast() --> pin_user_pages_fast() Message-ID: <20200829150223.GC12470@infradead.org> References: <20200829080853.20337-1-jhubbard@nvidia.com> <20200829080853.20337-4-jhubbard@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200829080853.20337-4-jhubbard@nvidia.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org > - size = iov_iter_get_pages(iter, pages, LONG_MAX, nr_pages, &offset); > + size = iov_iter_pin_user_pages(iter, pages, LONG_MAX, nr_pages, &offset); This is really a comment to the previous patch, but I only spotted it here: I think the right name is iov_iter_pin_pages, as bvec, kvec and pipe aren't usually user pages. Same as iov_iter_get_pages vs get_user_pages. Same for the _alloc variant. > + * here on. It will run one unpin_user_page() against each page > + * and will run one bio_put() against the BIO. Nit: the ant and the will still fit on the previous line.