From: kernel test robot <lkp@intel.com> To: "Stephan Müller" <smueller@chronox.de>, "Arnd Bergmann" <arnd@arndb.de> Cc: kbuild-all@lists.01.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-crypto@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>, linux-api@vger.kernel.org, "Eric W. Biederman" <ebiederm@xmission.com>, "Alexander E. Patrakov" <patrakov@gmail.com>, "Ahmed S. Darwish" <darwish.07@gmail.com>, "Theodore Y. Ts'o" <tytso@mit.edu>, Willy Tarreau <w@1wt.eu> Subject: Re: [PATCH v34 01/12] Linux Random Number Generator Date: Mon, 31 Aug 2020 17:24:47 +0800 [thread overview] Message-ID: <202008311731.jEh3WzsT%lkp@intel.com> (raw) In-Reply-To: <5695397.lOV4Wx5bFT@positron.chronox.de> [-- Attachment #1: Type: text/plain, Size: 4312 bytes --] Hi "Stephan, Thank you for the patch! Yet something to improve: [auto build test ERROR on char-misc/char-misc-testing] [also build test ERROR on cryptodev/master crypto/master v5.9-rc3 next-20200828] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Stephan-M-ller/dev-random-a-new-approach-with-full-SP800-90B-compliance/20200825-153914 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git d162219c655c8cf8003128a13840d6c1e183fb80 config: riscv-allmodconfig (attached as .config) compiler: riscv64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=riscv If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All errors (new ones prefixed by >>): In file included from drivers/char/lrng/lrng_pool.c:18: >> drivers/char/lrng/lrng_lfsr.h:44:4: error: 'latent_entropy' attribute only applies to functions and variables 44 | atomic_t pool[LRNG_POOL_SIZE] __latent_entropy; | ^~~~~~~~ -- In file included from drivers/char/lrng/lrng_chacha20.c:17: >> drivers/char/lrng/lrng_chacha20.h:17:2: error: 'latent_entropy' attribute only applies to functions and variables 17 | } key __latent_entropy; | ^ drivers/char/lrng/lrng_chacha20.h:19:2: error: 'latent_entropy' attribute only applies to functions and variables 19 | u32 nonce[3] __latent_entropy; | ^~~ # https://github.com/0day-ci/linux/commit/b5cc1c486b8491ab0a3817a48964bfd4797484c8 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Stephan-M-ller/dev-random-a-new-approach-with-full-SP800-90B-compliance/20200825-153914 git checkout b5cc1c486b8491ab0a3817a48964bfd4797484c8 vim +/latent_entropy +44 drivers/char/lrng/lrng_lfsr.h 16 17 /* 18 * This is the entropy pool used by the slow noise source. Its size should 19 * be at least as large as LRNG_DRNG_SECURITY_STRENGTH_BITS. 20 * 21 * The pool array is aligned to 8 bytes to comfort the kernel crypto API cipher 22 * implementations of the hash functions used to read the pool: for some 23 * accelerated implementations, we need an alignment to avoid a realignment 24 * which involves memcpy(). The alignment to 8 bytes should satisfy all crypto 25 * implementations. 26 * 27 * LRNG_POOL_SIZE is allowed to be changed only if the taps of the polynomial 28 * used for the LFSR are changed as well. The size must be in powers of 2 due 29 * to the mask handling in lrng_pool_lfsr_u32 which uses AND instead of modulo. 30 */ 31 struct lrng_pool { 32 union { 33 struct { 34 /* 35 * hash_df implementation: counter, requested_bits and 36 * pool form a linear buffer that is used in the 37 * hash_df function specified in SP800-90A section 38 * 10.3.1 39 */ 40 unsigned char counter; 41 __be32 requested_bits; 42 43 /* Pool */ > 44 atomic_t pool[LRNG_POOL_SIZE] __latent_entropy; 45 /* Ptr into pool for next IRQ word injection */ 46 atomic_t pool_ptr; 47 /* rotate for LFSR */ 48 atomic_t input_rotate; 49 /* All NUMA DRNGs seeded? */ 50 bool all_online_numa_node_seeded; 51 /* IRQ noise source status info */ 52 struct lrng_irq_info irq_info; 53 /* Serialize read of entropy pool */ 54 spinlock_t lock; 55 }; 56 /* 57 * Static SHA-1 implementation in lrng_cc20_hash_buffer 58 * processes data 64-byte-wise. Hence, ensure proper size 59 * of LRNG entropy pool data structure. 60 */ 61 u8 hash_input_buf[LRNG_POOL_SIZE_BYTES + 64]; 62 }; 63 }; 64 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 65991 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com> To: kbuild-all@lists.01.org Subject: Re: [PATCH v34 01/12] Linux Random Number Generator Date: Mon, 31 Aug 2020 17:24:47 +0800 [thread overview] Message-ID: <202008311731.jEh3WzsT%lkp@intel.com> (raw) In-Reply-To: <5695397.lOV4Wx5bFT@positron.chronox.de> [-- Attachment #1: Type: text/plain, Size: 4411 bytes --] Hi "Stephan, Thank you for the patch! Yet something to improve: [auto build test ERROR on char-misc/char-misc-testing] [also build test ERROR on cryptodev/master crypto/master v5.9-rc3 next-20200828] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Stephan-M-ller/dev-random-a-new-approach-with-full-SP800-90B-compliance/20200825-153914 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git d162219c655c8cf8003128a13840d6c1e183fb80 config: riscv-allmodconfig (attached as .config) compiler: riscv64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=riscv If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All errors (new ones prefixed by >>): In file included from drivers/char/lrng/lrng_pool.c:18: >> drivers/char/lrng/lrng_lfsr.h:44:4: error: 'latent_entropy' attribute only applies to functions and variables 44 | atomic_t pool[LRNG_POOL_SIZE] __latent_entropy; | ^~~~~~~~ -- In file included from drivers/char/lrng/lrng_chacha20.c:17: >> drivers/char/lrng/lrng_chacha20.h:17:2: error: 'latent_entropy' attribute only applies to functions and variables 17 | } key __latent_entropy; | ^ drivers/char/lrng/lrng_chacha20.h:19:2: error: 'latent_entropy' attribute only applies to functions and variables 19 | u32 nonce[3] __latent_entropy; | ^~~ # https://github.com/0day-ci/linux/commit/b5cc1c486b8491ab0a3817a48964bfd4797484c8 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Stephan-M-ller/dev-random-a-new-approach-with-full-SP800-90B-compliance/20200825-153914 git checkout b5cc1c486b8491ab0a3817a48964bfd4797484c8 vim +/latent_entropy +44 drivers/char/lrng/lrng_lfsr.h 16 17 /* 18 * This is the entropy pool used by the slow noise source. Its size should 19 * be at least as large as LRNG_DRNG_SECURITY_STRENGTH_BITS. 20 * 21 * The pool array is aligned to 8 bytes to comfort the kernel crypto API cipher 22 * implementations of the hash functions used to read the pool: for some 23 * accelerated implementations, we need an alignment to avoid a realignment 24 * which involves memcpy(). The alignment to 8 bytes should satisfy all crypto 25 * implementations. 26 * 27 * LRNG_POOL_SIZE is allowed to be changed only if the taps of the polynomial 28 * used for the LFSR are changed as well. The size must be in powers of 2 due 29 * to the mask handling in lrng_pool_lfsr_u32 which uses AND instead of modulo. 30 */ 31 struct lrng_pool { 32 union { 33 struct { 34 /* 35 * hash_df implementation: counter, requested_bits and 36 * pool form a linear buffer that is used in the 37 * hash_df function specified in SP800-90A section 38 * 10.3.1 39 */ 40 unsigned char counter; 41 __be32 requested_bits; 42 43 /* Pool */ > 44 atomic_t pool[LRNG_POOL_SIZE] __latent_entropy; 45 /* Ptr into pool for next IRQ word injection */ 46 atomic_t pool_ptr; 47 /* rotate for LFSR */ 48 atomic_t input_rotate; 49 /* All NUMA DRNGs seeded? */ 50 bool all_online_numa_node_seeded; 51 /* IRQ noise source status info */ 52 struct lrng_irq_info irq_info; 53 /* Serialize read of entropy pool */ 54 spinlock_t lock; 55 }; 56 /* 57 * Static SHA-1 implementation in lrng_cc20_hash_buffer 58 * processes data 64-byte-wise. Hence, ensure proper size 59 * of LRNG entropy pool data structure. 60 */ 61 u8 hash_input_buf[LRNG_POOL_SIZE_BYTES + 64]; 62 }; 63 }; 64 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org [-- Attachment #2: config.gz --] [-- Type: application/gzip, Size: 65991 bytes --]
next prev parent reply other threads:[~2020-08-31 9:25 UTC|newest] Thread overview: 91+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-20 8:25 [PATCH v32 00/12] /dev/random - a new approach with full SP800-90B compliance Stephan Müller 2020-08-20 8:39 ` [PATCH v32 01/12] Linux Random Number Generator Stephan Müller 2020-08-20 11:46 ` kernel test robot 2020-08-20 11:46 ` kernel test robot 2020-08-20 12:31 ` Stephan Müller 2020-08-20 12:31 ` Stephan Müller 2020-08-20 8:40 ` [PATCH v32 02/12] LRNG - allocate one DRNG instance per NUMA node Stephan Müller 2020-08-20 8:40 ` [PATCH v32 03/12] LRNG - sysctls and /proc interface Stephan Müller 2020-08-20 8:41 ` [PATCH v32 04/12] LRNG - add switchable DRNG support Stephan Müller 2020-08-20 8:42 ` [PATCH v32 05/12] crypto: DRBG - externalize DRBG functions for LRNG Stephan Müller 2020-08-20 8:42 ` [PATCH v32 06/12] LRNG - add SP800-90A DRBG extension Stephan Müller 2020-08-20 12:07 ` kernel test robot 2020-08-20 12:07 ` kernel test robot 2020-08-20 12:27 ` Stephan Müller 2020-08-20 12:27 ` Stephan Müller 2020-08-20 8:43 ` [PATCH v32 07/12] LRNG - add kernel crypto API PRNG extension Stephan Müller 2020-08-20 12:32 ` kernel test robot 2020-08-20 12:32 ` kernel test robot 2020-08-20 8:43 ` [PATCH v32 08/12] crypto: provide access to a static Jitter RNG state Stephan Müller 2020-08-20 8:44 ` [PATCH v32 09/12] LRNG - add Jitter RNG fast noise source Stephan Müller 2020-08-20 8:44 ` [PATCH v32 10/12] LRNG - add SP800-90B compliant health tests Stephan Müller 2020-08-20 8:45 ` [PATCH v32 11/12] LRNG - add interface for gathering of raw entropy Stephan Müller 2020-08-20 12:47 ` kernel test robot 2020-08-20 12:47 ` kernel test robot 2020-08-20 8:45 ` [PATCH v32 12/12] LRNG - add power-on and runtime self-tests Stephan Müller 2020-08-21 5:37 ` [PATCH v33 00/12] /dev/random - a new approach with full SP800-90B compliance Stephan Müller 2020-08-21 5:38 ` [PATCH v33 01/12] Linux Random Number Generator Stephan Müller 2020-08-21 19:42 ` kernel test robot 2020-08-21 19:42 ` kernel test robot 2020-08-22 4:49 ` Stephan Müller 2020-08-22 4:49 ` Stephan Müller 2020-08-22 3:34 ` kernel test robot 2020-08-22 3:34 ` kernel test robot 2020-08-26 14:27 ` kernel test robot 2020-08-26 14:27 ` kernel test robot 2020-08-26 14:22 ` Stephan Mueller 2020-08-26 14:22 ` Stephan Mueller 2020-08-21 5:39 ` [PATCH v33 02/12] LRNG - allocate one DRNG instance per NUMA node Stephan Müller 2020-08-21 5:39 ` [PATCH v33 03/12] LRNG - sysctls and /proc interface Stephan Müller 2020-08-23 7:10 ` kernel test robot 2020-08-23 7:10 ` kernel test robot 2020-08-21 5:40 ` [PATCH v33 04/12] LRNG - add switchable DRNG support Stephan Müller 2020-08-21 5:40 ` [PATCH v33 05/12] crypto: DRBG - externalize DRBG functions for LRNG Stephan Müller 2020-08-21 5:41 ` [PATCH v33 06/12] LRNG - add SP800-90A DRBG extension Stephan Müller 2020-08-21 5:42 ` [PATCH v33 07/12] LRNG - add kernel crypto API PRNG extension Stephan Müller 2020-08-21 5:42 ` [PATCH v33 08/12] crypto: provide access to a static Jitter RNG state Stephan Müller 2020-08-21 5:42 ` [PATCH v33 09/12] LRNG - add Jitter RNG fast noise source Stephan Müller 2020-08-21 5:43 ` [PATCH v33 10/12] LRNG - add SP800-90B compliant health tests Stephan Müller 2020-08-21 5:43 ` [PATCH v33 11/12] LRNG - add interface for gathering of raw entropy Stephan Müller 2020-08-21 5:44 ` [PATCH v33 12/12] LRNG - add power-on and runtime self-tests Stephan Müller 2020-08-23 14:50 ` kernel test robot 2020-08-23 14:50 ` kernel test robot 2020-08-25 7:21 ` [PATCH v34 00/12] /dev/random - a new approach with full SP800-90B compliance Stephan Müller 2020-08-25 7:22 ` [PATCH v34 01/12] Linux Random Number Generator Stephan Müller 2020-08-25 11:28 ` kernel test robot 2020-08-25 11:28 ` kernel test robot 2020-08-25 11:51 ` Stephan Mueller 2020-08-25 11:51 ` Stephan Mueller 2020-08-31 9:24 ` kernel test robot [this message] 2020-08-31 9:24 ` kernel test robot 2020-08-25 7:23 ` [PATCH v34 02/12] LRNG - allocate one DRNG instance per NUMA node Stephan Müller 2020-08-25 7:23 ` [PATCH v34 03/12] LRNG - sysctls and /proc interface Stephan Müller 2020-08-25 7:24 ` [PATCH v34 04/12] LRNG - add switchable DRNG support Stephan Müller 2020-08-31 10:03 ` kernel test robot 2020-08-31 10:03 ` kernel test robot 2020-08-25 7:24 ` [PATCH v34 05/12] crypto: DRBG - externalize DRBG functions for LRNG Stephan Müller 2020-08-25 7:25 ` [PATCH v34 06/12] LRNG - add SP800-90A DRBG extension Stephan Müller 2020-08-25 7:25 ` [PATCH v34 07/12] LRNG - add kernel crypto API PRNG extension Stephan Müller 2020-08-25 7:26 ` [PATCH v34 08/12] crypto: provide access to a static Jitter RNG state Stephan Müller 2020-08-25 7:26 ` [PATCH v34 09/12] LRNG - add Jitter RNG fast noise source Stephan Müller 2020-08-25 7:27 ` [PATCH v34 10/12] LRNG - add SP800-90B compliant health tests Stephan Müller 2020-08-25 7:27 ` [PATCH v34 11/12] LRNG - add interface for gathering of raw entropy Stephan Müller 2020-08-25 7:27 ` [PATCH v34 12/12] LRNG - add power-on and runtime self-tests Stephan Müller 2020-09-18 9:47 ` [PATCH v35 00/13] /dev/random - a new approach Stephan Müller 2020-09-18 9:48 ` [PATCH v35 01/13] Linux Random Number Generator Stephan Müller 2020-09-18 13:02 ` kernel test robot 2020-09-18 13:02 ` kernel test robot 2020-09-20 16:49 ` Stephan Mueller 2020-09-20 16:49 ` Stephan Mueller 2020-09-18 9:48 ` [PATCH v35 02/13] LRNG - allocate one DRNG instance per NUMA node Stephan Müller 2020-09-18 9:49 ` [PATCH v35 03/13] LRNG - sysctls and /proc interface Stephan Müller 2020-09-18 9:49 ` [PATCH v35 04/13] LRNG - add switchable DRNG support Stephan Müller 2020-09-18 9:49 ` [PATCH v35 05/13] LRNG - add common generic hash support Stephan Müller 2020-09-18 9:50 ` [PATCH v35 06/13] crypto: DRBG - externalize DRBG functions for LRNG Stephan Müller 2020-09-18 9:50 ` [PATCH v35 07/13] LRNG - add SP800-90A DRBG extension Stephan Müller 2020-09-18 9:51 ` [PATCH v35 08/13] LRNG - add kernel crypto API PRNG extension Stephan Müller 2020-09-18 9:51 ` [PATCH v35 09/13] crypto: provide access to a static Jitter RNG state Stephan Müller 2020-09-18 9:51 ` [PATCH v35 10/13] LRNG - add Jitter RNG fast noise source Stephan Müller 2020-09-18 9:52 ` [PATCH v35 11/13] LRNG - add SP800-90B compliant health tests Stephan Müller 2020-09-18 9:53 ` [PATCH v35 12/13] LRNG - add interface for gathering of raw entropy Stephan Müller 2020-09-18 9:53 ` [PATCH v35 13/13] LRNG - add power-on and runtime self-tests Stephan Müller
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=202008311731.jEh3WzsT%lkp@intel.com \ --to=lkp@intel.com \ --cc=arnd@arndb.de \ --cc=darwish.07@gmail.com \ --cc=ebiederm@xmission.com \ --cc=gregkh@linuxfoundation.org \ --cc=kbuild-all@lists.01.org \ --cc=linux-api@vger.kernel.org \ --cc=linux-crypto@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=patrakov@gmail.com \ --cc=smueller@chronox.de \ --cc=tytso@mit.edu \ --cc=w@1wt.eu \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.