From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============6845231663907867388==" MIME-Version: 1.0 From: kernel test robot Subject: [PATCH] coccinelle: api: fix kobj_to_dev.cocci warnings Date: Tue, 01 Sep 2020 17:46:08 +0800 Message-ID: <20200901094608.GA29330@e18970f1e570> In-Reply-To: <202009011711.D4mNHDQW%lkp@intel.com> List-Id: To: kbuild@lists.01.org --===============6845231663907867388== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable CC: kbuild-all(a)lists.01.org TO: Denis Efremov CC: Julia Lawall CC: Srinivas Kandagatla CC: linux-kernel(a)vger.kernel.org From: kernel test robot drivers/nvmem/core.c:131:46-47: WARNING opportunity for kobj_to_dev() drivers/nvmem/core.c:171:46-47: WARNING opportunity for kobj_to_dev() drivers/nvmem/core.c:222:60-61: WARNING opportunity for kobj_to_dev() Use kobj_to_dev() instead of container_of() Generated by: scripts/coccinelle/api/kobj_to_dev.cocci Fixes: a2fc3718bc22 ("coccinelle: api: add kobj_to_dev.cocci script") CC: Denis Efremov Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/jlawall/linux.git f= or-5.10 head: ea3047aac79bc12dfda32fd676d6d1b2a6e5475d commit: a2fc3718bc22e85378085568ecc5765fb28cabce [3/4] coccinelle: api: add= kobj_to_dev.cocci script :::::: branch date: 3 days ago :::::: commit date: 11 days ago Please take the patch only if it's a positive warning. Thanks! core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- a/drivers/nvmem/core.c +++ b/drivers/nvmem/core.c @@ -128,7 +128,7 @@ static ssize_t bin_attr_nvmem_read(struc if (attr->private) dev =3D attr->private; else - dev =3D container_of(kobj, struct device, kobj); + dev =3D kobj_to_dev(kobj); nvmem =3D to_nvmem_device(dev); = /* Stop the user from reading */ @@ -168,7 +168,7 @@ static ssize_t bin_attr_nvmem_write(stru if (attr->private) dev =3D attr->private; else - dev =3D container_of(kobj, struct device, kobj); + dev =3D kobj_to_dev(kobj); nvmem =3D to_nvmem_device(dev); = /* Stop the user from writing */ @@ -219,7 +219,7 @@ static umode_t nvmem_bin_attr_get_umode( static umode_t nvmem_bin_attr_is_visible(struct kobject *kobj, struct bin_attribute *attr, int i) { - struct device *dev =3D container_of(kobj, struct device, kobj); + struct device *dev =3D kobj_to_dev(kobj); struct nvmem_device *nvmem =3D to_nvmem_device(dev); = return nvmem_bin_attr_get_umode(nvmem); --===============6845231663907867388==--