All of lore.kernel.org
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Linux Crypto Mailing List <linux-crypto@vger.kernel.org>
Subject: Re: [PATCH 1/2] crypto: arm/aes-neonbs - Use generic cbc encryption path
Date: Tue, 1 Sep 2020 21:45:43 +1000	[thread overview]
Message-ID: <20200901114542.GA2441@gondor.apana.org.au> (raw)
In-Reply-To: <CAMj1kXGDPTbhs_2FkvHROMmp+j7eON43r8muWgMGJpFQKpTjSw@mail.gmail.com>

On Tue, Sep 01, 2020 at 11:47:03AM +0300, Ard Biesheuvel wrote:
> On Tue, 1 Sep 2020 at 09:28, Herbert Xu <herbert@gondor.apana.org.au> wrote:
> >
> > Since commit b56f5cbc7e08ec7d31c42fc41e5247677f20b143 ("crypto:
> > arm/aes-neonbs - resolve fallback cipher at runtime") the CBC
> > encryption path in aes-neonbs is now identical to that obtained
> > through the cbc template.  This means that it can simply call
> > the generic cbc template instead of doing its own thing.
> >
> > This patch removes the custom encryption path and simply invokes
> > the generic cbc template.
> >
> > Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
> >
> 
> Aren't we ending up with a cbc(aes) implementation that allocates a
> cbc(aes) implementation as a fallback?

Good catch, I meant to make the fallback sync only.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

  reply	other threads:[~2020-09-01 14:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-01  6:28 [PATCH 1/2] crypto: arm/aes-neonbs - Use generic cbc encryption path Herbert Xu
2020-09-01  6:31 ` [PATCH 2/2] crypto: cbc - Remove cbc.h Herbert Xu
2020-09-01  8:47 ` [PATCH 1/2] crypto: arm/aes-neonbs - Use generic cbc encryption path Ard Biesheuvel
2020-09-01 11:45   ` Herbert Xu [this message]
2020-09-01 11:48     ` [v2 PATCH " Herbert Xu
2020-09-01 11:49       ` [v2 PATCH 2/2] crypto: cbc - Remove cbc.h Herbert Xu
2020-09-01 12:15       ` [v2 PATCH 1/2] crypto: arm/aes-neonbs - Use generic cbc encryption path Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200901114542.GA2441@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=ardb@kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.