From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: qemu-devel@nongnu.org
Cc: "Prasad J Pandit" <pjp@fedoraproject.org>,
qemu-block@nongnu.org, "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Alexander Bulekov" <alxndr@bu.edu>,
bugs-syssec@rub.de, "Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [PATCH 1/3] hw/sd/sdhci: Fix qemu_log_mask() format string
Date: Tue, 1 Sep 2020 16:01:25 +0200 [thread overview]
Message-ID: <20200901140127.111454-2-f4bug@amsat.org> (raw)
In-Reply-To: <20200901140127.111454-1-f4bug@amsat.org>
Add missing newline character in qemu_log_mask() format.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
hw/sd/sdhci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c
index 1785d7e1f79..e2ef288052e 100644
--- a/hw/sd/sdhci.c
+++ b/hw/sd/sdhci.c
@@ -1109,7 +1109,7 @@ sdhci_write(void *opaque, hwaddr offset, uint64_t val, unsigned size)
/* Limit block size to the maximum buffer size */
if (extract32(s->blksize, 0, 12) > s->buf_maxsz) {
qemu_log_mask(LOG_GUEST_ERROR, "%s: Size 0x%x is larger than "
- "the maximum buffer 0x%x", __func__, s->blksize,
+ "the maximum buffer 0x%x\n", __func__, s->blksize,
s->buf_maxsz);
s->blksize = deposit32(s->blksize, 0, 12, s->buf_maxsz);
--
2.26.2
next prev parent reply other threads:[~2020-09-01 14:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 14:01 [PATCH 0/3] hw/sd/sdhci: Fix DMA Transfer Block Size field width Philippe Mathieu-Daudé
2020-09-01 14:01 ` Philippe Mathieu-Daudé [this message]
2020-09-01 14:01 ` [PATCH 2/3] hw/sd/sdhci: Document the datasheet used Philippe Mathieu-Daudé
2020-09-01 14:01 ` [PATCH 3/3] hw/sd/sdhci: Fix DMA Transfer Block Size field Philippe Mathieu-Daudé
2020-09-01 14:01 ` [Bug 1892960] " Philippe Mathieu-Daudé
2020-09-01 14:03 ` Philippe Mathieu-Daudé
2020-09-01 14:03 ` [Bug 1892960] " Philippe Mathieu-Daudé
-- strict thread matches above, loose matches on Subject: below --
2020-09-01 14:04 [PATCH v2 0/3] hw/sd/sdhci: Fix DMA Transfer Block Size field width Philippe Mathieu-Daudé
2020-09-01 14:04 ` [PATCH v2 1/3] hw/sd/sdhci: Fix qemu_log_mask() format string Philippe Mathieu-Daudé
2020-09-01 17:51 ` Richard Henderson
2020-09-01 14:04 ` [PATCH v2 2/3] hw/sd/sdhci: Document the datasheet used Philippe Mathieu-Daudé
2020-09-01 17:51 ` Richard Henderson
2020-09-01 14:04 ` [PATCH v2 3/3] hw/sd/sdhci: Fix DMA Transfer Block Size field Philippe Mathieu-Daudé
2020-09-01 14:04 ` [Bug 1892960] " Philippe Mathieu-Daudé
2020-09-02 10:39 ` P J P
2020-09-10 14:49 ` [PATCH v2 0/3] hw/sd/sdhci: Fix DMA Transfer Block Size field width Alexander Bulekov
2020-09-18 8:27 ` Philippe Mathieu-Daudé
2020-08-26 1:25 [Bug 1892960] [NEW] Heap-overflow in flatview_read through sdhci_data_transfer Alexander Bulekov
2020-09-01 12:01 ` [Bug 1892960] " P J P
2020-10-22 14:00 ` Philippe Mathieu-Daudé
2020-12-10 9:04 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200901140127.111454-2-f4bug@amsat.org \
--to=f4bug@amsat.org \
--cc=alxndr@bu.edu \
--cc=bugs-syssec@rub.de \
--cc=philmd@redhat.com \
--cc=pjp@fedoraproject.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.