From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1kDGF2-0003NQ-Kh for mharc-grub-devel@gnu.org; Tue, 01 Sep 2020 20:03:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58152) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kDGF1-0003NI-0U for grub-devel@gnu.org; Tue, 01 Sep 2020 20:03:07 -0400 Received: from mail-ot1-x343.google.com ([2607:f8b0:4864:20::343]:36949) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kDGDQ-0002xt-Ce for grub-devel@gnu.org; Tue, 01 Sep 2020 20:03:06 -0400 Received: by mail-ot1-x343.google.com with SMTP id 37so2761124oto.4 for ; Tue, 01 Sep 2020 17:01:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficientek-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references:reply-to :mime-version:content-transfer-encoding; bh=d8olN4C4p1dfVNCzIKJJ6d+Z1tkyF9IiwOktSP+51fU=; b=Zb0LNv64KS4K1qAJ6ZzUV0iF8YK2SfDGVSVr93O9Er+Mvlfll7jca0GYjUwPabLmEm kEURr+Q9331Gc4wfmJClwVNCZ9b0pHP9tRyvnqtjmhPp/9yPLy77Drbg9Xb7Xnu9nT7v H+AceR6QFGf1R90EJaEdQYrhLIME6TZOyM/0qYq2abQ3mu96OWpmwOxvzOKVVHWarNU/ 6fRDMqC4J/fOTYtvs2gDtAVVca6gwmmxvxLheaWl1Jauu3SwlT4cTSJxH8vwAnmJ17oD Gh/+l9EsZ3M0XRjQ62mwSS5o+kXgFmxy/2ffhJChoa0e4NTd9eQtjptbU0cu4docc6rC ymgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:reply-to:mime-version:content-transfer-encoding; bh=d8olN4C4p1dfVNCzIKJJ6d+Z1tkyF9IiwOktSP+51fU=; b=OQHXw33e4ebdb3E1Na/4DUJA9TMKxNTjyIVjNrruzorRQU3JjZxRUpKQEJS5NK5xIa yDjBi7QwdFwvQs9GJIqmATA6aSWgxrwiTFLEnhYo2O0cy/TX8+bvqFm6954ql/PamBDo Ykw1L2d+M6W4TinfnfZQnL5eyFWF8R/TLc4Un6DYXGotv/qwfhreYu+mmxZYSu+sn3CQ QVrRcvxAqzuJJa61aeb1nfQmuvccMs8q2WuJXGGo4aO3qQ8qQk2Dj2zjH4qJszqEwcQM fzuJeoQWPEMwYIeon8lz+NQ3DIJD+SywrUiFDzBKE6VWXTQrZKHeC0pprXXiirX4mEDd z1hA== X-Gm-Message-State: AOAM533+seaZHqB7qoxEElUHHo8CRFFPz4F9kkCRzIvOObcZlmkzPwf0 /WhgANn11r1G7uNvOTrg/GHBkSYk8shASA== X-Google-Smtp-Source: ABdhPJzE/L2v4gSj/cqporPlhgUQsPxVgvwayMie1qvfpntn4s75Bs321lRapfgagaXV7iHWWTFfBw== X-Received: by 2002:a9d:23c7:: with SMTP id t65mr3232559otb.275.1599004886256; Tue, 01 Sep 2020 17:01:26 -0700 (PDT) Received: from crass-HP-ZBook-15-G2 ([2605:a601:aaec:9b00:2c09:4e39:9491:777d]) by smtp.gmail.com with ESMTPSA id j20sm463251ots.5.2020.09.01.17.01.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2020 17:01:26 -0700 (PDT) Date: Tue, 1 Sep 2020 19:01:24 -0500 From: Glenn Washburn To: grub-devel@gnu.org Cc: Patrick Steinhardt Subject: Re: [PATCH] cryptodisk: Properly handle non-512 byte sized sectors. Message-ID: <20200901190124.7460ac57@crass-HP-ZBook-15-G2> In-Reply-To: <20200901232100.510456-1-development@efficientek.com> References: <20200901232100.510456-1-development@efficientek.com> Reply-To: development@efficientek.com X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::343; envelope-from=development@efficientek.com; helo=mail-ot1-x343.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Sep 2020 00:03:07 -0000 The main difference with this patch is that sector_size is renamed to log_sector_size, grub has enough inaccurate or misleading names. Additionally, rename LOG_SECTOR_SIZE to LUKS_LOG_SECTOR_SIZE and CRYPT_LOG_SECTOR_SIZE to GRUB_CRYPTODISK_IV_LOG_SIZE and moved to cryptodisk.h. Also a comment was reworded for clarity. Glenn