Hi Kurt, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on robh/for-next] [also build test WARNING on net-next/master net/master linus/master v5.9-rc3 next-20200828] [cannot apply to sparc-next/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Kurt-Kanzenbach/Hirschmann-Hellcreek-DSA-driver/20200901-205620 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next config: sh-allmodconfig (attached as .config) compiler: sh4-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/net/dsa/hirschmann/hellcreek.c:1147:1: warning: 'static' is not at beginning of declaration [-Wold-style-declaration] 1147 | const static struct hellcreek_platform_data de1soc_r1_pdata = { | ^~~~~ # https://github.com/0day-ci/linux/commit/a0634aaa91ab02823fa311b9cf33e3872207bb60 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Kurt-Kanzenbach/Hirschmann-Hellcreek-DSA-driver/20200901-205620 git checkout a0634aaa91ab02823fa311b9cf33e3872207bb60 vim +/static +1147 drivers/net/dsa/hirschmann/hellcreek.c 1146 > 1147 const static struct hellcreek_platform_data de1soc_r1_pdata = { 1148 .num_ports = 4, 1149 .is_100_mbits = 1, 1150 .qbv_support = 1, 1151 .qbv_on_cpu = 1, 1152 .module_id = 0x4c30, 1153 }; 1154 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org