From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 277F0C433E2 for ; Wed, 2 Sep 2020 02:54:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 057B92087D for ; Wed, 2 Sep 2020 02:54:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Mmg3k909" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726301AbgIBCy0 (ORCPT ); Tue, 1 Sep 2020 22:54:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46942 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726311AbgIBCx7 (ORCPT ); Tue, 1 Sep 2020 22:53:59 -0400 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5934BC06125F for ; Tue, 1 Sep 2020 19:53:54 -0700 (PDT) Received: by mail-pf1-x443.google.com with SMTP id o20so2008022pfp.11 for ; Tue, 01 Sep 2020 19:53:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HVX5iGApWsA6cOcKpocM02MsLs3Cms0hUFmAcEqMm6M=; b=Mmg3k909Im5tPr616qMO7eR07LAJFZClo5qultGvx7lHP5OI+oj6Z0PZ+3rp3MvDA3 EKIdRq33UoHLNu/CJNmyG2b1rFixQhYPrXAA7dqL2iwb7efBZBRwDdWCR5SgWF4hYhHi lpG+N67GmcyXWCsOwQrq7S6QnuK7PbTqvLQO8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HVX5iGApWsA6cOcKpocM02MsLs3Cms0hUFmAcEqMm6M=; b=OlhaV4gkUmYR/LmzoPYtXdwEi593QSt3baVb706PA3tRrxMmC9sDgL84vNG+Bpbz/R +KWslfo9m9C/evZ1OIZFEWB84NA+lMPPTxBL5xW23b5hO1EfI95VwQ+ijnXvzH3aD8eZ Q2IzF/EPUg00YG8rK9ZHPmHlNK8Po75SH1lMf5Izz871pm6brc3h9tdLLuG5w26lHaeU K/+nVXlRgo7Nrx7poWDPoHvttaXUcmQm0knd4/j/Hd0RddKBlUI575yg3BK0jgiCThgi 2aeTu/Zcu7b2S2J03h+6ZesvzCpTI4y36SwzyWY9eSBoozCVkXqBLbn2UfRnBwCBNzZn yvTQ== X-Gm-Message-State: AOAM5301uVOMBxZXXa8NCK+/K0SqB1+ocJItVptPKjaI2aUS5PZFdEHl Vl5wcda8ADx2iSV3mdYXOs6WAQ== X-Google-Smtp-Source: ABdhPJxr15UxFlZO57N08QLgROI0XgkvScTspshNJ0zdFmYYhSNaiyEAMbuocRhYqDliU1QV3ZPnLQ== X-Received: by 2002:a63:6d41:: with SMTP id i62mr199101pgc.279.1599015233901; Tue, 01 Sep 2020 19:53:53 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id q7sm3438860pgg.10.2020.09.01.19.53.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2020 19:53:50 -0700 (PDT) From: Kees Cook To: Ingo Molnar Cc: Kees Cook , Will Deacon , Borislav Petkov , Catalin Marinas , Mark Rutland , Ard Biesheuvel , Peter Collingbourne , James Morse , Ingo Molnar , Russell King , Masahiro Yamada , Arvind Sankar , Nick Desaulniers , Nathan Chancellor , Arnd Bergmann , x86@kernel.org, clang-built-linux@googlegroups.com, linux-arch@vger.kernel.org, linux-efi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v7 1/5] arm64/build: Warn on orphan section placement Date: Tue, 1 Sep 2020 19:53:43 -0700 Message-Id: <20200902025347.2504702-2-keescook@chromium.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200902025347.2504702-1-keescook@chromium.org> References: <20200902025347.2504702-1-keescook@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We don't want to depend on the linker's orphan section placement heuristics as these can vary between linkers, and may change between versions. All sections need to be explicitly handled in the linker script. With all sections now handled, enable orphan section warnings. Acked-by: Will Deacon Signed-off-by: Kees Cook --- arch/arm64/Makefile | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile index 6de7f551b821..081144fcc3da 100644 --- a/arch/arm64/Makefile +++ b/arch/arm64/Makefile @@ -29,6 +29,10 @@ LDFLAGS_vmlinux += --fix-cortex-a53-843419 endif endif +# We never want expected sections to be placed heuristically by the +# linker. All sections should be explicitly named in the linker script. +LDFLAGS_vmlinux += $(call ld-option, --orphan-handling=warn) + ifeq ($(CONFIG_ARM64_USE_LSE_ATOMICS), y) ifneq ($(CONFIG_ARM64_LSE_ATOMICS), y) $(warning LSE atomics not supported by binutils) -- 2.25.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FF85C433E2 for ; Wed, 2 Sep 2020 02:55:34 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 08BC5206CD for ; Wed, 2 Sep 2020 02:55:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uOaTZfu6"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Mmg3k909" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 08BC5206CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/nUpx2Zs2or78oyu/z+nZEa3UqSN9l6CTgRzgg9vzEw=; b=uOaTZfu6SvIAL0RmPYVloVFkz MhGeY1KFLGzTi4sMfo0zh1mPimYne9KOr55FZfdvUrVg+aC2OD3hazQ4KZjFjpWV8U4tj8siJfONl o7kx+HDdB/lY2RlHbibyzfELeEHmAnYTkqwkJKrpxcpS0sug9DlUCtR4sB6sh9x8a9Po9C1NvLPWr 1R/s6KYNQuIIijqLYZhudCNFO8GVq/A2sa9VcoiKyKtKJcJexO4idWpfi9tSTX65wHA6RbRSUzQJe rNU9fIlnKCzA+AdpQtzbKJYZN1hmM0OUm9F/cvvSImH3KpEJGi4PNDX/n8u53ZqYzydZ4dgsTMqQz YzR/0jFMw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDIuT-0003aL-DX; Wed, 02 Sep 2020 02:54:05 +0000 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDIuJ-0003VA-V9 for linux-arm-kernel@lists.infradead.org; Wed, 02 Sep 2020 02:53:57 +0000 Received: by mail-pg1-x541.google.com with SMTP id p37so1791748pgl.3 for ; Tue, 01 Sep 2020 19:53:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HVX5iGApWsA6cOcKpocM02MsLs3Cms0hUFmAcEqMm6M=; b=Mmg3k909Im5tPr616qMO7eR07LAJFZClo5qultGvx7lHP5OI+oj6Z0PZ+3rp3MvDA3 EKIdRq33UoHLNu/CJNmyG2b1rFixQhYPrXAA7dqL2iwb7efBZBRwDdWCR5SgWF4hYhHi lpG+N67GmcyXWCsOwQrq7S6QnuK7PbTqvLQO8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HVX5iGApWsA6cOcKpocM02MsLs3Cms0hUFmAcEqMm6M=; b=p8wtTH9g5uwjtT4Avuma1sLWKma8Bx7Dq3u/UaffwH1YTLh1RZvS/Ge7hXzB7b/dX0 /8IKp/UV1OZj3NJ3kyj8ecx4TIIkP82tklum5W9uglGZR+nWFvGqREQ92VqlpnEQ5kEe LtAAzxEiCsHF33MQkQDf6W/o0umiVvOtHHvzqUDa9p1TZg7AOcmXNJ08C5qjTyVGiL1+ CEdMkKQKgsIgXVQ6qKO0D47MshVVB5scDQxqelA0+DkUre7oq1SI11xG5v26Tyvu3f0i GqA8yYWdn/HaQAPO/YzcqWUtgNccFZc0fyaR9g58imXOFF7+YnIbuo9W2vwqCftsjSiB 6EpQ== X-Gm-Message-State: AOAM532tbTx5/4E3+pwDicQKm5oc8UtgWaHXMFID6MfnaGR8WyHIzZD1 ThqEDI4hRAnuogSqZHC0GtMi4Q== X-Google-Smtp-Source: ABdhPJxr15UxFlZO57N08QLgROI0XgkvScTspshNJ0zdFmYYhSNaiyEAMbuocRhYqDliU1QV3ZPnLQ== X-Received: by 2002:a63:6d41:: with SMTP id i62mr199101pgc.279.1599015233901; Tue, 01 Sep 2020 19:53:53 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id q7sm3438860pgg.10.2020.09.01.19.53.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2020 19:53:50 -0700 (PDT) From: Kees Cook To: Ingo Molnar Subject: [PATCH v7 1/5] arm64/build: Warn on orphan section placement Date: Tue, 1 Sep 2020 19:53:43 -0700 Message-Id: <20200902025347.2504702-2-keescook@chromium.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200902025347.2504702-1-keescook@chromium.org> References: <20200902025347.2504702-1-keescook@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200901_225356_036190_B6C57DC9 X-CRM114-Status: GOOD ( 13.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , linux-arch@vger.kernel.org, linux-efi@vger.kernel.org, Kees Cook , Arnd Bergmann , Peter Collingbourne , Catalin Marinas , Masahiro Yamada , x86@kernel.org, Nick Desaulniers , Russell King , linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, Arvind Sankar , Ingo Molnar , James Morse , Nathan Chancellor , Borislav Petkov , Will Deacon , Ard Biesheuvel , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org We don't want to depend on the linker's orphan section placement heuristics as these can vary between linkers, and may change between versions. All sections need to be explicitly handled in the linker script. With all sections now handled, enable orphan section warnings. Acked-by: Will Deacon Signed-off-by: Kees Cook --- arch/arm64/Makefile | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile index 6de7f551b821..081144fcc3da 100644 --- a/arch/arm64/Makefile +++ b/arch/arm64/Makefile @@ -29,6 +29,10 @@ LDFLAGS_vmlinux += --fix-cortex-a53-843419 endif endif +# We never want expected sections to be placed heuristically by the +# linker. All sections should be explicitly named in the linker script. +LDFLAGS_vmlinux += $(call ld-option, --orphan-handling=warn) + ifeq ($(CONFIG_ARM64_USE_LSE_ATOMICS), y) ifneq ($(CONFIG_ARM64_LSE_ATOMICS), y) $(warning LSE atomics not supported by binutils) -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel