All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PULL 0/5] Ui 20200831 patches
Date: Wed, 2 Sep 2020 11:42:07 +0200	[thread overview]
Message-ID: <20200902094207.plxixzyy5jhyrbld@sirius.home.kraxel.org> (raw)
In-Reply-To: <CAFEAcA90KpnJF2kF7QmVE3DJCSk7W_RriM6TbT3oweRjNUJSvA@mail.gmail.com>

On Tue, Sep 01, 2020 at 03:54:29PM +0100, Peter Maydell wrote:
> On Tue, 1 Sep 2020 at 15:16, Gerd Hoffmann <kraxel@redhat.com> wrote:
> >
> >   Hi,
> >
> > > Generating ar with a custom command
> > > cp: '../../pc-bios/keymaps/ar' and 'pc-bios/keymaps/ar' are the same file
> >
> > Hmm, strange.  No failures in gitlab ci:
> >         https://gitlab.com/kraxel/qemu/-/pipelines/183769485
> >
> > Any chance this is an old build tree?  Specifically created before
> > commit ddcf607fa3d6 ("meson: drop keymaps symlink") was merged, and the
> > symlink is present still?
> 
> Yeah, mostly my build trees don't get regenerated. We like
> incremental builds to continue to work.

So just not creating the symlink isn't enough, i.e. configure must
remove it if present?

Or is requiring fresh build trees ok if announced in the
cover letter / pull request?

thanks,
  Gerd



      reply	other threads:[~2020-09-02  9:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-31 11:04 [PULL 0/5] Ui 20200831 patches Gerd Hoffmann
2020-08-31 11:04 ` [PULL 1/5] ui/gtk-gl-area: Plug memleak in gd_gl_area_create_context() Gerd Hoffmann
2020-08-31 11:04 ` [PULL 2/5] vnc-auth-sasl: Plug memleak in vnc_socket_ip_addr_string Gerd Hoffmann
2020-08-31 11:04 ` [PULL 3/5] meson: fix keymaps witout qemu-keymap Gerd Hoffmann
2020-08-31 11:04 ` [PULL 4/5] ui: Add more mouse buttons to SPICE Gerd Hoffmann
2020-08-31 11:04 ` [PULL 5/5] ui/gtk: Update refresh interval after widget is realized Gerd Hoffmann
2020-09-01  9:52 ` [PULL 0/5] Ui 20200831 patches Peter Maydell
2020-09-01 14:16   ` Gerd Hoffmann
2020-09-01 14:54     ` Peter Maydell
2020-09-02  9:42       ` Gerd Hoffmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200902094207.plxixzyy5jhyrbld@sirius.home.kraxel.org \
    --to=kraxel@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.