From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30092C433E2 for ; Wed, 2 Sep 2020 12:17:13 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 03E9A20767 for ; Wed, 2 Sep 2020 12:17:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 03E9A20767 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 83E496E49C; Wed, 2 Sep 2020 12:17:12 +0000 (UTC) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id E61856E49C for ; Wed, 2 Sep 2020 12:17:11 +0000 (UTC) IronPort-SDR: KbsHwb09i+BnKbcquT/gvPZel18BKzBF/XSjZ4EHQQrtqF1yyJrXj3eaa9DbBCu3Wt/wsHvues M4pn1jY7Z3ug== X-IronPort-AV: E=McAfee;i="6000,8403,9731"; a="218923442" X-IronPort-AV: E=Sophos;i="5.76,383,1592895600"; d="scan'208";a="218923442" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Sep 2020 05:17:11 -0700 IronPort-SDR: 2tLkQpfs7HOlLZxuZawxCth3lxPuXDvNVQbJBp0mNEs8TRrNw8UyEInhrYqqb9Xoq46WGO4J5X qwj9OUNAudcQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,383,1592895600"; d="scan'208";a="301817270" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by orsmga006.jf.intel.com with SMTP; 02 Sep 2020 05:17:09 -0700 Received: by stinkbox (sSMTP sendmail emulation); Wed, 02 Sep 2020 15:17:08 +0300 Date: Wed, 2 Sep 2020 15:17:08 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: "Lisovskiy, Stanislav" Message-ID: <20200902121708.GQ6112@intel.com> References: <20200901151036.1312357-1-kai.vehmanen@linux.intel.com> <20200902103109.GM6112@intel.com> <20200902121201.GA26007@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200902121201.GA26007@intel.com> X-Patchwork-Hint: comment User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] [PATCH] drm/i915: fix regression leading to display audio probe failure on GLK X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, Sep 02, 2020 at 03:12:01PM +0300, Lisovskiy, Stanislav wrote: > On Wed, Sep 02, 2020 at 01:31:09PM +0300, Ville Syrj=E4l=E4 wrote: > > On Tue, Sep 01, 2020 at 06:10:36PM +0300, Kai Vehmanen wrote: > > > In commit 4f0b4352bd26 ("drm/i915: Extract cdclk requirements checking > > > to separate function") the order of force_min_cdclk_changed check and > > > intel_modeset_checks(), was reversed. This broke the mechanism to > > > immediately force a new CDCLK minimum, and lead to driver probe > > > errors for display audio on GLK platform with 5.9-rc1 kernel. Fix > > > the issue by moving intel_modeset_checks() call later. > > = > > Yep. I eyeed this same code recently and noticed the same bug. > > The one thing I didn't yet figure out is whether there is some > > subtle ordering requirement that was the reason for the change. > > But considering intel_modeset_checks() doesn't really do much > > anymore I think it should be safe. > > = > > Sadly CI has been lumping all underrun errors under some ancient > > bugs, so no one noticed that things started to fail when this > > regression was introduced :( > > = > > Reviewed-by: Ville Syrj=E4l=E4 > = > What surprises me here, is that the actual patch has been sent > and merged during late spring I think and we figure out that there was > a regression only by now. = > For example I figured out this only today. When I was doing that change, = > was actually aware that the change is actually quite significant as = > it changes the way how we deal with CDCLK, however those were necessary = > as we had a massive FIFO underrun issues at the moment. However CI didn't > show any problems, so we went ahead with this. I spotted some CI logs that show underruns due to this regression, but the results just got lumped in with other older underrun bugs, and thus CI results were always "success" :/ I think we need to kill off all underrun related CI filters and start from scratch. Otherwise new bugs will keep slipping through. > = > > = > > > = > > > Fixes: 4f0b4352bd26 ("drm/i915: Extract cdclk requirements checking t= o separate function)" > > > BugLink: https://github.com/thesofproject/linux/issues/2410 > > > Signed-off-by: Kai Vehmanen > > > --- > > > drivers/gpu/drm/i915/display/intel_display.c | 10 ++++------ > > > 1 file changed, 4 insertions(+), 6 deletions(-) > > > = > > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/g= pu/drm/i915/display/intel_display.c > > > index 7d50b7177d40..8caeed23037c 100644 > > > --- a/drivers/gpu/drm/i915/display/intel_display.c > > > +++ b/drivers/gpu/drm/i915/display/intel_display.c > > > @@ -15009,12 +15009,6 @@ static int intel_atomic_check(struct drm_dev= ice *dev, > > > if (dev_priv->wm.distrust_bios_wm) > > > any_ms =3D true; > > > = > > > - if (any_ms) { > > > - ret =3D intel_modeset_checks(state); > > > - if (ret) > > > - goto fail; > > > - } > > > - > > > intel_fbc_choose_crtc(dev_priv, state); > > > ret =3D calc_watermark_data(state); > > > if (ret) > > > @@ -15029,6 +15023,10 @@ static int intel_atomic_check(struct drm_dev= ice *dev, > > > goto fail; > > > = > > > if (any_ms) { > > > + ret =3D intel_modeset_checks(state); > > > + if (ret) > > > + goto fail; > > > + > > > ret =3D intel_modeset_calc_cdclk(state); > > > if (ret) > > > return ret; > > > -- = > > > 2.27.0 > > = > > -- = > > Ville Syrj=E4l=E4 > > Intel -- = Ville Syrj=E4l=E4 Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx