From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 509DFC43461 for ; Wed, 2 Sep 2020 17:45:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1102C2083B for ; Wed, 2 Sep 2020 17:45:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599068711; bh=RQZtL4W3u8ZFDrsxWq4Ue3tBbr4nUr6JJ8sRx70VO9A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=GoBuo4T2PVOgiutJtHYoZ37O0CnzvsL9HHJpcEM5TVmkewEmqb7Z6nM/vMnxzVgTd AWgMuuKKgkNUQ675BwL33ll7jJsCy8+JoTRvhe8jCqMocd1RKHNVyYijfr1JnODfYj vUlTPNGXZ/WBFjgP2rcEe7oh8Pf4qtfzsF3i4y1E= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727115AbgIBRpJ (ORCPT ); Wed, 2 Sep 2020 13:45:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:50408 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726355AbgIBRpI (ORCPT ); Wed, 2 Sep 2020 13:45:08 -0400 Received: from pali.im (pali.im [31.31.79.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 039052071B; Wed, 2 Sep 2020 17:45:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599068708; bh=RQZtL4W3u8ZFDrsxWq4Ue3tBbr4nUr6JJ8sRx70VO9A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pUZDNf+XmtjX9At928xAss9mWj/SKPVKJ8s/EDlXREeZfdTuuDQC88Qrq2T+TyQPt 6KvnFE0zjihu+FhC1xswiwTyHlszEYw2GugQQ9vwa60vm8/O+UOpARv++nCP26z9NW hmsSGfsFrAdE8w0SA7Do6ce2fCf1fk9HW3rxm49c= Received: by pali.im (Postfix) id 02C807BF; Wed, 2 Sep 2020 19:45:05 +0200 (CEST) Date: Wed, 2 Sep 2020 19:45:05 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Andrew Lunn Cc: Lorenzo Pieralisi , Rob Herring , Bjorn Helgaas , Miquel Raynal , Kishon Vijay Abraham I , Vinod Koul , Marek =?utf-8?B?QmVow7pu?= , Tomasz Maciej Nowak , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/2] phy: marvell: comphy: Convert internal SMCC firmware return codes to errno Message-ID: <20200902174505.wuflkak6dv57jxw6@pali> References: <20200902144344.16684-1-pali@kernel.org> <20200902144344.16684-2-pali@kernel.org> <20200902161328.GE3050651@lunn.ch> <20200902165652.cvb74kgxx5uejpta@pali> <20200902170010.GF3050651@lunn.ch> <20200902170525.ksovu7ah3wbotkim@pali> <20200902172029.GG3050651@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200902172029.GG3050651@lunn.ch> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 02 September 2020 19:20:29 Andrew Lunn wrote: > On Wed, Sep 02, 2020 at 07:05:25PM +0200, Pali Rohár wrote: > > On Wednesday 02 September 2020 19:00:10 Andrew Lunn wrote: > > > > > > + switch (ret) { > > > > > > + case SMCCC_RET_SUCCESS: > > > > > > + return 0; > > > > > > + case SMCCC_RET_NOT_SUPPORTED: > > > > > > + return -EOPNOTSUPP; > > > > > > + default: > > > > > > + return -EINVAL; > > > > > > + } > > > > > > } > > > > > > > > > > Hi Pali > > > > > > > > > > Maybe this should be a global helper translating SMCCC_RET_* into a > > > > > standard errno value? > > > > > > > > > > Andrew > > > > > > > > Hello Andrew! > > > > > > > > Well, I'm not sure if some standard global helper is the correct way for > > > > marvell comphy handler. It returns 0 for success and -1 on error when > > > > handler is not supported. > > > > > > No, i was meaning just > > > > > > switch (ret) { > > > case SMCCC_RET_SUCCESS: > > > return 0; > > > case SMCCC_RET_NOT_SUPPORTED: > > > return -EOPNOTSUPP; > > > default: > > > return -EINVAL; > > > } > > > > But this is not a complete generic helper. There are more generic SMCC > > return codes and generic helper should define and translate all of them. > > /* > * Return codes defined in ARM DEN 0070A > * ARM DEN 0070A is now merged/consolidated into ARM DEN 0028 C > */ > #define SMCCC_RET_SUCCESS 0 > #define SMCCC_RET_NOT_SUPPORTED -1 > #define SMCCC_RET_NOT_REQUIRED -2 > #define SMCCC_RET_INVALID_PARAMETER -3 Routines can use also other custom return codes. These are IIRC just standard defined. > I only see problems with SMCCC_RET_NOT_REQUIRED and what value to use > for it. Do you have any idea what is actually means? A parameter was > passed which was not required? Or that the call itself is not > required? Looking at the uses of it currently in the kernel, it does > not seem to be an actual error. So maybe just return 0? I'm not sure. That is why I wrote that larger discussion about generic helper is needed. There are for sure people who understand SMC better and have deep insight. For Marvell comphy we cannot use return code -2 as success like 0. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15937C433E2 for ; Wed, 2 Sep 2020 17:46:45 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C85FA2071B for ; Wed, 2 Sep 2020 17:46:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EPvsXDiw"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="pUZDNf+X" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C85FA2071B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8iYX2hKfO8Ur8SzUvz18yHSvBYBXOUiFg7bK2mv6AN4=; b=EPvsXDiwEPhxeLwJ/4I0OBRy4 y+IkmCvZnl4JP9o9tOD3wksAEv0lGYqqfUPvbmAuDQb5IrQkaXSqk2Mgnl38HmuNBHiZaoaOYU97Y CTIx48Mme5EeNRMRBd4rH39kNnq9QaiTOG0j8VflDjdKGFNqA3PlMiTfz43d6DzG8Q997pCSzVOX2 S25FPhlaxzXYk8tUCpUgCj8UFuOXD8RUf/0czCZ+0xKEwhM3BlOQFIKEbASOS6a+aQ5Hto0yRO8G9 c4hNXVydaiBJsRbiEuS5VV4T7s1UiQbDYHx+F0o+ob4hIuel3hPMRknuL4nlA3MgdSwFDUe5c+ke7 TpLUIPMTg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDWop-00038o-E5; Wed, 02 Sep 2020 17:45:11 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDWon-00038I-4M for linux-arm-kernel@lists.infradead.org; Wed, 02 Sep 2020 17:45:09 +0000 Received: from pali.im (pali.im [31.31.79.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 039052071B; Wed, 2 Sep 2020 17:45:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599068708; bh=RQZtL4W3u8ZFDrsxWq4Ue3tBbr4nUr6JJ8sRx70VO9A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pUZDNf+XmtjX9At928xAss9mWj/SKPVKJ8s/EDlXREeZfdTuuDQC88Qrq2T+TyQPt 6KvnFE0zjihu+FhC1xswiwTyHlszEYw2GugQQ9vwa60vm8/O+UOpARv++nCP26z9NW hmsSGfsFrAdE8w0SA7Do6ce2fCf1fk9HW3rxm49c= Received: by pali.im (Postfix) id 02C807BF; Wed, 2 Sep 2020 19:45:05 +0200 (CEST) Date: Wed, 2 Sep 2020 19:45:05 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Andrew Lunn Subject: Re: [PATCH 1/2] phy: marvell: comphy: Convert internal SMCC firmware return codes to errno Message-ID: <20200902174505.wuflkak6dv57jxw6@pali> References: <20200902144344.16684-1-pali@kernel.org> <20200902144344.16684-2-pali@kernel.org> <20200902161328.GE3050651@lunn.ch> <20200902165652.cvb74kgxx5uejpta@pali> <20200902170010.GF3050651@lunn.ch> <20200902170525.ksovu7ah3wbotkim@pali> <20200902172029.GG3050651@lunn.ch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200902172029.GG3050651@lunn.ch> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200902_134509_342456_E40B6F4D X-CRM114-Status: GOOD ( 25.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomasz Maciej Nowak , Rob Herring , Lorenzo Pieralisi , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Kishon Vijay Abraham I , Vinod Koul , Miquel Raynal , Bjorn Helgaas , Marek =?utf-8?B?QmVow7pu?= , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkbmVzZGF5IDAyIFNlcHRlbWJlciAyMDIwIDE5OjIwOjI5IEFuZHJldyBMdW5uIHdyb3Rl Ogo+IE9uIFdlZCwgU2VwIDAyLCAyMDIwIGF0IDA3OjA1OjI1UE0gKzAyMDAsIFBhbGkgUm9ow6Fy IHdyb3RlOgo+ID4gT24gV2VkbmVzZGF5IDAyIFNlcHRlbWJlciAyMDIwIDE5OjAwOjEwIEFuZHJl dyBMdW5uIHdyb3RlOgo+ID4gPiA+ID4gPiArCXN3aXRjaCAocmV0KSB7Cj4gPiA+ID4gPiA+ICsJ Y2FzZSBTTUNDQ19SRVRfU1VDQ0VTUzoKPiA+ID4gPiA+ID4gKwkJcmV0dXJuIDA7Cj4gPiA+ID4g PiA+ICsJY2FzZSBTTUNDQ19SRVRfTk9UX1NVUFBPUlRFRDoKPiA+ID4gPiA+ID4gKwkJcmV0dXJu IC1FT1BOT1RTVVBQOwo+ID4gPiA+ID4gPiArCWRlZmF1bHQ6Cj4gPiA+ID4gPiA+ICsJCXJldHVy biAtRUlOVkFMOwo+ID4gPiA+ID4gPiArCX0KPiA+ID4gPiA+ID4gIH0KPiA+ID4gPiA+IAo+ID4g PiA+ID4gSGkgUGFsaQo+ID4gPiA+ID4gCj4gPiA+ID4gPiBNYXliZSB0aGlzIHNob3VsZCBiZSBh IGdsb2JhbCBoZWxwZXIgdHJhbnNsYXRpbmcgU01DQ0NfUkVUXyogaW50byBhCj4gPiA+ID4gPiBz dGFuZGFyZCBlcnJubyB2YWx1ZT8KPiA+ID4gPiA+IAo+ID4gPiA+ID4gCSBBbmRyZXcKPiA+ID4g PiAKPiA+ID4gPiBIZWxsbyBBbmRyZXchCj4gPiA+ID4gCj4gPiA+ID4gV2VsbCwgSSdtIG5vdCBz dXJlIGlmIHNvbWUgc3RhbmRhcmQgZ2xvYmFsIGhlbHBlciBpcyB0aGUgY29ycmVjdCB3YXkgZm9y Cj4gPiA+ID4gbWFydmVsbCBjb21waHkgaGFuZGxlci4gSXQgcmV0dXJucyAwIGZvciBzdWNjZXNz IGFuZCAtMSBvbiBlcnJvciB3aGVuCj4gPiA+ID4gaGFuZGxlciBpcyBub3Qgc3VwcG9ydGVkLgo+ ID4gPiAKPiA+ID4gTm8sIGkgd2FzIG1lYW5pbmcganVzdCAKPiA+ID4gCj4gPiA+IHN3aXRjaCAo cmV0KSB7Cj4gPiA+IGNhc2UgU01DQ0NfUkVUX1NVQ0NFU1M6Cj4gPiA+IAlyZXR1cm4gMDsKPiA+ ID4gY2FzZSBTTUNDQ19SRVRfTk9UX1NVUFBPUlRFRDoKPiA+ID4gCXJldHVybiAtRU9QTk9UU1VQ UDsKPiA+ID4gZGVmYXVsdDoKPiA+ID4gCXJldHVybiAtRUlOVkFMOwo+ID4gPiB9Cj4gPiAKPiA+ IEJ1dCB0aGlzIGlzIG5vdCBhIGNvbXBsZXRlIGdlbmVyaWMgaGVscGVyLiBUaGVyZSBhcmUgbW9y ZSBnZW5lcmljIFNNQ0MKPiA+IHJldHVybiBjb2RlcyBhbmQgZ2VuZXJpYyBoZWxwZXIgc2hvdWxk IGRlZmluZSBhbmQgdHJhbnNsYXRlIGFsbCBvZiB0aGVtLgo+IAo+IC8qCj4gICogUmV0dXJuIGNv ZGVzIGRlZmluZWQgaW4gQVJNIERFTiAwMDcwQQo+ICAqIEFSTSBERU4gMDA3MEEgaXMgbm93IG1l cmdlZC9jb25zb2xpZGF0ZWQgaW50byBBUk0gREVOIDAwMjggQwo+ICAqLwo+ICNkZWZpbmUgU01D Q0NfUkVUX1NVQ0NFU1MJCQkwCj4gI2RlZmluZSBTTUNDQ19SRVRfTk9UX1NVUFBPUlRFRAkJCS0x Cj4gI2RlZmluZSBTTUNDQ19SRVRfTk9UX1JFUVVJUkVECQkJLTIKPiAjZGVmaW5lIFNNQ0NDX1JF VF9JTlZBTElEX1BBUkFNRVRFUgkJLTMKClJvdXRpbmVzIGNhbiB1c2UgYWxzbyBvdGhlciBjdXN0 b20gcmV0dXJuIGNvZGVzLiBUaGVzZSBhcmUgSUlSQyBqdXN0CnN0YW5kYXJkIGRlZmluZWQuCgo+ IEkgb25seSBzZWUgcHJvYmxlbXMgd2l0aCBTTUNDQ19SRVRfTk9UX1JFUVVJUkVEIGFuZCB3aGF0 IHZhbHVlIHRvIHVzZQo+IGZvciBpdC4gRG8geW91IGhhdmUgYW55IGlkZWEgd2hhdCBpcyBhY3R1 YWxseSBtZWFucz8gQSBwYXJhbWV0ZXIgd2FzCj4gcGFzc2VkIHdoaWNoIHdhcyBub3QgcmVxdWly ZWQ/IE9yIHRoYXQgdGhlIGNhbGwgaXRzZWxmIGlzIG5vdAo+IHJlcXVpcmVkPyBMb29raW5nIGF0 IHRoZSB1c2VzIG9mIGl0IGN1cnJlbnRseSBpbiB0aGUga2VybmVsLCBpdCBkb2VzCj4gbm90IHNl ZW0gdG8gYmUgYW4gYWN0dWFsIGVycm9yLiBTbyBtYXliZSBqdXN0IHJldHVybiAwPwoKSSdtIG5v dCBzdXJlLiBUaGF0IGlzIHdoeSBJIHdyb3RlIHRoYXQgbGFyZ2VyIGRpc2N1c3Npb24gYWJvdXQg Z2VuZXJpYwpoZWxwZXIgaXMgbmVlZGVkLiBUaGVyZSBhcmUgZm9yIHN1cmUgcGVvcGxlIHdobyB1 bmRlcnN0YW5kIFNNQyBiZXR0ZXIKYW5kIGhhdmUgZGVlcCBpbnNpZ2h0LgoKRm9yIE1hcnZlbGwg Y29tcGh5IHdlIGNhbm5vdCB1c2UgcmV0dXJuIGNvZGUgLTIgYXMgc3VjY2VzcyBsaWtlIDAuCgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0t a2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcK aHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2Vy bmVsCg==