From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26A86C433E2 for ; Thu, 3 Sep 2020 10:21:59 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D04AA20767 for ; Thu, 3 Sep 2020 10:21:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ItK0H+fe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D04AA20767 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37656 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kDmNR-0000Gj-Vc for qemu-devel@archiver.kernel.org; Thu, 03 Sep 2020 06:21:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50660) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kDmMt-0008Cy-WE for qemu-devel@nongnu.org; Thu, 03 Sep 2020 06:21:24 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:59768 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kDmMr-0007Mu-Vy for qemu-devel@nongnu.org; Thu, 03 Sep 2020 06:21:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1599128480; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=Hb5nerTmwTAn8IS41qNxgnbD3Sq0Cyo3d8I2NkLCrBk=; b=ItK0H+feWO+Ma08Go1hFJTHFG/9J8Gb8ihGHTE06BjMyMFL9nmQRHTJKLH8tCbemyHR8IN MbfeycpKhG15PUD4eBjn/S0dzCi2D2I62iCLTR4l+bT59Sw67d15aVPAKgJoEJUTb3wrka PbV++K2XAXchV4wvMT7lqjOqUFJDS7A= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-457-33JskihbNL6xG7owv_VkCw-1; Thu, 03 Sep 2020 06:21:19 -0400 X-MC-Unique: 33JskihbNL6xG7owv_VkCw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E2F09100854F; Thu, 3 Sep 2020 10:21:17 +0000 (UTC) Received: from redhat.com (ovpn-114-170.ams2.redhat.com [10.36.114.170]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 212E27A42E; Thu, 3 Sep 2020 10:21:14 +0000 (UTC) Date: Thu, 3 Sep 2020 11:21:12 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Kevin Wolf Subject: Re: [PATCH v3 7/7] migration: introduce snapshot-{save, load, delete} QMP commands Message-ID: <20200903102112.GI441291@redhat.com> References: <20200827111606.1408275-1-berrange@redhat.com> <20200827111606.1408275-8-berrange@redhat.com> <87d035tw74.fsf@dusky.pond.sub.org> <20200901164732.GZ345480@redhat.com> <873640msui.fsf@dusky.pond.sub.org> <20200902110554.GF403297@redhat.com> <87blinp4xa.fsf@dusky.pond.sub.org> <20200903101729.GA8835@linux.fritz.box> MIME-Version: 1.0 In-Reply-To: <20200903101729.GA8835@linux.fritz.box> User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Received-SPF: pass client-ip=207.211.31.81; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/03 04:23:49 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Peter Krempa , "Denis V. Lunev" , qemu-block@nongnu.org, Juan Quintela , qemu-devel@nongnu.org, Markus Armbruster , Pavel Dovgalyuk , Paolo Bonzini , Max Reitz , John Snow , "Dr. David Alan Gilbert" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Sep 03, 2020 at 12:17:29PM +0200, Kevin Wolf wrote: > Am 03.09.2020 um 11:48 hat Markus Armbruster geschrieben: > > If having to map from drive ID to node-name really is too much of a > > burden, we can look for ways to make it easier, or we can make savem > > optionally accept drive IDs instead of node-names, like we do in several > > other places for backward compatibility. > > Yes, letting commands accept both node-names and drive IDs is trivial > and we do it pretty much everywhere. Much better than randomly selecting > an image to save the VM state to. Is there anything which guarantees that node-names and drive IDs will never clash ? I didn't look for drive IDs as I was trying to ensure a non-ambiguous lookup in case a string was both a valid node name and a valid drive ID Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|