From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0350BC433E2 for ; Thu, 3 Sep 2020 14:13:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BD93A20658 for ; Thu, 3 Sep 2020 14:13:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729114AbgICOMm (ORCPT ); Thu, 3 Sep 2020 10:12:42 -0400 Received: from mga06.intel.com ([134.134.136.31]:34932 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729142AbgICOKH (ORCPT ); Thu, 3 Sep 2020 10:10:07 -0400 IronPort-SDR: c7qgbts54Y3P1Y2SvMcDeRwFb6ohKhODd/xjnUjbw+0b31oewotWf3NS8hnxECQPMUneM7P8g5 r7byl4bChipQ== X-IronPort-AV: E=McAfee;i="6000,8403,9733"; a="219129982" X-IronPort-AV: E=Sophos;i="5.76,387,1592895600"; d="scan'208";a="219129982" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Sep 2020 07:09:39 -0700 IronPort-SDR: rkZ0Olar/QMGUYe0mhdZgEL72iAnn+i/sGoky55dDU7fVd4VgjWgmNUES9gyd25QUNbpwm4FXb Cij5BElBsaRA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,387,1592895600"; d="scan'208";a="331797666" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga008.jf.intel.com with ESMTP; 03 Sep 2020 07:09:37 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1kDptc-00E2xB-51; Thu, 03 Sep 2020 17:07:24 +0300 Date: Thu, 3 Sep 2020 17:07:24 +0300 From: Andy Shevchenko To: Mauro Carvalho Chehab Cc: Sakari Ailus , Greg Kroah-Hartman , linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/5] media: atomisp: get rid of -Wsuggest-attribute=format warnings Message-ID: <20200903140724.GE1891694@smile.fi.intel.com> References: <6c77d765707b1e6b2901fd23d85b4d032f1a1799.1599141140.git.mchehab+huawei@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6c77d765707b1e6b2901fd23d85b4d032f1a1799.1599141140.git.mchehab+huawei@kernel.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 03, 2020 at 03:57:32PM +0200, Mauro Carvalho Chehab wrote: > There are some warnings reported by gcc: > drivers/staging/media/atomisp//pci/atomisp_compat_css20.c:164:2: warning: function ‘atomisp_css2_dbg_print’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format] > drivers/staging/media/atomisp//pci/atomisp_compat_css20.c:170:2: warning: function ‘atomisp_css2_dbg_ftrace_print’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format] > drivers/staging/media/atomisp//pci/atomisp_compat_css20.c:170:2: warning: function ‘atomisp_css2_dbg_ftrace_print’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format] > drivers/staging/media/atomisp//pci/atomisp_compat_css20.c:176:2: warning: function ‘atomisp_css2_err_print’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format] > > That are due to the usage of printf-like messages without > enabling the error checking logic. > > Add the proper attributes in order to shut up such warnings. > +static int __attribute__((format (printf, 1, 0))) > +atomisp_css2_dbg_ftrace_print(const char *fmt, va_list args) > { > ftrace_vprintk(fmt, args); > return 0; > } > Why not to drop it completely as well? > -static int atomisp_css2_err_print(const char *fmt, va_list args) > -{ > - vprintk(fmt, args); > - return 0; > -} -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8943AC433E9 for ; Thu, 3 Sep 2020 14:09:58 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 545D72054F for ; Thu, 3 Sep 2020 14:09:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 545D72054F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 05F1A86BBB; Thu, 3 Sep 2020 14:09:58 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kBHKCBESym1t; Thu, 3 Sep 2020 14:09:56 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id CDE9086D17; Thu, 3 Sep 2020 14:09:55 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 206331BF855 for ; Thu, 3 Sep 2020 14:09:54 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 1AAFD84EB9 for ; Thu, 3 Sep 2020 14:09:54 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ud+KRH9OtSls for ; Thu, 3 Sep 2020 14:09:53 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by whitealder.osuosl.org (Postfix) with ESMTPS id 429C884D9F for ; Thu, 3 Sep 2020 14:09:53 +0000 (UTC) IronPort-SDR: ImG70L/PmOvUJPkzzhDW8kBW1aiE7Gztu4Pjm1BPLtTjwl4VqBSIscmKB6kUaszRpIkt+vEgBF mgLPG2PtFoAw== X-IronPort-AV: E=McAfee;i="6000,8403,9733"; a="219129983" X-IronPort-AV: E=Sophos;i="5.76,387,1592895600"; d="scan'208";a="219129983" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Sep 2020 07:09:39 -0700 IronPort-SDR: rkZ0Olar/QMGUYe0mhdZgEL72iAnn+i/sGoky55dDU7fVd4VgjWgmNUES9gyd25QUNbpwm4FXb Cij5BElBsaRA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,387,1592895600"; d="scan'208";a="331797666" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga008.jf.intel.com with ESMTP; 03 Sep 2020 07:09:37 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1kDptc-00E2xB-51; Thu, 03 Sep 2020 17:07:24 +0300 Date: Thu, 3 Sep 2020 17:07:24 +0300 From: Andy Shevchenko To: Mauro Carvalho Chehab Subject: Re: [PATCH 5/5] media: atomisp: get rid of -Wsuggest-attribute=format warnings Message-ID: <20200903140724.GE1891694@smile.fi.intel.com> References: <6c77d765707b1e6b2901fd23d85b4d032f1a1799.1599141140.git.mchehab+huawei@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6c77d765707b1e6b2901fd23d85b4d032f1a1799.1599141140.git.mchehab+huawei@kernel.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Sakari Ailus , linux-media@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" T24gVGh1LCBTZXAgMDMsIDIwMjAgYXQgMDM6NTc6MzJQTSArMDIwMCwgTWF1cm8gQ2FydmFsaG8g Q2hlaGFiIHdyb3RlOgo+IFRoZXJlIGFyZSBzb21lIHdhcm5pbmdzIHJlcG9ydGVkIGJ5IGdjYzoK PiAJZHJpdmVycy9zdGFnaW5nL21lZGlhL2F0b21pc3AvL3BjaS9hdG9taXNwX2NvbXBhdF9jc3My MC5jOjE2NDoyOiB3YXJuaW5nOiBmdW5jdGlvbiDigJhhdG9taXNwX2NzczJfZGJnX3ByaW504oCZ IG1pZ2h0IGJlIGEgY2FuZGlkYXRlIGZvciDigJhnbnVfcHJpbnRm4oCZIGZvcm1hdCBhdHRyaWJ1 dGUgWy1Xc3VnZ2VzdC1hdHRyaWJ1dGU9Zm9ybWF0XQo+IAlkcml2ZXJzL3N0YWdpbmcvbWVkaWEv YXRvbWlzcC8vcGNpL2F0b21pc3BfY29tcGF0X2NzczIwLmM6MTcwOjI6IHdhcm5pbmc6IGZ1bmN0 aW9uIOKAmGF0b21pc3BfY3NzMl9kYmdfZnRyYWNlX3ByaW504oCZIG1pZ2h0IGJlIGEgY2FuZGlk YXRlIGZvciDigJhnbnVfcHJpbnRm4oCZIGZvcm1hdCBhdHRyaWJ1dGUgWy1Xc3VnZ2VzdC1hdHRy aWJ1dGU9Zm9ybWF0XQo+IAlkcml2ZXJzL3N0YWdpbmcvbWVkaWEvYXRvbWlzcC8vcGNpL2F0b21p c3BfY29tcGF0X2NzczIwLmM6MTcwOjI6IHdhcm5pbmc6IGZ1bmN0aW9uIOKAmGF0b21pc3BfY3Nz Ml9kYmdfZnRyYWNlX3ByaW504oCZIG1pZ2h0IGJlIGEgY2FuZGlkYXRlIGZvciDigJhnbnVfcHJp bnRm4oCZIGZvcm1hdCBhdHRyaWJ1dGUgWy1Xc3VnZ2VzdC1hdHRyaWJ1dGU9Zm9ybWF0XQo+IAlk cml2ZXJzL3N0YWdpbmcvbWVkaWEvYXRvbWlzcC8vcGNpL2F0b21pc3BfY29tcGF0X2NzczIwLmM6 MTc2OjI6IHdhcm5pbmc6IGZ1bmN0aW9uIOKAmGF0b21pc3BfY3NzMl9lcnJfcHJpbnTigJkgbWln aHQgYmUgYSBjYW5kaWRhdGUgZm9yIOKAmGdudV9wcmludGbigJkgZm9ybWF0IGF0dHJpYnV0ZSBb LVdzdWdnZXN0LWF0dHJpYnV0ZT1mb3JtYXRdCj4gCj4gVGhhdCBhcmUgZHVlIHRvIHRoZSB1c2Fn ZSBvZiBwcmludGYtbGlrZSBtZXNzYWdlcyB3aXRob3V0Cj4gZW5hYmxpbmcgdGhlIGVycm9yIGNo ZWNraW5nIGxvZ2ljLgo+IAo+IEFkZCB0aGUgcHJvcGVyIGF0dHJpYnV0ZXMgaW4gb3JkZXIgdG8g c2h1dCB1cCBzdWNoIHdhcm5pbmdzLgoKPiArc3RhdGljIGludCAgX19hdHRyaWJ1dGVfXygoZm9y bWF0IChwcmludGYsIDEsIDApKSkKPiArYXRvbWlzcF9jc3MyX2RiZ19mdHJhY2VfcHJpbnQoY29u c3QgY2hhciAqZm10LCB2YV9saXN0IGFyZ3MpCj4gIHsKPiAgCWZ0cmFjZV92cHJpbnRrKGZtdCwg YXJncyk7Cj4gIAlyZXR1cm4gMDsKPiAgfQo+ICAKCldoeSBub3QgdG8gZHJvcCBpdCBjb21wbGV0 ZWx5IGFzIHdlbGw/Cgo+IC1zdGF0aWMgaW50IGF0b21pc3BfY3NzMl9lcnJfcHJpbnQoY29uc3Qg Y2hhciAqZm10LCB2YV9saXN0IGFyZ3MpCj4gLXsKPiAtCXZwcmludGsoZm10LCBhcmdzKTsKPiAt CXJldHVybiAwOwo+IC19CgoKLS0gCldpdGggQmVzdCBSZWdhcmRzLApBbmR5IFNoZXZjaGVua28K CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkZXZlbCBt YWlsaW5nIGxpc3QKZGV2ZWxAbGludXhkcml2ZXJwcm9qZWN0Lm9yZwpodHRwOi8vZHJpdmVyZGV2 LmxpbnV4ZHJpdmVycHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcml2ZXJkZXYtZGV2ZWwK