From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54F6FC433E2 for ; Thu, 3 Sep 2020 21:50:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1F21F20639 for ; Thu, 3 Sep 2020 21:50:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="SlD5lTtn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729421AbgICVuP (ORCPT ); Thu, 3 Sep 2020 17:50:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726397AbgICVuG (ORCPT ); Thu, 3 Sep 2020 17:50:06 -0400 Received: from mail-pg1-x542.google.com (mail-pg1-x542.google.com [IPv6:2607:f8b0:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E50AC061244 for ; Thu, 3 Sep 2020 14:50:06 -0700 (PDT) Received: by mail-pg1-x542.google.com with SMTP id h12so3176354pgm.7 for ; Thu, 03 Sep 2020 14:50:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=9OR6JT/gDQkiw7Q3Fa+IeISt3W9FIEoweyBz21QtHYY=; b=SlD5lTtnmNwlNoqmJOqtx2+Yt4N1mjRl+6MJSYVsMfoK7/Vte9rczahAFAqHnyUmuV Sh7rwOVbBxjFQ8McJgNgBYopu598rgZcDcsmsFDuQmlnFjiaMgVEzupYqeqjeeE3eUEq lRP6kFMGcXoyupiZ9023vt2rn4Dd4rd9u4Z74= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=9OR6JT/gDQkiw7Q3Fa+IeISt3W9FIEoweyBz21QtHYY=; b=io5D6hQjFyvY5y/8rTMc9lGUxkPRhvwp2HX70nBkIznMea09UeXDqtEMrlTbTr1CvA nhA1svUMZhA3f1J497ebcQn+qu/xoLAPKvkSIuBwMEOvek6Z/OVy86svIan/KbuX8X7B bYKtF4HD10w7K8RGfMDns685Zuz9GhwVDiIlqGLPMlq5JJx9Bvbo5g/Yk44Pr8N2YO+a UyuYDtkW4wK6Sgc7BQnGLGvpisx6AwD4A56FRSQQuZKhuoDpDTU/FU+dLKYyxPt6WzDk d1P/yTd4Dcv31ViYcBoNUm22xm4vX3GpwZ36LDdKew5WepbQpjaDe6UEe2T5tkp6yKPp OA9w== X-Gm-Message-State: AOAM531EE/B69NQRgxbuT92pjIXkTzCAL2LsV1T7JiHKEl4WeQrdzYNh C1J3sHFhbn84ofrRzxZoUngosA== X-Google-Smtp-Source: ABdhPJzv22i9c6AyREMh2qsXkXGwLuQNiCYhEpeSxCHuz3ZxEVmXaBNaH/fkJhsoZ2M5HPXWMnRolQ== X-Received: by 2002:a65:648c:: with SMTP id e12mr4696062pgv.57.1599169805900; Thu, 03 Sep 2020 14:50:05 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id s198sm3628323pgc.4.2020.09.03.14.50.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Sep 2020 14:50:04 -0700 (PDT) Date: Thu, 3 Sep 2020 14:50:03 -0700 From: Kees Cook To: Sami Tolvanen Cc: Masahiro Yamada , Will Deacon , Peter Zijlstra , Steven Rostedt , Greg Kroah-Hartman , "Paul E. McKenney" , Nick Desaulniers , clang-built-linux@googlegroups.com, kernel-hardening@lists.openwall.com, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, x86@kernel.org, Luca Stefani Subject: Re: [PATCH v2 04/28] RAS/CEC: Fix cec_init() prototype Message-ID: <202009031449.287535C@keescook> References: <20200624203200.78870-1-samitolvanen@google.com> <20200903203053.3411268-1-samitolvanen@google.com> <20200903203053.3411268-5-samitolvanen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200903203053.3411268-5-samitolvanen@google.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 03, 2020 at 01:30:29PM -0700, Sami Tolvanen wrote: > From: Luca Stefani > > late_initcall() expects a function that returns an integer. Update the > function signature to match. > > [ bp: Massage commit message into proper sentences. ] > > Fixes: 9554bfe403nd ("x86/mce: Convert the CEC to use the MCE notifier") > Signed-off-by: Luca Stefani I don't see this in -next yet (next-20200903), but given Boris's SoB, I suspect it just hasn't snuck it's way there from -tip. Regardless: Reviewed-by: Kees Cook -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0BCFC43461 for ; Thu, 3 Sep 2020 21:51:25 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A6D5920709 for ; Thu, 3 Sep 2020 21:51:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="X3vBaWsM"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="SlD5lTtn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A6D5920709 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lQUfuZbjHA7wOjSLgrvkt3Sn+4NT9g2ggAg5HndQTtA=; b=X3vBaWsMl4LLPLtwSe4+R2CIQ pPxfM+uRDfvM4GAINsw92khaZfdGNHOmYWgzY7pVYJa/ksRv1D6N1SU6ip0OTO0MvsqutnlzaYMrw tI+j1TpHsYcQPGO86Qoy4eGhoaRlLuWkjYsvxixFKpZIRqrEIDokkR/ydbd+5fLqwEQWTd+Vr4J4V 7pV8lyNyoFOIxMT/r2zEBXnqT5D4jz4w4n5y6p9n+e0OES4HnGjlc4KAY5UcjXnmmPJXzs5vL0yOk w2VYgN4p3reVJcpV1t5EXXLruO0HnC6BaFtTKtojniA5339Ctq6Z8eMsnT6WBSAbN7N8iQ5b51qHm N7yE3mFMA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDx7S-0003Ym-3v; Thu, 03 Sep 2020 21:50:10 +0000 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDx7P-0003XU-PP for linux-arm-kernel@lists.infradead.org; Thu, 03 Sep 2020 21:50:08 +0000 Received: by mail-pf1-x441.google.com with SMTP id m8so3420731pfh.3 for ; Thu, 03 Sep 2020 14:50:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=9OR6JT/gDQkiw7Q3Fa+IeISt3W9FIEoweyBz21QtHYY=; b=SlD5lTtnmNwlNoqmJOqtx2+Yt4N1mjRl+6MJSYVsMfoK7/Vte9rczahAFAqHnyUmuV Sh7rwOVbBxjFQ8McJgNgBYopu598rgZcDcsmsFDuQmlnFjiaMgVEzupYqeqjeeE3eUEq lRP6kFMGcXoyupiZ9023vt2rn4Dd4rd9u4Z74= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=9OR6JT/gDQkiw7Q3Fa+IeISt3W9FIEoweyBz21QtHYY=; b=Lm3vIEl53eEEKnVe6CyXA2eG19clnUlrG2zV+mMrQpewRIgy8ZwsCwbS56TuYX9ViS LcwtrBzlWCUDVxornRmhnRWnjNugAraCpjzNBe23j+4b7bYV5pG1Z4IysQOBsP8soVme auBwCsmoZnKMKGn3XLeN56Au7uzggoD/jLddJzeWb3zCh7HHDBdlYNGCefM1gEIGQwhC PqlhIP4c+OI4vAtOF/pKI62kQW6GfE4FingLEy0n5THMw8vvw3BeYvPM2dImAncTE5Tj z39mtNZZiApf7LfPXB390nH7WHuwgHBf2Ju+q6sJ7BUZguJ4oAu1zjwvPHJqiC/4rd+w UOeQ== X-Gm-Message-State: AOAM531LZl//LtOqX72Vtlq45D38jbY4rtmITv26fsIuOHAr8J10oCpr SGpiVDnVbZJO4pf9Krub4+1OZg== X-Google-Smtp-Source: ABdhPJzv22i9c6AyREMh2qsXkXGwLuQNiCYhEpeSxCHuz3ZxEVmXaBNaH/fkJhsoZ2M5HPXWMnRolQ== X-Received: by 2002:a65:648c:: with SMTP id e12mr4696062pgv.57.1599169805900; Thu, 03 Sep 2020 14:50:05 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id s198sm3628323pgc.4.2020.09.03.14.50.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Sep 2020 14:50:04 -0700 (PDT) Date: Thu, 3 Sep 2020 14:50:03 -0700 From: Kees Cook To: Sami Tolvanen Subject: Re: [PATCH v2 04/28] RAS/CEC: Fix cec_init() prototype Message-ID: <202009031449.287535C@keescook> References: <20200624203200.78870-1-samitolvanen@google.com> <20200903203053.3411268-1-samitolvanen@google.com> <20200903203053.3411268-5-samitolvanen@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200903203053.3411268-5-samitolvanen@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200903_175007_869704_9B77B9F9 X-CRM114-Status: GOOD ( 13.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, x86@kernel.org, "Paul E. McKenney" , kernel-hardening@lists.openwall.com, Peter Zijlstra , Greg Kroah-Hartman , Masahiro Yamada , linux-kbuild@vger.kernel.org, Nick Desaulniers , linux-kernel@vger.kernel.org, Steven Rostedt , Luca Stefani , clang-built-linux@googlegroups.com, linux-pci@vger.kernel.org, Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 03, 2020 at 01:30:29PM -0700, Sami Tolvanen wrote: > From: Luca Stefani > > late_initcall() expects a function that returns an integer. Update the > function signature to match. > > [ bp: Massage commit message into proper sentences. ] > > Fixes: 9554bfe403nd ("x86/mce: Convert the CEC to use the MCE notifier") > Signed-off-by: Luca Stefani I don't see this in -next yet (next-20200903), but given Boris's SoB, I suspect it just hasn't snuck it's way there from -tip. Regardless: Reviewed-by: Kees Cook -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel