From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDB0AC2D0A7 for ; Thu, 3 Sep 2020 21:51:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A24B920678 for ; Thu, 3 Sep 2020 21:51:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="ZyZZKeIp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729438AbgICVvS (ORCPT ); Thu, 3 Sep 2020 17:51:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729088AbgICVvN (ORCPT ); Thu, 3 Sep 2020 17:51:13 -0400 Received: from mail-pj1-x1041.google.com (mail-pj1-x1041.google.com [IPv6:2607:f8b0:4864:20::1041]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04DF0C061246 for ; Thu, 3 Sep 2020 14:51:13 -0700 (PDT) Received: by mail-pj1-x1041.google.com with SMTP id mm21so2200399pjb.4 for ; Thu, 03 Sep 2020 14:51:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=qXpu71ctdlh3mEQbznjWlLLlQUw5P2bBw2F3vq4Wzjo=; b=ZyZZKeIpcpI80+hejxzxlgql178wdYHMLgxxEcNsZP5DgNheiVVnTG3N+eHQ6nQdTA Niu4Mm24mQzd8zXiPCHvu1WgPl9pvcZLM7dK+CVMgSnMSoSLzj6aaeKFz4fN5yjD378D otR7uM4FcmoQ6MxJYzFRJSwnOdQ8bNb3OFeq4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=qXpu71ctdlh3mEQbznjWlLLlQUw5P2bBw2F3vq4Wzjo=; b=SK+Sa33XSbKj5AWAtaLy5AqXcWQsKTFy/NEsgoVRCOhjQMgD1Tcw0xBhaz/UMCYESB OlwQMU64tMnbZXl5aMCCVjpJCnVAH+eKc5eIrdlYs9dlBzfN7b8WlMCAbPF2BlS0M+WO vmhSUMj0UJ2syTtarlEMVNkcoZyifSDMwCcWCsCEOWs8J5AdvGUY9wxv2FQXfmuX0ZaW 6RpQ1DI18VD93W8k8o67qWa+A2Q/6DJz6fXNPXfk7DO7y3D8F7//7ey7kgX3XCs8auS3 qIOOCnrBmor9pZpIlmts3XgXlmz7n3HAn80pc+BKAyez3kLBgJaiCd7XXVopxFc/B5s0 R82A== X-Gm-Message-State: AOAM532sXzkuWMLoJ9r2BFT2sJ6knJaZGT7oPHCEr/wBo5ITcj2bKV3m MOA4d00xv29sBTxgHc2S8Eop5A== X-Google-Smtp-Source: ABdhPJykQhA773Y/RsqqBh6IkXbjxUAGr+2WNPNkmamwrqnCASrzuPNLdRBsNJk4iZWq6CDQhSD6fA== X-Received: by 2002:a17:90a:950a:: with SMTP id t10mr5013648pjo.107.1599169872611; Thu, 03 Sep 2020 14:51:12 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id h15sm3019108pfo.23.2020.09.03.14.51.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Sep 2020 14:51:11 -0700 (PDT) Date: Thu, 3 Sep 2020 14:51:10 -0700 From: Kees Cook To: Sami Tolvanen Cc: Masahiro Yamada , Will Deacon , Peter Zijlstra , Steven Rostedt , Greg Kroah-Hartman , "Paul E. McKenney" , Nick Desaulniers , clang-built-linux@googlegroups.com, kernel-hardening@lists.openwall.com, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v2 05/28] objtool: Add a pass for generating __mcount_loc Message-ID: <202009031450.31C71DB@keescook> References: <20200624203200.78870-1-samitolvanen@google.com> <20200903203053.3411268-1-samitolvanen@google.com> <20200903203053.3411268-6-samitolvanen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200903203053.3411268-6-samitolvanen@google.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 03, 2020 at 01:30:30PM -0700, Sami Tolvanen wrote: > From: Peter Zijlstra > > Add the --mcount option for generating __mcount_loc sections > needed for dynamic ftrace. Using this pass requires the kernel to > be compiled with -mfentry and CC_USING_NOP_MCOUNT to be defined > in Makefile. > > Link: https://lore.kernel.org/lkml/20200625200235.GQ4781@hirez.programming.kicks-ass.net/ > Signed-off-by: Peter Zijlstra Hmm, I'm not sure why this hasn't gotten picked up yet. Is this expected to go through -tip or something else? Reviewed-by: Kees Cook -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8566CC43461 for ; Thu, 3 Sep 2020 21:52:41 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4A7D020678 for ; Thu, 3 Sep 2020 21:52:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="W1Ihd8MY"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="ZyZZKeIp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4A7D020678 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QLfcU9h1Do5U3FjjHpCAA3/KiudP+G5Uj6EU3aK00L4=; b=W1Ihd8MY/M3j5UFiLBDjfjZy5 RuwhvzjpzHqangF5l7rFMazSlII/kkVwnksscOYkICPKvNDnsxwFL5h4OnVdvh3T6qYVenxRH2y/M l9rfQLITQNXtoR9Ei4dVDgCrhXtNe4z82z37N5qDbYRQ5BmW7l5+anJX4YKLCKCK9g4wG+Ms/7rAD Wcm+JR5ZswovLgGItKvJmgVBL9SScAnR9bd2VhfYjQiWVX0lnc0YRy/tSq3F/E8UxY/FJ2EzLcgkX QDM4MGwNowcEYZ24rHRlJJwTrdW5/e2FGEC8d8uq+ZeW1q5j8lu8AcG05eybuBs78K4QLktnGrwIv 5gmdptCwg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDx8Y-0003mn-Jc; Thu, 03 Sep 2020 21:51:18 +0000 Received: from mail-pj1-x1041.google.com ([2607:f8b0:4864:20::1041]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDx8V-0003lR-21 for linux-arm-kernel@lists.infradead.org; Thu, 03 Sep 2020 21:51:16 +0000 Received: by mail-pj1-x1041.google.com with SMTP id k15so2203520pji.3 for ; Thu, 03 Sep 2020 14:51:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=qXpu71ctdlh3mEQbznjWlLLlQUw5P2bBw2F3vq4Wzjo=; b=ZyZZKeIpcpI80+hejxzxlgql178wdYHMLgxxEcNsZP5DgNheiVVnTG3N+eHQ6nQdTA Niu4Mm24mQzd8zXiPCHvu1WgPl9pvcZLM7dK+CVMgSnMSoSLzj6aaeKFz4fN5yjD378D otR7uM4FcmoQ6MxJYzFRJSwnOdQ8bNb3OFeq4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=qXpu71ctdlh3mEQbznjWlLLlQUw5P2bBw2F3vq4Wzjo=; b=ocWfFaBWZTqF5J1W3igbFJil/wUODtta0fLnsbZkAi4YqzpHkfUl1x9xcQvQoQF7Dn EycCBBtOquJ+2lyEKum7PLTnz70LoQhqmfFiGaF4gQuFg+16PJZuM+6Lbu98n6lInz5N 4UUrE7pvk5/f0RyMtGJQ+yYv/mJlUHcSa/zjc3A7dExqua88/CCBEi5f3fmcIWTNREEE Gr2dC0WkeLN0nNVC9NJYJtC4nQW0pIpqWJVsd78ru2B8PrwqmKetOf6n6m/2ZdRgaxbn cqO5Z45sYLL3drcvSru8pwkNU4uVod3JKY/XBYqkFfi+G1KQVUC4sns+xM78vY919Eev pajQ== X-Gm-Message-State: AOAM5338ugKe3h/CiJgp7vicXpqtV45azKHtzzHuF8OXI09FMvQeSAZv wDWWiPQxuIqygZ+YHs85Tuprlg== X-Google-Smtp-Source: ABdhPJykQhA773Y/RsqqBh6IkXbjxUAGr+2WNPNkmamwrqnCASrzuPNLdRBsNJk4iZWq6CDQhSD6fA== X-Received: by 2002:a17:90a:950a:: with SMTP id t10mr5013648pjo.107.1599169872611; Thu, 03 Sep 2020 14:51:12 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id h15sm3019108pfo.23.2020.09.03.14.51.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Sep 2020 14:51:11 -0700 (PDT) Date: Thu, 3 Sep 2020 14:51:10 -0700 From: Kees Cook To: Sami Tolvanen Subject: Re: [PATCH v2 05/28] objtool: Add a pass for generating __mcount_loc Message-ID: <202009031450.31C71DB@keescook> References: <20200624203200.78870-1-samitolvanen@google.com> <20200903203053.3411268-1-samitolvanen@google.com> <20200903203053.3411268-6-samitolvanen@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200903203053.3411268-6-samitolvanen@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200903_175115_159200_35FF15C7 X-CRM114-Status: GOOD ( 15.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, x86@kernel.org, "Paul E. McKenney" , kernel-hardening@lists.openwall.com, Peter Zijlstra , Greg Kroah-Hartman , Masahiro Yamada , linux-kbuild@vger.kernel.org, Nick Desaulniers , linux-kernel@vger.kernel.org, Steven Rostedt , clang-built-linux@googlegroups.com, linux-pci@vger.kernel.org, Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 03, 2020 at 01:30:30PM -0700, Sami Tolvanen wrote: > From: Peter Zijlstra > > Add the --mcount option for generating __mcount_loc sections > needed for dynamic ftrace. Using this pass requires the kernel to > be compiled with -mfentry and CC_USING_NOP_MCOUNT to be defined > in Makefile. > > Link: https://lore.kernel.org/lkml/20200625200235.GQ4781@hirez.programming.kicks-ass.net/ > Signed-off-by: Peter Zijlstra Hmm, I'm not sure why this hasn't gotten picked up yet. Is this expected to go through -tip or something else? Reviewed-by: Kees Cook -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel