From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8AF4C43461 for ; Thu, 3 Sep 2020 22:45:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7E62B20716 for ; Thu, 3 Sep 2020 22:45:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Zx5KJ4dv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729464AbgICWpj (ORCPT ); Thu, 3 Sep 2020 18:45:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729458AbgICWpe (ORCPT ); Thu, 3 Sep 2020 18:45:34 -0400 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B1DCDC061247 for ; Thu, 3 Sep 2020 15:45:33 -0700 (PDT) Received: by mail-pf1-x443.google.com with SMTP id 17so3493762pfw.9 for ; Thu, 03 Sep 2020 15:45:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=LpH2+c3Q5/rnXgDQMsrsJ9HiSsfoyzj1qvyyccEruIs=; b=Zx5KJ4dvVR2kYJ0RF1K2y79qhIcjc7yrsCRJoTz5s2zCxiKL8II6gShD3dRiuI5JuE CAqlIg/RCYIqxwgBTCdJCoxlCyAR33IC7dws/kSOZM0OWTmWQqku5KG5vBN3wHaXWX2J L3kWlvlx6YmS4Z9tOt3VwHxiD169ei5sQPoz8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=LpH2+c3Q5/rnXgDQMsrsJ9HiSsfoyzj1qvyyccEruIs=; b=SjRYMp0DJVfG19KD1ahUci288tP97AELRwt9MBCv8jQicvCWWzTX5Xgq9NdLj8YehX 3TCwBH8bsbJJwxfemvarHQS0nUoxCfD5nytj0y/Io2uC+CYkkz8pUiFLuW5J03QPdrSb +CsutqPz7G6E5cG6PSl44eo93YgVkDLcfhCJK5tDxd8bN6VxZMjafBW+JSNZfou3uIvi QB54MwpQ0YX0Lrv73OlQFpTcG4nvjZ9oCR+ypjbSN0edPn3GayDCxwATuTnWCPtXPnll A6wHOf53J92X8d0UEFegevg3rX/F20kxQ8RpEOv6+RARb0i7bQLFDAa75oQLpFht5SYb K5nQ== X-Gm-Message-State: AOAM533nz0BDWIUX31IZyl7Cp+0DR6sFvgTaegcnMbqAjPOrHVXwEGHE 2BvkVXDBS9PbNL2G/ZcEwnVt7Q== X-Google-Smtp-Source: ABdhPJw+gsOOUY6Clu21aqvi2zeFtbK32caDaCf93/U25KjvZIefQe4UypsHJhKhOKzenMYzI/0+7Q== X-Received: by 2002:a17:902:82c7:: with SMTP id u7mr1398150plz.240.1599173133340; Thu, 03 Sep 2020 15:45:33 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id r123sm4320262pfc.187.2020.09.03.15.45.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Sep 2020 15:45:32 -0700 (PDT) Date: Thu, 3 Sep 2020 15:45:31 -0700 From: Kees Cook To: Sami Tolvanen Cc: Masahiro Yamada , Will Deacon , Peter Zijlstra , Steven Rostedt , Greg Kroah-Hartman , "Paul E. McKenney" , Nick Desaulniers , clang-built-linux@googlegroups.com, kernel-hardening@lists.openwall.com, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v2 24/28] KVM: arm64: disable LTO for the nVHE directory Message-ID: <202009031545.42ECDC8F7F@keescook> References: <20200624203200.78870-1-samitolvanen@google.com> <20200903203053.3411268-1-samitolvanen@google.com> <20200903203053.3411268-25-samitolvanen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200903203053.3411268-25-samitolvanen@google.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 03, 2020 at 01:30:49PM -0700, 'Sami Tolvanen' via Clang Built Linux wrote: > We use objcopy to manipulate ELF binaries for the nvhe code, > which fails with LTO as the compiler produces LLVM bitcode > instead. Disable LTO for this code to allow objcopy to be used. > > Signed-off-by: Sami Tolvanen Reviewed-by: Kees Cook -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64681C433E2 for ; Thu, 3 Sep 2020 22:46:58 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1AFC020716 for ; Thu, 3 Sep 2020 22:46:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="r1tjfVvA"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Zx5KJ4dv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1AFC020716 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hhuac9WOOFyTDxkm6xv+evXx2FQ5TOJNMyLAsktKiPw=; b=r1tjfVvAfLRg1WVSHh4FePJq+ /h9zEIeoHeWwTlHg1S/vq+j4NoDwDwZ9NBWrZzy32ZhbhseV82op8nF1gWmQDNozPp2xkZwsfpwq4 GbZU405VCJ2nKhcliBU8Mqbmd14fNED91h0ta3FlelrhXPbIYHX/NVwPc6f6+NZGcHXdZBAWM965G 4McjTxtqGJCnAMU9ri8EFRRTbKhuUe3DP9DKICw4WJ/unTz8esHLUD2T3ZJeDyZDt3BxT7wquINn8 xs8kXbxzgPa+QbOaX2BYTOnwGZ8aZt2IL4QVWJfhCqlqEyay+KhJ4+WtClXfGpEC0nG5W3UMy+8cO SRvE1WV8w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDxzA-0003KI-12; Thu, 03 Sep 2020 22:45:40 +0000 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDxz5-0003HP-CW for linux-arm-kernel@lists.infradead.org; Thu, 03 Sep 2020 22:45:37 +0000 Received: by mail-pf1-x442.google.com with SMTP id d22so3504040pfn.5 for ; Thu, 03 Sep 2020 15:45:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=LpH2+c3Q5/rnXgDQMsrsJ9HiSsfoyzj1qvyyccEruIs=; b=Zx5KJ4dvVR2kYJ0RF1K2y79qhIcjc7yrsCRJoTz5s2zCxiKL8II6gShD3dRiuI5JuE CAqlIg/RCYIqxwgBTCdJCoxlCyAR33IC7dws/kSOZM0OWTmWQqku5KG5vBN3wHaXWX2J L3kWlvlx6YmS4Z9tOt3VwHxiD169ei5sQPoz8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=LpH2+c3Q5/rnXgDQMsrsJ9HiSsfoyzj1qvyyccEruIs=; b=mCDWwi2xghFYuEZKx47BVVFrfMTeLUlLOnnNOEB3tUkrejBs+l8JvaNZu2TbubXbou AGXkzvFeBhPHvLkF2/9LGba+A4ZEONc3X1m9xvLtxKsfymks9XDE1U1P2EhY96pE4DUR FJ79eddR47ZL6HJVGT+UxbWpP4p4IkDZ7xi+8ybOwE24io3rwiKnuQOTpE5GfTxkaKJT 36bn+2IjjjXoibtKHyd9ql2BMn1JDr3e7cVpcD4aDQDNDAkBbgYGpcT1BsWZJaIMuh5C /vg3HRW3WtC5W7vw9ptkgZmVymlISMzo9FCQMGqh2Njnl2dmFVl4T7kWvQoMgQ9V+8W2 IGzA== X-Gm-Message-State: AOAM532M5+BIC2o7lrtseAR5ObLTsa7aGNLSSeGOSgFs6kZfPcGy7y7J lXGNHCLB3uHprjZpNtq3wF3+WA== X-Google-Smtp-Source: ABdhPJw+gsOOUY6Clu21aqvi2zeFtbK32caDaCf93/U25KjvZIefQe4UypsHJhKhOKzenMYzI/0+7Q== X-Received: by 2002:a17:902:82c7:: with SMTP id u7mr1398150plz.240.1599173133340; Thu, 03 Sep 2020 15:45:33 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id r123sm4320262pfc.187.2020.09.03.15.45.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Sep 2020 15:45:32 -0700 (PDT) Date: Thu, 3 Sep 2020 15:45:31 -0700 From: Kees Cook To: Sami Tolvanen Subject: Re: [PATCH v2 24/28] KVM: arm64: disable LTO for the nVHE directory Message-ID: <202009031545.42ECDC8F7F@keescook> References: <20200624203200.78870-1-samitolvanen@google.com> <20200903203053.3411268-1-samitolvanen@google.com> <20200903203053.3411268-25-samitolvanen@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200903203053.3411268-25-samitolvanen@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200903_184535_475843_8BA1781C X-CRM114-Status: GOOD ( 13.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, x86@kernel.org, "Paul E. McKenney" , kernel-hardening@lists.openwall.com, Peter Zijlstra , Greg Kroah-Hartman , Masahiro Yamada , linux-kbuild@vger.kernel.org, Nick Desaulniers , linux-kernel@vger.kernel.org, Steven Rostedt , clang-built-linux@googlegroups.com, linux-pci@vger.kernel.org, Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 03, 2020 at 01:30:49PM -0700, 'Sami Tolvanen' via Clang Built Linux wrote: > We use objcopy to manipulate ELF binaries for the nvhe code, > which fails with LTO as the compiler produces LLVM bitcode > instead. Disable LTO for this code to allow objcopy to be used. > > Signed-off-by: Sami Tolvanen Reviewed-by: Kees Cook -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel