From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D76F2C43461 for ; Thu, 3 Sep 2020 22:47:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 86EA920716 for ; Thu, 3 Sep 2020 22:47:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="UyJevSS3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729405AbgICWrj (ORCPT ); Thu, 3 Sep 2020 18:47:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728309AbgICWrf (ORCPT ); Thu, 3 Sep 2020 18:47:35 -0400 Received: from mail-pj1-x1041.google.com (mail-pj1-x1041.google.com [IPv6:2607:f8b0:4864:20::1041]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5D56C061246 for ; Thu, 3 Sep 2020 15:47:34 -0700 (PDT) Received: by mail-pj1-x1041.google.com with SMTP id g6so2162555pjl.0 for ; Thu, 03 Sep 2020 15:47:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=eFrstCXBN3HfrZebeISGA36KawHO68DuV5H+8+oCMrk=; b=UyJevSS3jZbv6N7QB5+swtwOzbQH8Mebfc6NiguMHEEa3zpvf2Fa8BOPsjRPafItrX 94+boIdY0eIFAYNargKYhKvUD4q+qsol+8WhYmSNTTfQeUzQx66molHRZp0VKRR4pNjd TeTJKO1SkL6fNUa/+nF94zP8Ps5d09zjKGzZ8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=eFrstCXBN3HfrZebeISGA36KawHO68DuV5H+8+oCMrk=; b=EB9YzfysEOFXCIIEpjAolPtQ/wrgnBc03iZ7yNWoJkXAfmIdt2ifw1NmTjuXaxyukl sYRRpP/CDSoV/1SFW7Mdfg7J986of6K1f83KBZD+8ILVT5NzURly/JPUaI+Q/Ahav6J+ qlb8yxdVbW6Cuass1oHdnN78zoMtAuJ/3diyojkCbRo3d0gsjNkm0lzSCqGK4d1ywDYT AGvHX51ZAQHMX2QKfO6cnwQfaydabA1sYYyLxttlMBePDp/B48qmTU147oWLxTosNf7A npAS/S/+4RJN+OT4hD1COnmZXOzO7R75Zl98spPVvgNh+E25+XINyMrME4IjbN/dICtd NtLg== X-Gm-Message-State: AOAM533GlFuSJMCNlIrkTWIfrKtRonHb3JrPKp3ya2+h9vfMZ9ChYCBr pWU5SgwAbwKVt8dhVQno7qJQEQ== X-Google-Smtp-Source: ABdhPJxBUddtcfqLuFrofAmKe3Wkr2dCSnES8MsReM+zYAT8LfVgd6BWIelLMAoy/r1/rEVW2WoePA== X-Received: by 2002:a17:90b:889:: with SMTP id bj9mr5382384pjb.101.1599173254469; Thu, 03 Sep 2020 15:47:34 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id s198sm3700589pgc.4.2020.09.03.15.47.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Sep 2020 15:47:33 -0700 (PDT) Date: Thu, 3 Sep 2020 15:47:32 -0700 From: Kees Cook To: Sami Tolvanen Cc: Masahiro Yamada , Will Deacon , Peter Zijlstra , Steven Rostedt , Greg Kroah-Hartman , "Paul E. McKenney" , Nick Desaulniers , clang-built-linux@googlegroups.com, kernel-hardening@lists.openwall.com, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v2 27/28] x86, relocs: Ignore L4_PAGE_OFFSET relocations Message-ID: <202009031546.4854633F7@keescook> References: <20200624203200.78870-1-samitolvanen@google.com> <20200903203053.3411268-1-samitolvanen@google.com> <20200903203053.3411268-28-samitolvanen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200903203053.3411268-28-samitolvanen@google.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 03, 2020 at 01:30:52PM -0700, Sami Tolvanen wrote: > L4_PAGE_OFFSET is a constant value, so don't warn about absolute > relocations. > > Signed-off-by: Sami Tolvanen Any other details on this? I assume this is an ld.lld-ism. Any idea why this is only a problem under LTO? (Or is this an LLVM integrated assembler-ism?) Regardless, yes, let's nail it down: Reviewed-by: Kees Cook -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D990C433E2 for ; Thu, 3 Sep 2020 22:48:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D3B0720716 for ; Thu, 3 Sep 2020 22:48:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="v95kMSgp"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="UyJevSS3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D3B0720716 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9iUpwg5mw1u/cZN4XwflOoFkfyhrKlkkcsTEIYChBpk=; b=v95kMSgpVIqA4aGCvOA42vtqo 8kjyrmooKmcAzvXQU8BYL1ogblaee5r0NlHulPBlpkchKc1dHqeXKeAwo/YCCvIm+Fy9HXNRLPDwM RbFXZKmpAtKvzyfvecB/wWg2HeY6Sa0IPcHgNkDcgIhR4v07qMuJLiyA/1XLT0bNOBclWd8K5LEqF wPA0k43iu+cFNMgcxK5st3OMvkfoUUFO0w7xaggLsf4IHWXMFWIPrIvUR4N3erUeEZPgwug+8R5nB Pl5FoTJ3op/cjoe8AAOpVLKSrmhSWdi8xrQpxqPGjkSXaI/b8jSovJzo+Z6n6wyZHfvGategeh4v6 MScMk3W3Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDy18-0004E2-RD; Thu, 03 Sep 2020 22:47:42 +0000 Received: from mail-pj1-x1043.google.com ([2607:f8b0:4864:20::1043]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDy12-0004BB-D5 for linux-arm-kernel@lists.infradead.org; Thu, 03 Sep 2020 22:47:38 +0000 Received: by mail-pj1-x1043.google.com with SMTP id mw10so2156760pjb.2 for ; Thu, 03 Sep 2020 15:47:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=eFrstCXBN3HfrZebeISGA36KawHO68DuV5H+8+oCMrk=; b=UyJevSS3jZbv6N7QB5+swtwOzbQH8Mebfc6NiguMHEEa3zpvf2Fa8BOPsjRPafItrX 94+boIdY0eIFAYNargKYhKvUD4q+qsol+8WhYmSNTTfQeUzQx66molHRZp0VKRR4pNjd TeTJKO1SkL6fNUa/+nF94zP8Ps5d09zjKGzZ8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=eFrstCXBN3HfrZebeISGA36KawHO68DuV5H+8+oCMrk=; b=bovI0sZjbS12h+0ulrYQF9BclG0oltX7hDl/uW2H7KjNED5vcvQnRfijXb5DTzDJsW dLbCuRxi9GrD9OfT1YazqmuSMiltSEY8o065w++9hkr67D/iK1tB6NNMwPmgLxubE8dZ zAMEe/F/X6sLpjJaSe/3PPs2rBRFpoWiC751dRN1iNlmrnSYsEsDwx4GhZs6rfQ+fHxs j1oGwLotKTkNGYLCS566y6W8nLGzhx/nY1ahWHeaYxoYLFLfrWM5jlGP1q/P7WzccpQ8 D7dj6dMyTYmYTqrjf2Gl0QmTTb5jzAJrbBRyuM9nn/e6IshQZl4htGoP9MvQPe/wg2P0 0ttg== X-Gm-Message-State: AOAM531tsptZo4SOt8aZI28rehAceRSxfDIari/deBt3UH7xwqI9K3ZN BgpUdjaNEo4u4C3cXdwzrhTqKA== X-Google-Smtp-Source: ABdhPJxBUddtcfqLuFrofAmKe3Wkr2dCSnES8MsReM+zYAT8LfVgd6BWIelLMAoy/r1/rEVW2WoePA== X-Received: by 2002:a17:90b:889:: with SMTP id bj9mr5382384pjb.101.1599173254469; Thu, 03 Sep 2020 15:47:34 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id s198sm3700589pgc.4.2020.09.03.15.47.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Sep 2020 15:47:33 -0700 (PDT) Date: Thu, 3 Sep 2020 15:47:32 -0700 From: Kees Cook To: Sami Tolvanen Subject: Re: [PATCH v2 27/28] x86, relocs: Ignore L4_PAGE_OFFSET relocations Message-ID: <202009031546.4854633F7@keescook> References: <20200624203200.78870-1-samitolvanen@google.com> <20200903203053.3411268-1-samitolvanen@google.com> <20200903203053.3411268-28-samitolvanen@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200903203053.3411268-28-samitolvanen@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200903_184736_526336_6761CA32 X-CRM114-Status: GOOD ( 13.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, x86@kernel.org, "Paul E. McKenney" , kernel-hardening@lists.openwall.com, Peter Zijlstra , Greg Kroah-Hartman , Masahiro Yamada , linux-kbuild@vger.kernel.org, Nick Desaulniers , linux-kernel@vger.kernel.org, Steven Rostedt , clang-built-linux@googlegroups.com, linux-pci@vger.kernel.org, Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 03, 2020 at 01:30:52PM -0700, Sami Tolvanen wrote: > L4_PAGE_OFFSET is a constant value, so don't warn about absolute > relocations. > > Signed-off-by: Sami Tolvanen Any other details on this? I assume this is an ld.lld-ism. Any idea why this is only a problem under LTO? (Or is this an LLVM integrated assembler-ism?) Regardless, yes, let's nail it down: Reviewed-by: Kees Cook -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel