From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2378AC43461 for ; Thu, 3 Sep 2020 22:46:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DB24B20716 for ; Thu, 3 Sep 2020 22:46:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="oZ5KzCEi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729589AbgICWqT (ORCPT ); Thu, 3 Sep 2020 18:46:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729579AbgICWqL (ORCPT ); Thu, 3 Sep 2020 18:46:11 -0400 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91540C061247 for ; Thu, 3 Sep 2020 15:46:11 -0700 (PDT) Received: by mail-pg1-x544.google.com with SMTP id p37so3282031pgl.3 for ; Thu, 03 Sep 2020 15:46:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=5TqmD5EyVPuB9TiyITqacSmLzI3cDbmlqWUeyi+ujCg=; b=oZ5KzCEi7wKIrEEj86amUMkUmItIM2KtyMb6kJV1Bx2j+6SLbFuob0rHAOq9f5nYH0 BvcS2/vu4CZRFtoI7y0Mt062eAYVzZTqZzFG2Iu7rRRlhQSIXmNmKgue9t4cr4gsNbj6 cT+JilU0DZpxA7uH2zokAyWWmg9TpkmIfF0Qk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5TqmD5EyVPuB9TiyITqacSmLzI3cDbmlqWUeyi+ujCg=; b=TN67mGuHvtEnnHK4MuOFvTsBO+vhxnMGz1mIE406D8ynhKGhp2ezFE5EwUEFwr/SnW ahc7ukZiMxhXZQy0ZstW68zgsmcUoS/NMx7AisfJxRoXGXFj4WHv3nz5Iqr/keFvSUZS m/dEWGYt6WCWUCn5+bvYo5vOYBp4SqFNFLsA41lAFvot9l+s5huEspjxe/KahQPQSjZv +tWwkps7H70kGJfYfXoiZdsFUefD1ihf+pwgSwhAz5ozp3YyGjhQ0LG73ZddzFIQeZ2Y ccX5x9JTS5Aglc31o+u6hiEKeDQnADGxMDtOFob7Ql1wprwCYKKQah5PpyYipRCmAiHs teGw== X-Gm-Message-State: AOAM533bSuOxCmroNjwrtfeYpuwEy+6KQtgkE/8auMF364aV1HHProRQ 19Nk3d9RvCZL2HbgdX+Cpr8roA== X-Google-Smtp-Source: ABdhPJz0Cu4W/SGUiAG+2DPCBbmeCYnLc7352WExRrDx24NF8XVfzJeuLOmeQkS8ntOwly5Q8T3lkw== X-Received: by 2002:a63:ca12:: with SMTP id n18mr4721941pgi.371.1599173171199; Thu, 03 Sep 2020 15:46:11 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id b18sm3633660pgk.36.2020.09.03.15.46.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Sep 2020 15:46:10 -0700 (PDT) Date: Thu, 3 Sep 2020 15:46:09 -0700 From: Kees Cook To: Sami Tolvanen Cc: Masahiro Yamada , Will Deacon , Peter Zijlstra , Steven Rostedt , Greg Kroah-Hartman , "Paul E. McKenney" , Nick Desaulniers , clang-built-linux@googlegroups.com, kernel-hardening@lists.openwall.com, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v2 26/28] x86, vdso: disable LTO only for vDSO Message-ID: <202009031546.98CA2EF4@keescook> References: <20200624203200.78870-1-samitolvanen@google.com> <20200903203053.3411268-1-samitolvanen@google.com> <20200903203053.3411268-27-samitolvanen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200903203053.3411268-27-samitolvanen@google.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 03, 2020 at 01:30:51PM -0700, Sami Tolvanen wrote: > Remove the undefined DISABLE_LTO flag from the vDSO, and filter out > CC_FLAGS_LTO flags instead where needed. Note that while we could use > Clang's LTO for the 64-bit vDSO, it won't add noticeable benefit for > the small amount of C code. > > Signed-off-by: Sami Tolvanen Moar DISABLE_LTO... Reviewed-by: Kees Cook -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34555C43461 for ; Thu, 3 Sep 2020 22:47:34 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D921520716 for ; Thu, 3 Sep 2020 22:47:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oQ5JDM8v"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="oZ5KzCEi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D921520716 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/TaeLvC1OvaQFVy5wOZMFot53KGIO/0jpWP6rEU2Z7k=; b=oQ5JDM8vGX2uBXe6KENDdFfXa 6iAU4xX8zUS3tabyjHuhzijDWCRrvsdYfV3Gyd1XoN7XdRucg2+f3yrriL6E2uXOl+0NrYnloOUNX EON4Kb+WoMrRUT7tangFoX8fUJShzNp5AZzRhn2J44Rx/KsTDBsN4Jc7PCANsESXXQFeeVf8GK8xb oAfDNAyfUGyugDmsmMsE9vYo9dGIQDhjv4Ck/6mSYIHv/2E5zlMSWmcmoJWQSWi4GDo/w9F191UTd 00A0BXIBunMc5fGbrFzKD8u8J8qPlzBp7SRWc1TZvMhacgQNm8mjyjgltCQpqJskTchQcNRlajzQC ArHwryqcA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDxzo-0003ch-N1; Thu, 03 Sep 2020 22:46:20 +0000 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDxzg-0003ZK-WE for linux-arm-kernel@lists.infradead.org; Thu, 03 Sep 2020 22:46:14 +0000 Received: by mail-pf1-x442.google.com with SMTP id u20so3528028pfn.0 for ; Thu, 03 Sep 2020 15:46:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=5TqmD5EyVPuB9TiyITqacSmLzI3cDbmlqWUeyi+ujCg=; b=oZ5KzCEi7wKIrEEj86amUMkUmItIM2KtyMb6kJV1Bx2j+6SLbFuob0rHAOq9f5nYH0 BvcS2/vu4CZRFtoI7y0Mt062eAYVzZTqZzFG2Iu7rRRlhQSIXmNmKgue9t4cr4gsNbj6 cT+JilU0DZpxA7uH2zokAyWWmg9TpkmIfF0Qk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5TqmD5EyVPuB9TiyITqacSmLzI3cDbmlqWUeyi+ujCg=; b=rItb0gcUhiaem3sQuCTz3EZx/PywcOzItOyFGxWQFUCAQ7ByXvrdCPLN6f0VsXOwx+ Xjs4/9FpcNtLy6lWtj9VQHFwoBbzHQmOnJ0eDNUdxK+iXcD0XD1AF6TAb/HQ1OMYhLH0 VanuCAbW4kz716QqqFufUoaPE4P45Xv6brM7vxbrv0pziqsDnLpNI6Eg9mk5EcgdIleS 9GXjNsxxbZekDRPVcl9zvqApwBxoVsfpXWxxZ75ftgRk6PzV88Mu/B/wmCE8uwiCbLu1 HGYhC1KBW3YVg7EVOfzwbchlbsS6TmXXyKjWgDnP9SSC6WQO6+cHPtVVs9cKeg8hJIgn te9Q== X-Gm-Message-State: AOAM531uiGWY4lRwWrUY4Hpjf0MQsOE1XP7V+GwfFVO10Tav4F5yq7Ua /kKnzcfo+2pK/hS4zi9FqrTfIw== X-Google-Smtp-Source: ABdhPJz0Cu4W/SGUiAG+2DPCBbmeCYnLc7352WExRrDx24NF8XVfzJeuLOmeQkS8ntOwly5Q8T3lkw== X-Received: by 2002:a63:ca12:: with SMTP id n18mr4721941pgi.371.1599173171199; Thu, 03 Sep 2020 15:46:11 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id b18sm3633660pgk.36.2020.09.03.15.46.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Sep 2020 15:46:10 -0700 (PDT) Date: Thu, 3 Sep 2020 15:46:09 -0700 From: Kees Cook To: Sami Tolvanen Subject: Re: [PATCH v2 26/28] x86, vdso: disable LTO only for vDSO Message-ID: <202009031546.98CA2EF4@keescook> References: <20200624203200.78870-1-samitolvanen@google.com> <20200903203053.3411268-1-samitolvanen@google.com> <20200903203053.3411268-27-samitolvanen@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200903203053.3411268-27-samitolvanen@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200903_184613_076452_B6162FEB X-CRM114-Status: GOOD ( 12.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, x86@kernel.org, "Paul E. McKenney" , kernel-hardening@lists.openwall.com, Peter Zijlstra , Greg Kroah-Hartman , Masahiro Yamada , linux-kbuild@vger.kernel.org, Nick Desaulniers , linux-kernel@vger.kernel.org, Steven Rostedt , clang-built-linux@googlegroups.com, linux-pci@vger.kernel.org, Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 03, 2020 at 01:30:51PM -0700, Sami Tolvanen wrote: > Remove the undefined DISABLE_LTO flag from the vDSO, and filter out > CC_FLAGS_LTO flags instead where needed. Note that while we could use > Clang's LTO for the 64-bit vDSO, it won't add noticeable benefit for > the small amount of C code. > > Signed-off-by: Sami Tolvanen Moar DISABLE_LTO... Reviewed-by: Kees Cook -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel