From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62DD8C43461 for ; Fri, 4 Sep 2020 07:40:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2C6E020748 for ; Fri, 4 Sep 2020 07:40:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726575AbgIDHkW (ORCPT ); Fri, 4 Sep 2020 03:40:22 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:42610 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726089AbgIDHkW (ORCPT ); Fri, 4 Sep 2020 03:40:22 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1kE6KK-0000Lo-9Q; Fri, 04 Sep 2020 17:40:05 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 04 Sep 2020 17:40:04 +1000 Date: Fri, 4 Sep 2020 17:40:04 +1000 From: Herbert Xu To: "shenyang (M)" Cc: David Laight , "davem@davemloft.net" , "linux-kernel@vger.kernel.org" , "linux-crypto@vger.kernel.org" , "xuzaibo@huawei.com" , "wangzhou1@hisilicon.com" Subject: Re: [PATCH RESEND 04/10] crypto: hisilicon/zip - replace 'sprintf' with 'scnprintf' Message-ID: <20200904074004.GA24815@gondor.apana.org.au> References: <1598238709-58699-1-git-send-email-shenyang39@huawei.com> <1598238709-58699-5-git-send-email-shenyang39@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Wed, Aug 26, 2020 at 04:56:40PM +0800, shenyang (M) wrote: > > > > @@ -514,13 +514,16 @@ static int hisi_zip_core_debug_init(struct hisi_qm *qm) > > > struct debugfs_regset32 *regset; > > > struct dentry *tmp_d; > > > char buf[HZIP_BUF_SIZE]; > > > - int i; > > > + int i, ret; > > > > > > for (i = 0; i < HZIP_CORE_NUM; i++) { > > > if (i < HZIP_COMP_CORE_NUM) > > > - sprintf(buf, "comp_core%d", i); > > > + ret = scnprintf(buf, HZIP_BUF_SIZE, "comp_core%d", i); > > > else > > > - sprintf(buf, "decomp_core%d", i - HZIP_COMP_CORE_NUM); > > > + ret = scnprintf(buf, HZIP_BUF_SIZE, "decomp_core%d", > > > + i - HZIP_COMP_CORE_NUM); > > > + if (!ret) > > > + return -ENOMEM; > > > > and that is just so wrong - did you even try to test > > the 'buffer too small' code path? > > Do you means the check is unnecessary? No he's saying that your patch does the wrong thing when the string is truncated. Also ENOMEM is a strange error for that case. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt