From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEC30C43461 for ; Fri, 4 Sep 2020 09:20:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9C2202067C for ; Fri, 4 Sep 2020 09:20:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599211240; bh=tfvwXFZiU3UT3uCBI0eVIiaDepEZKUtj+JOTXPnmFsw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=CSIspDAOe2uc20zAJbtiB8ImRmb8Uy0dSNG1KmW0o2mDIbgvOMuOD+SiUq3uQSAjy 5PxA3V/c0bbkKid6H9kGrjoD6gN3xQlSmgX8lTdXfaCjt6Zj+VAIcxZ7675mCLCnca kmk69T6UyDERbNztGfIayClZfa6BcX0gABq4M0DE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730051AbgIDJUj (ORCPT ); Fri, 4 Sep 2020 05:20:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:42446 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729628AbgIDJUg (ORCPT ); Fri, 4 Sep 2020 05:20:36 -0400 Received: from localhost (p5486cda5.dip0.t-ipconnect.de [84.134.205.165]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E6D5E2067C; Fri, 4 Sep 2020 09:20:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599211235; bh=tfvwXFZiU3UT3uCBI0eVIiaDepEZKUtj+JOTXPnmFsw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JVTj/hYdti7ZOguNrnw2iuzyeMxhWiP8cgeuhOAht8F02N5gmhfh2HxDDvcQj107h 4ifFx6nxVFzUesF8iXxBLPLKWUAw3BEtopz+mFS72Nmhnet+ySsDq2UKZsnxzsh6UB ZLbw9GgVbEuLg/2GWAziBor2k7pJGg1pgBqGVI3U= Date: Fri, 4 Sep 2020 11:20:32 +0200 From: Wolfram Sang To: Codrin.Ciubotariu@microchip.com, Geert Uytterhoeven Cc: linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org, Ludovic.Desroches@microchip.com, Nicolas.Ferre@microchip.com, alexandre.belloni@bootlin.com, linux@armlinux.org.uk, kamel.bouhara@bootlin.com Subject: Re: Re: Re: [RFC PATCH 4/4] i2c: at91: Move to generic GPIO bus recovery Message-ID: <20200904092032.GA32080@ninjato> References: <20200619141904.910889-1-codrin.ciubotariu@microchip.com> <20200619141904.910889-5-codrin.ciubotariu@microchip.com> <20200802170820.GC10193@kunai> <65890aab-1d19-7e7e-abff-3c6ee05c8ade@microchip.com> <20200826061444.GB1081@ninjato> <15466c95-f1ea-63a4-1429-24d9b7567c1c@microchip.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="WIyZ46R2i8wDzkSu" Content-Disposition: inline In-Reply-To: <15466c95-f1ea-63a4-1429-24d9b7567c1c@microchip.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --WIyZ46R2i8wDzkSu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Codrin, > The pinmux driver needs to have strict set to false, otherwise the=20 > switching is not available, not at this time at least. Perhaps there is= =20 > room for improvement here, because the I2C bus is not using the pins=20 > while we are doing GPIO recovery. Our driver doesn't use 'strict'. The thing is that I can't describe a pinctrl state for GPIO. GPIO is the default state until another function is requested. Back to GPIO currently means freeing the pin again, so it defaults back to GPIO. We are currently discussing it. Geert (CCed) isn't very happy of describing the same pins with 'function =3D "gpio"' because the Kernel already knows the mapping, just needs to revert it. Geert, please correct me if I am wrong. > I am not sure I'll have time the next week to work on what you asked me= =20 > regarding sh_mobile and PXA, but I will look into it the week after that. > Sorry about my delayed reply, I was on vacation. Well, no need for sh_mobile, this is my todo item :) About PXA, well, I am still happy that you volunteered to do it, so I hope you had a relaxing vacation! Happy hacking, Wolfram --WIyZ46R2i8wDzkSu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAl9SBtwACgkQFA3kzBSg KbZeWw//e8idK/UaDDNoa1ayZzCtU5zt8qZiIxCEia10pmFsfb1uZkJ4nyybcIT2 FcpsGjUsrDCWvVEu+3hAyILntIJF8949WUK7K7JhqMeH9o3T7ZJeUEgK7cB0o9s5 wrjs2WMvBjP1TaPW2LhcAAlP3q4/Qy+4xQ6SpjLzQsTeNtv643vWo15V5lOUHjuK 0s/VCmZtnrqvRXsbjrzAIk+XZ+m7IhWgNDY6MUfO7gxDCWq8q+KRcncBaHNopCIi wYGq2KReTYQ/nA+ACytH/SsiQvmXoYdfEiN6K1WnXviu0XwtkG1yTQPtpBetvpS7 obzG2hDmOcN680XFZ9tOYiQdChEI4cqFlWAPpthZ0TtSjmZ+0Jv5spTVbP7M/DFJ 61RCUdzZiPrTJiTwuQt5PGO39BnGbxbG64+x1a0qFrcd96FftmRi1CXwEoEF5dXc LBS3yE/GmHALiBDKwqK4RN5iF6P4ErdP6WDL0506uW/xFOp198BHOd+auHXt4+eY a2L4hOuAhl6w7BvjtIXogzX/0pGGqnzk2egyYNXOW1REtCrF/JInnxal+gBQpl9E v+ErBOZ+1+BRi01Dk0ytbC4mkCNvaMsRFz+O4Msm9PlF03V+utBfeRUzOOC32aMw 2QuyngO580zJt/F8WPTvoH2CHIvtkKh92azHOo95+IPwjPjUYWs= =qgU2 -----END PGP SIGNATURE----- --WIyZ46R2i8wDzkSu-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0739C43461 for ; Fri, 4 Sep 2020 09:21:45 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 782DF20791 for ; Fri, 4 Sep 2020 09:21:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aIsUN7AA"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="JVTj/hYd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 782DF20791 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=62W+NVOF0mhKoJ3cChZlBZVA4bXjDd4kEEqSsd9ELj8=; b=aIsUN7AAguxUEUAYfD2nluSRQ uwu8KuZ6tt0H4IaPbIcsSHZoSQZVJyEVwnvvwJTPCtjn6YWzu0L2o/x1XYdu2oV1437szslkuBkD6 MNLsABmtHsSbD71Bn2YQ0XKCTd/R7SrA2BVCb0+et0V/KalkztbPwS9hRfHovyHRc2NtLPWuFQ3MK lRHoOktFXlMwqPlqp2wfvr2zq45bnKJ73uJfcWL3jA0i6Y+yZh2vZ9WiDqVFmZSBh+Zw49xn2GTjo 8g6QIc9luIRcUKjXcI4QnkzHz5kAbwCCeLrkMIrq0XcSrlnnuo/Qx1SsPZljPBXxuuS56C2EAhk29 +ExICyCzg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kE7te-0006kQ-WF; Fri, 04 Sep 2020 09:20:39 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kE7tc-0006jv-SO for linux-arm-kernel@lists.infradead.org; Fri, 04 Sep 2020 09:20:37 +0000 Received: from localhost (p5486cda5.dip0.t-ipconnect.de [84.134.205.165]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E6D5E2067C; Fri, 4 Sep 2020 09:20:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599211235; bh=tfvwXFZiU3UT3uCBI0eVIiaDepEZKUtj+JOTXPnmFsw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JVTj/hYdti7ZOguNrnw2iuzyeMxhWiP8cgeuhOAht8F02N5gmhfh2HxDDvcQj107h 4ifFx6nxVFzUesF8iXxBLPLKWUAw3BEtopz+mFS72Nmhnet+ySsDq2UKZsnxzsh6UB ZLbw9GgVbEuLg/2GWAziBor2k7pJGg1pgBqGVI3U= Date: Fri, 4 Sep 2020 11:20:32 +0200 From: Wolfram Sang To: Codrin.Ciubotariu@microchip.com, Geert Uytterhoeven Subject: Re: Re: Re: [RFC PATCH 4/4] i2c: at91: Move to generic GPIO bus recovery Message-ID: <20200904092032.GA32080@ninjato> References: <20200619141904.910889-1-codrin.ciubotariu@microchip.com> <20200619141904.910889-5-codrin.ciubotariu@microchip.com> <20200802170820.GC10193@kunai> <65890aab-1d19-7e7e-abff-3c6ee05c8ade@microchip.com> <20200826061444.GB1081@ninjato> <15466c95-f1ea-63a4-1429-24d9b7567c1c@microchip.com> MIME-Version: 1.0 In-Reply-To: <15466c95-f1ea-63a4-1429-24d9b7567c1c@microchip.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200904_052037_060953_2331F635 X-CRM114-Status: GOOD ( 16.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alexandre.belloni@bootlin.com, kamel.bouhara@bootlin.com, linux-kernel@vger.kernel.org, Ludovic.Desroches@microchip.com, robh+dt@kernel.org, linux-i2c@vger.kernel.org, linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============0977848680325638458==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0977848680325638458== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="WIyZ46R2i8wDzkSu" Content-Disposition: inline --WIyZ46R2i8wDzkSu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Codrin, > The pinmux driver needs to have strict set to false, otherwise the=20 > switching is not available, not at this time at least. Perhaps there is= =20 > room for improvement here, because the I2C bus is not using the pins=20 > while we are doing GPIO recovery. Our driver doesn't use 'strict'. The thing is that I can't describe a pinctrl state for GPIO. GPIO is the default state until another function is requested. Back to GPIO currently means freeing the pin again, so it defaults back to GPIO. We are currently discussing it. Geert (CCed) isn't very happy of describing the same pins with 'function =3D "gpio"' because the Kernel already knows the mapping, just needs to revert it. Geert, please correct me if I am wrong. > I am not sure I'll have time the next week to work on what you asked me= =20 > regarding sh_mobile and PXA, but I will look into it the week after that. > Sorry about my delayed reply, I was on vacation. Well, no need for sh_mobile, this is my todo item :) About PXA, well, I am still happy that you volunteered to do it, so I hope you had a relaxing vacation! Happy hacking, Wolfram --WIyZ46R2i8wDzkSu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAl9SBtwACgkQFA3kzBSg KbZeWw//e8idK/UaDDNoa1ayZzCtU5zt8qZiIxCEia10pmFsfb1uZkJ4nyybcIT2 FcpsGjUsrDCWvVEu+3hAyILntIJF8949WUK7K7JhqMeH9o3T7ZJeUEgK7cB0o9s5 wrjs2WMvBjP1TaPW2LhcAAlP3q4/Qy+4xQ6SpjLzQsTeNtv643vWo15V5lOUHjuK 0s/VCmZtnrqvRXsbjrzAIk+XZ+m7IhWgNDY6MUfO7gxDCWq8q+KRcncBaHNopCIi wYGq2KReTYQ/nA+ACytH/SsiQvmXoYdfEiN6K1WnXviu0XwtkG1yTQPtpBetvpS7 obzG2hDmOcN680XFZ9tOYiQdChEI4cqFlWAPpthZ0TtSjmZ+0Jv5spTVbP7M/DFJ 61RCUdzZiPrTJiTwuQt5PGO39BnGbxbG64+x1a0qFrcd96FftmRi1CXwEoEF5dXc LBS3yE/GmHALiBDKwqK4RN5iF6P4ErdP6WDL0506uW/xFOp198BHOd+auHXt4+eY a2L4hOuAhl6w7BvjtIXogzX/0pGGqnzk2egyYNXOW1REtCrF/JInnxal+gBQpl9E v+ErBOZ+1+BRi01Dk0ytbC4mkCNvaMsRFz+O4Msm9PlF03V+utBfeRUzOOC32aMw 2QuyngO580zJt/F8WPTvoH2CHIvtkKh92azHOo95+IPwjPjUYWs= =qgU2 -----END PGP SIGNATURE----- --WIyZ46R2i8wDzkSu-- --===============0977848680325638458== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0977848680325638458==--