From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFF97C433E2 for ; Fri, 4 Sep 2020 16:17:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B16F920E65 for ; Fri, 4 Sep 2020 16:17:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="lJJQ9wzR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727119AbgIDQRY (ORCPT ); Fri, 4 Sep 2020 12:17:24 -0400 Received: from mx0b-001ae601.pphosted.com ([67.231.152.168]:34348 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726855AbgIDQRS (ORCPT ); Fri, 4 Sep 2020 12:17:18 -0400 Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 084GGI3M007925; Fri, 4 Sep 2020 11:16:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : content-transfer-encoding : in-reply-to; s=PODMain02222019; bh=76FaaRrunFbexsou6fbys/9Meax+ywrGh7TuEp7aeyM=; b=lJJQ9wzRikUdH7JNwcF0swFR31NWj5uTxZI5DpMGFCffiwecVIpPPIT5rSh0i2dtAskP N0koC/Q3n0LJrqm+k+lqlhubVlux3pqy6sX3Bzov+QwgVdxJ6JdA+zIamnyuwVJC3GJh GhriNiO/UsdtlcATF9jp28FJeWznV88C0c32XzWwGw5HkzTGy9SFlhzklHDlRMCmHPml qsYeUWdWWqb1DZWxmBIZHxPf0W5gCOQMio8usc8C+QRdgzAuauU0XlSDIIg9rTeMIbWG ne5GyS5IYBaWkPpBkfNardRSSXbOCLcrC2b6dzdt7uDsknrtaL+5I/qM7Y7ORm8fZSf+ wQ== Received: from ediex01.ad.cirrus.com ([87.246.76.36]) by mx0b-001ae601.pphosted.com with ESMTP id 337keqhmut-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Fri, 04 Sep 2020 11:16:51 -0500 Received: from EDIEX01.ad.cirrus.com (198.61.84.80) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1913.5; Fri, 4 Sep 2020 17:16:49 +0100 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.1.1913.5 via Frontend Transport; Fri, 4 Sep 2020 17:16:49 +0100 Received: from ediswmail.ad.cirrus.com (ediswmail.ad.cirrus.com [198.61.86.93]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 609552C3; Fri, 4 Sep 2020 16:16:49 +0000 (UTC) Date: Fri, 4 Sep 2020 16:16:49 +0000 From: Charles Keepax To: Maxime Ripard CC: Samuel Holland , , Jernej =?utf-8?Q?=C5=A0krabec?= , , , , Takashi Iwai , Liam Girdwood , Rob Herring , Marcus Cooper , Chen-Yu Tsai , Mark Brown , , Subject: Re: [linux-sunxi] [PATCH 05/16] ASoc: sun4i-i2s: Add 20 and 24 bit support Message-ID: <20200904161649.GL10899@ediswmail.ad.cirrus.com> References: <20200704113902.336911-1-peron.clem@gmail.com> <20200704113902.336911-6-peron.clem@gmail.com> <1e320dfd-9388-54b2-dba9-7def0bf4bbad@sholland.org> <9148679.oVN3Z7rve9@kista> <20200903074023.jccqp45br3er4h3g@gilmour.lan> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200903074023.jccqp45br3er4h3g@gilmour.lan> User-Agent: Mutt/1.5.21 (2010-09-15) X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0 adultscore=0 priorityscore=1501 spamscore=0 mlxlogscore=999 lowpriorityscore=0 suspectscore=0 impostorscore=0 mlxscore=0 clxscore=1011 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009040141 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 03, 2020 at 09:40:23AM +0200, Maxime Ripard wrote: > On Wed, Sep 02, 2020 at 09:22:33PM -0500, Samuel Holland wrote: > > On 9/2/20 1:10 PM, Jernej Škrabec wrote: > > > Hi Samuel! > > > > > > Dne petek, 10. julij 2020 ob 07:44:51 CEST je Samuel Holland napisal(a): > > >> On 7/4/20 6:38 AM, Clément Péron wrote: > > >>> From: Marcus Cooper > > >>> > > >>> Extend the functionality of the driver to include support of 20 and > > >>> 24 bits per sample. > > >>> > > >>> Signed-off-by: Marcus Cooper > > >>> Signed-off-by: Clément Péron > > >>> --- > > >>> > > >>> sound/soc/sunxi/sun4i-i2s.c | 11 +++++++++-- > > >>> 1 file changed, 9 insertions(+), 2 deletions(-) > > >>> > > >>> diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c > > >>> index f78167e152ce..bc7f9343bc7a 100644 > > >>> --- a/sound/soc/sunxi/sun4i-i2s.c > > >>> +++ b/sound/soc/sunxi/sun4i-i2s.c > > >>> @@ -577,6 +577,9 @@ static int sun4i_i2s_hw_params(struct > > >>> snd_pcm_substream *substream,> > > >>> case 16: > > >>> width = DMA_SLAVE_BUSWIDTH_2_BYTES; > > >>> break; > > >>> > > >>> + case 32: > > >>> + width = DMA_SLAVE_BUSWIDTH_4_BYTES; > > >>> + break; > > >> > > >> This breaks the sun4i variants, because sun4i_i2s_get_wss returns 4 for a 32 > > >> bit width, but it needs to return 3. > > > > > > I'm not sure what has WSS with physical width and DMA? > > > > This is the change where creating a S24_LE stream no longer fails with -EINVAL. > > So this is the change where userspace stops downsampling 24-bit audio sources. > > So this is the change where playback of 24-bit audio sources breaks, because WSS > > is programmed wrong. > > > > >> As a side note, I wonder why we use the physical width (the spacing between > > >> samples in RAM) to drive the slot width. S24_LE takes up 4 bytes per sample > > >> in RAM, which we need for DMA. But I don't see why we would want to > > >> transmit the padding over the wire. I would expect it to be transmitted the > > >> same as S24_3LE (which has no padding). It did not matter before, because > > >> the only supported format had no padding. > > > > > > Allwinner DMA engines support only 1, 2, 4 and sometimes 8 bytes for bus > > > width, so if sample is 24 bits in size, we have no other way but to transmit > > > padding too. > > > > I understand why we do 4 byte DMA from RAM <=> I2S FIFO; that was not my > > question. I'm referring to the actual wire format (FIFO <=> PCM_DIN/DOUT). The > > sample is already truncated from 32 bits to 24 bits in the FIFO -- that's what > > TXIM and RXOM in FIFO_CTRL control. > > > > If a sample is 24 bits wide, why would we send 32 BCLKs for every LRCK? I would > > expect the slot width to match the sample resolution by default. But yet we have > > this code in the driver: > > > > unsigned int word_size = params_width(params); > > unsigned int slot_width = params_physical_width(params); > > > > I think slot_width should be the same as word_size, and I suggest changing it > > before adding 20/24-bit support. > > Generally speaking, the slot width doesn't necessarily match the > physical width. With TDM for example you may very well have slots > larger than their samples. > > That being said, S24 is explicitly a format where you send a sample of > 24 bits in a 32-bit word (in the lowest three bytes, little endian) > > See: > https://elixir.bootlin.com/linux/v5.9-rc3/source/sound/core/pcm_misc.c#L75 > https://mailman.alsa-project.org/pipermail/alsa-devel/2013-April/061073.html > > 24 bits of data over three bytes like you suggest is S24_3LE > My understanding is physical_width refers to the in memory representation, but shouldn't be used to control the slot width on the bus. If not specified otherwise (say through the set_tdm callback), and if the appropriate BCLK is supported, then the slot should be just large enough to hold the data. Thanks, Charles From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2819C43461 for ; Fri, 4 Sep 2020 16:17:54 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 06CB520772 for ; Fri, 4 Sep 2020 16:17:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="W67PWEkJ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="lJJQ9wzR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 06CB520772 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 49AD61B07; Fri, 4 Sep 2020 18:17:02 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 49AD61B07 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1599236272; bh=/dE5uv2mYZ3ZF/9Kd1Kc5YMC+o3/jd470YhbBHPEGYw=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=W67PWEkJKyVhzUtvMksZNOXdnqy79upX40rE4/94S51iRBUE3gbrF3SmITwc5nkCZ KNioaVof2VV6DooRLzR4xI4UFY/+t71tv+Ec7cxMEyQX50wKaW5gn9VYUsM5HZUw0/ rRFCZgotDQRrYACK4ehIjXevhbBXk0EX5avrIiGI= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id B5B11F80212; Fri, 4 Sep 2020 18:17:01 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 28C2EF8024A; Fri, 4 Sep 2020 18:17:00 +0200 (CEST) Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E2002F80113 for ; Fri, 4 Sep 2020 18:16:53 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E2002F80113 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="lJJQ9wzR" Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 084GGI3M007925; Fri, 4 Sep 2020 11:16:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : content-transfer-encoding : in-reply-to; s=PODMain02222019; bh=76FaaRrunFbexsou6fbys/9Meax+ywrGh7TuEp7aeyM=; b=lJJQ9wzRikUdH7JNwcF0swFR31NWj5uTxZI5DpMGFCffiwecVIpPPIT5rSh0i2dtAskP N0koC/Q3n0LJrqm+k+lqlhubVlux3pqy6sX3Bzov+QwgVdxJ6JdA+zIamnyuwVJC3GJh GhriNiO/UsdtlcATF9jp28FJeWznV88C0c32XzWwGw5HkzTGy9SFlhzklHDlRMCmHPml qsYeUWdWWqb1DZWxmBIZHxPf0W5gCOQMio8usc8C+QRdgzAuauU0XlSDIIg9rTeMIbWG ne5GyS5IYBaWkPpBkfNardRSSXbOCLcrC2b6dzdt7uDsknrtaL+5I/qM7Y7ORm8fZSf+ wQ== Received: from ediex01.ad.cirrus.com ([87.246.76.36]) by mx0b-001ae601.pphosted.com with ESMTP id 337keqhmut-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Fri, 04 Sep 2020 11:16:51 -0500 Received: from EDIEX01.ad.cirrus.com (198.61.84.80) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1913.5; Fri, 4 Sep 2020 17:16:49 +0100 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.1.1913.5 via Frontend Transport; Fri, 4 Sep 2020 17:16:49 +0100 Received: from ediswmail.ad.cirrus.com (ediswmail.ad.cirrus.com [198.61.86.93]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 609552C3; Fri, 4 Sep 2020 16:16:49 +0000 (UTC) Date: Fri, 4 Sep 2020 16:16:49 +0000 From: Charles Keepax To: Maxime Ripard Subject: Re: [linux-sunxi] [PATCH 05/16] ASoc: sun4i-i2s: Add 20 and 24 bit support Message-ID: <20200904161649.GL10899@ediswmail.ad.cirrus.com> References: <20200704113902.336911-1-peron.clem@gmail.com> <20200704113902.336911-6-peron.clem@gmail.com> <1e320dfd-9388-54b2-dba9-7def0bf4bbad@sholland.org> <9148679.oVN3Z7rve9@kista> <20200903074023.jccqp45br3er4h3g@gilmour.lan> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200903074023.jccqp45br3er4h3g@gilmour.lan> User-Agent: Mutt/1.5.21 (2010-09-15) X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0 adultscore=0 priorityscore=1501 spamscore=0 mlxlogscore=999 lowpriorityscore=0 suspectscore=0 impostorscore=0 mlxscore=0 clxscore=1011 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009040141 Cc: devicetree@vger.kernel.org, Jernej =?utf-8?Q?=C5=A0krabec?= , Samuel Holland , Liam Girdwood , Mark Brown , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Marcus Cooper , linux-sunxi@googlegroups.com, Rob Herring , peron.clem@gmail.com, Chen-Yu Tsai , linux-arm-kernel@lists.infradead.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, Sep 03, 2020 at 09:40:23AM +0200, Maxime Ripard wrote: > On Wed, Sep 02, 2020 at 09:22:33PM -0500, Samuel Holland wrote: > > On 9/2/20 1:10 PM, Jernej Škrabec wrote: > > > Hi Samuel! > > > > > > Dne petek, 10. julij 2020 ob 07:44:51 CEST je Samuel Holland napisal(a): > > >> On 7/4/20 6:38 AM, Clément Péron wrote: > > >>> From: Marcus Cooper > > >>> > > >>> Extend the functionality of the driver to include support of 20 and > > >>> 24 bits per sample. > > >>> > > >>> Signed-off-by: Marcus Cooper > > >>> Signed-off-by: Clément Péron > > >>> --- > > >>> > > >>> sound/soc/sunxi/sun4i-i2s.c | 11 +++++++++-- > > >>> 1 file changed, 9 insertions(+), 2 deletions(-) > > >>> > > >>> diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c > > >>> index f78167e152ce..bc7f9343bc7a 100644 > > >>> --- a/sound/soc/sunxi/sun4i-i2s.c > > >>> +++ b/sound/soc/sunxi/sun4i-i2s.c > > >>> @@ -577,6 +577,9 @@ static int sun4i_i2s_hw_params(struct > > >>> snd_pcm_substream *substream,> > > >>> case 16: > > >>> width = DMA_SLAVE_BUSWIDTH_2_BYTES; > > >>> break; > > >>> > > >>> + case 32: > > >>> + width = DMA_SLAVE_BUSWIDTH_4_BYTES; > > >>> + break; > > >> > > >> This breaks the sun4i variants, because sun4i_i2s_get_wss returns 4 for a 32 > > >> bit width, but it needs to return 3. > > > > > > I'm not sure what has WSS with physical width and DMA? > > > > This is the change where creating a S24_LE stream no longer fails with -EINVAL. > > So this is the change where userspace stops downsampling 24-bit audio sources. > > So this is the change where playback of 24-bit audio sources breaks, because WSS > > is programmed wrong. > > > > >> As a side note, I wonder why we use the physical width (the spacing between > > >> samples in RAM) to drive the slot width. S24_LE takes up 4 bytes per sample > > >> in RAM, which we need for DMA. But I don't see why we would want to > > >> transmit the padding over the wire. I would expect it to be transmitted the > > >> same as S24_3LE (which has no padding). It did not matter before, because > > >> the only supported format had no padding. > > > > > > Allwinner DMA engines support only 1, 2, 4 and sometimes 8 bytes for bus > > > width, so if sample is 24 bits in size, we have no other way but to transmit > > > padding too. > > > > I understand why we do 4 byte DMA from RAM <=> I2S FIFO; that was not my > > question. I'm referring to the actual wire format (FIFO <=> PCM_DIN/DOUT). The > > sample is already truncated from 32 bits to 24 bits in the FIFO -- that's what > > TXIM and RXOM in FIFO_CTRL control. > > > > If a sample is 24 bits wide, why would we send 32 BCLKs for every LRCK? I would > > expect the slot width to match the sample resolution by default. But yet we have > > this code in the driver: > > > > unsigned int word_size = params_width(params); > > unsigned int slot_width = params_physical_width(params); > > > > I think slot_width should be the same as word_size, and I suggest changing it > > before adding 20/24-bit support. > > Generally speaking, the slot width doesn't necessarily match the > physical width. With TDM for example you may very well have slots > larger than their samples. > > That being said, S24 is explicitly a format where you send a sample of > 24 bits in a 32-bit word (in the lowest three bytes, little endian) > > See: > https://elixir.bootlin.com/linux/v5.9-rc3/source/sound/core/pcm_misc.c#L75 > https://mailman.alsa-project.org/pipermail/alsa-devel/2013-April/061073.html > > 24 bits of data over three bytes like you suggest is S24_3LE > My understanding is physical_width refers to the in memory representation, but shouldn't be used to control the slot width on the bus. If not specified otherwise (say through the set_tdm callback), and if the appropriate BCLK is supported, then the slot should be just large enough to hold the data. Thanks, Charles From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8DDCC43461 for ; Fri, 4 Sep 2020 16:18:33 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6D47120772 for ; Fri, 4 Sep 2020 16:18:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="D32b1/GG"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="lJJQ9wzR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6D47120772 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=G172iQpHhP4cxTySpFz/9cxajkDvnlLoSJwkH3WI6z8=; b=D32b1/GGyT+9wdlcrnCAactm1 mHyBkCDKZzg0tKXGBkYpziD472pvcHW58qZ15t3T4i46D6F6KC4A6a+BsVxsrPyhVs5X9Hphq+rqf khSPYQEIdYcSue767JgpTHF5QD3I+HCjwLSGVk8yETvCT1ZVTLOCh7eknH+QqZ9W/asEDNz+VJRuH o8ZdI41dFW8ZBTg8puv1PnygNWid3rvnKJSxeTPTJbCo60wOh7pxFdjcGUpVH34Fm81TH9RbUWOqJ HmaJVXG2k18B2krDBDb3NBTf87zSRLnNj7xk5cRkxKx3w+81MLcnpHihlLw+cwF3Gj8XfDEPJ1OF7 z693HwagQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kEEOu-00084a-52; Fri, 04 Sep 2020 16:17:20 +0000 Received: from mx0b-001ae601.pphosted.com ([67.231.152.168]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kEEOf-0007xR-Fw for linux-arm-kernel@lists.infradead.org; Fri, 04 Sep 2020 16:17:07 +0000 Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 084GGI3M007925; Fri, 4 Sep 2020 11:16:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : content-transfer-encoding : in-reply-to; s=PODMain02222019; bh=76FaaRrunFbexsou6fbys/9Meax+ywrGh7TuEp7aeyM=; b=lJJQ9wzRikUdH7JNwcF0swFR31NWj5uTxZI5DpMGFCffiwecVIpPPIT5rSh0i2dtAskP N0koC/Q3n0LJrqm+k+lqlhubVlux3pqy6sX3Bzov+QwgVdxJ6JdA+zIamnyuwVJC3GJh GhriNiO/UsdtlcATF9jp28FJeWznV88C0c32XzWwGw5HkzTGy9SFlhzklHDlRMCmHPml qsYeUWdWWqb1DZWxmBIZHxPf0W5gCOQMio8usc8C+QRdgzAuauU0XlSDIIg9rTeMIbWG ne5GyS5IYBaWkPpBkfNardRSSXbOCLcrC2b6dzdt7uDsknrtaL+5I/qM7Y7ORm8fZSf+ wQ== Received: from ediex01.ad.cirrus.com ([87.246.76.36]) by mx0b-001ae601.pphosted.com with ESMTP id 337keqhmut-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Fri, 04 Sep 2020 11:16:51 -0500 Received: from EDIEX01.ad.cirrus.com (198.61.84.80) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1913.5; Fri, 4 Sep 2020 17:16:49 +0100 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.1.1913.5 via Frontend Transport; Fri, 4 Sep 2020 17:16:49 +0100 Received: from ediswmail.ad.cirrus.com (ediswmail.ad.cirrus.com [198.61.86.93]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 609552C3; Fri, 4 Sep 2020 16:16:49 +0000 (UTC) Date: Fri, 4 Sep 2020 16:16:49 +0000 From: Charles Keepax To: Maxime Ripard Subject: Re: [linux-sunxi] [PATCH 05/16] ASoc: sun4i-i2s: Add 20 and 24 bit support Message-ID: <20200904161649.GL10899@ediswmail.ad.cirrus.com> References: <20200704113902.336911-1-peron.clem@gmail.com> <20200704113902.336911-6-peron.clem@gmail.com> <1e320dfd-9388-54b2-dba9-7def0bf4bbad@sholland.org> <9148679.oVN3Z7rve9@kista> <20200903074023.jccqp45br3er4h3g@gilmour.lan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200903074023.jccqp45br3er4h3g@gilmour.lan> User-Agent: Mutt/1.5.21 (2010-09-15) X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0 adultscore=0 priorityscore=1501 spamscore=0 mlxlogscore=999 lowpriorityscore=0 suspectscore=0 impostorscore=0 mlxscore=0 clxscore=1011 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009040141 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200904_121705_916491_8E005F4E X-CRM114-Status: GOOD ( 44.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Jernej =?utf-8?Q?=C5=A0krabec?= , Samuel Holland , Liam Girdwood , Mark Brown , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Marcus Cooper , linux-sunxi@googlegroups.com, Rob Herring , peron.clem@gmail.com, Chen-Yu Tsai , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBTZXAgMDMsIDIwMjAgYXQgMDk6NDA6MjNBTSArMDIwMCwgTWF4aW1lIFJpcGFyZCB3 cm90ZToKPiBPbiBXZWQsIFNlcCAwMiwgMjAyMCBhdCAwOToyMjozM1BNIC0wNTAwLCBTYW11ZWwg SG9sbGFuZCB3cm90ZToKPiA+IE9uIDkvMi8yMCAxOjEwIFBNLCBKZXJuZWogxaBrcmFiZWMgd3Jv dGU6Cj4gPiA+IEhpIFNhbXVlbCEKPiA+ID4gCj4gPiA+IERuZSBwZXRlaywgMTAuIGp1bGlqIDIw MjAgb2IgMDc6NDQ6NTEgQ0VTVCBqZSBTYW11ZWwgSG9sbGFuZCBuYXBpc2FsKGEpOgo+ID4gPj4g T24gNy80LzIwIDY6MzggQU0sIENsw6ltZW50IFDDqXJvbiB3cm90ZToKPiA+ID4+PiBGcm9tOiBN YXJjdXMgQ29vcGVyIDxjb2Rla2lwcGVyQGdtYWlsLmNvbT4KPiA+ID4+Pgo+ID4gPj4+IEV4dGVu ZCB0aGUgZnVuY3Rpb25hbGl0eSBvZiB0aGUgZHJpdmVyIHRvIGluY2x1ZGUgc3VwcG9ydCBvZiAy MCBhbmQKPiA+ID4+PiAyNCBiaXRzIHBlciBzYW1wbGUuCj4gPiA+Pj4KPiA+ID4+PiBTaWduZWQt b2ZmLWJ5OiBNYXJjdXMgQ29vcGVyIDxjb2Rla2lwcGVyQGdtYWlsLmNvbT4KPiA+ID4+PiBTaWdu ZWQtb2ZmLWJ5OiBDbMOpbWVudCBQw6lyb24gPHBlcm9uLmNsZW1AZ21haWwuY29tPgo+ID4gPj4+ IC0tLQo+ID4gPj4+Cj4gPiA+Pj4gIHNvdW5kL3NvYy9zdW54aS9zdW40aS1pMnMuYyB8IDExICsr KysrKysrKy0tCj4gPiA+Pj4gIDEgZmlsZSBjaGFuZ2VkLCA5IGluc2VydGlvbnMoKyksIDIgZGVs ZXRpb25zKC0pCj4gPiA+Pj4KPiA+ID4+PiBkaWZmIC0tZ2l0IGEvc291bmQvc29jL3N1bnhpL3N1 bjRpLWkycy5jIGIvc291bmQvc29jL3N1bnhpL3N1bjRpLWkycy5jCj4gPiA+Pj4gaW5kZXggZjc4 MTY3ZTE1MmNlLi5iYzdmOTM0M2JjN2EgMTAwNjQ0Cj4gPiA+Pj4gLS0tIGEvc291bmQvc29jL3N1 bnhpL3N1bjRpLWkycy5jCj4gPiA+Pj4gKysrIGIvc291bmQvc29jL3N1bnhpL3N1bjRpLWkycy5j Cj4gPiA+Pj4gQEAgLTU3Nyw2ICs1NzcsOSBAQCBzdGF0aWMgaW50IHN1bjRpX2kyc19od19wYXJh bXMoc3RydWN0Cj4gPiA+Pj4gc25kX3BjbV9zdWJzdHJlYW0gKnN1YnN0cmVhbSw+IAo+ID4gPj4+ ICAJY2FzZSAxNjoKPiA+ID4+PiAgCQl3aWR0aCA9IERNQV9TTEFWRV9CVVNXSURUSF8yX0JZVEVT Owo+ID4gPj4+ICAJCWJyZWFrOwo+ID4gPj4+Cj4gPiA+Pj4gKwljYXNlIDMyOgo+ID4gPj4+ICsJ CXdpZHRoID0gRE1BX1NMQVZFX0JVU1dJRFRIXzRfQllURVM7Cj4gPiA+Pj4gKwkJYnJlYWs7Cj4g PiA+Pgo+ID4gPj4gVGhpcyBicmVha3MgdGhlIHN1bjRpIHZhcmlhbnRzLCBiZWNhdXNlIHN1bjRp X2kyc19nZXRfd3NzIHJldHVybnMgNCBmb3IgYSAzMgo+ID4gPj4gYml0IHdpZHRoLCBidXQgaXQg bmVlZHMgdG8gcmV0dXJuIDMuCj4gPiA+IAo+ID4gPiBJJ20gbm90IHN1cmUgd2hhdCBoYXMgV1NT IHdpdGggcGh5c2ljYWwgd2lkdGggYW5kIERNQT8KPiA+IAo+ID4gVGhpcyBpcyB0aGUgY2hhbmdl IHdoZXJlIGNyZWF0aW5nIGEgUzI0X0xFIHN0cmVhbSBubyBsb25nZXIgZmFpbHMgd2l0aCAtRUlO VkFMLgo+ID4gU28gdGhpcyBpcyB0aGUgY2hhbmdlIHdoZXJlIHVzZXJzcGFjZSBzdG9wcyBkb3du c2FtcGxpbmcgMjQtYml0IGF1ZGlvIHNvdXJjZXMuCj4gPiBTbyB0aGlzIGlzIHRoZSBjaGFuZ2Ug d2hlcmUgcGxheWJhY2sgb2YgMjQtYml0IGF1ZGlvIHNvdXJjZXMgYnJlYWtzLCBiZWNhdXNlIFdT Uwo+ID4gaXMgcHJvZ3JhbW1lZCB3cm9uZy4KPiA+IAo+ID4gPj4gQXMgYSBzaWRlIG5vdGUsIEkg d29uZGVyIHdoeSB3ZSB1c2UgdGhlIHBoeXNpY2FsIHdpZHRoICh0aGUgc3BhY2luZyBiZXR3ZWVu Cj4gPiA+PiBzYW1wbGVzIGluIFJBTSkgdG8gZHJpdmUgdGhlIHNsb3Qgd2lkdGguIFMyNF9MRSB0 YWtlcyB1cCA0IGJ5dGVzIHBlciBzYW1wbGUKPiA+ID4+IGluIFJBTSwgd2hpY2ggd2UgbmVlZCBm b3IgRE1BLiBCdXQgSSBkb24ndCBzZWUgd2h5IHdlIHdvdWxkIHdhbnQgdG8KPiA+ID4+IHRyYW5z bWl0IHRoZSBwYWRkaW5nIG92ZXIgdGhlIHdpcmUuIEkgd291bGQgZXhwZWN0IGl0IHRvIGJlIHRy YW5zbWl0dGVkIHRoZQo+ID4gPj4gc2FtZSBhcyBTMjRfM0xFICh3aGljaCBoYXMgbm8gcGFkZGlu ZykuIEl0IGRpZCBub3QgbWF0dGVyIGJlZm9yZSwgYmVjYXVzZQo+ID4gPj4gdGhlIG9ubHkgc3Vw cG9ydGVkIGZvcm1hdCBoYWQgbm8gcGFkZGluZy4KPiA+ID4gCj4gPiA+IEFsbHdpbm5lciBETUEg ZW5naW5lcyBzdXBwb3J0IG9ubHkgMSwgMiwgNCBhbmQgc29tZXRpbWVzIDggYnl0ZXMgZm9yIGJ1 cyAKPiA+ID4gd2lkdGgsIHNvIGlmIHNhbXBsZSBpcyAyNCBiaXRzIGluIHNpemUsIHdlIGhhdmUg bm8gb3RoZXIgd2F5IGJ1dCB0byB0cmFuc21pdCAKPiA+ID4gcGFkZGluZyB0b28uCj4gPiAKPiA+ IEkgdW5kZXJzdGFuZCB3aHkgd2UgZG8gNCBieXRlIERNQSBmcm9tIFJBTSA8PT4gSTJTIEZJRk87 IHRoYXQgd2FzIG5vdCBteQo+ID4gcXVlc3Rpb24uIEknbSByZWZlcnJpbmcgdG8gdGhlIGFjdHVh bCB3aXJlIGZvcm1hdCAoRklGTyA8PT4gUENNX0RJTi9ET1VUKS4gVGhlCj4gPiBzYW1wbGUgaXMg YWxyZWFkeSB0cnVuY2F0ZWQgZnJvbSAzMiBiaXRzIHRvIDI0IGJpdHMgaW4gdGhlIEZJRk8gLS0g dGhhdCdzIHdoYXQKPiA+IFRYSU0gYW5kIFJYT00gaW4gRklGT19DVFJMIGNvbnRyb2wuCj4gPiAK PiA+IElmIGEgc2FtcGxlIGlzIDI0IGJpdHMgd2lkZSwgd2h5IHdvdWxkIHdlIHNlbmQgMzIgQkNM S3MgZm9yIGV2ZXJ5IExSQ0s/IEkgd291bGQKPiA+IGV4cGVjdCB0aGUgc2xvdCB3aWR0aCB0byBt YXRjaCB0aGUgc2FtcGxlIHJlc29sdXRpb24gYnkgZGVmYXVsdC4gQnV0IHlldCB3ZSBoYXZlCj4g PiB0aGlzIGNvZGUgaW4gdGhlIGRyaXZlcjoKPiA+IAo+ID4gICAgIHVuc2lnbmVkIGludCB3b3Jk X3NpemUgPSBwYXJhbXNfd2lkdGgocGFyYW1zKTsKPiA+ICAgICB1bnNpZ25lZCBpbnQgc2xvdF93 aWR0aCA9IHBhcmFtc19waHlzaWNhbF93aWR0aChwYXJhbXMpOwo+ID4gCj4gPiBJIHRoaW5rIHNs b3Rfd2lkdGggc2hvdWxkIGJlIHRoZSBzYW1lIGFzIHdvcmRfc2l6ZSwgYW5kIEkgc3VnZ2VzdCBj aGFuZ2luZyBpdAo+ID4gYmVmb3JlIGFkZGluZyAyMC8yNC1iaXQgc3VwcG9ydC4KPiAKPiBHZW5l cmFsbHkgc3BlYWtpbmcsIHRoZSBzbG90IHdpZHRoIGRvZXNuJ3QgbmVjZXNzYXJpbHkgbWF0Y2gg dGhlCj4gcGh5c2ljYWwgd2lkdGguIFdpdGggVERNIGZvciBleGFtcGxlIHlvdSBtYXkgdmVyeSB3 ZWxsIGhhdmUgc2xvdHMKPiBsYXJnZXIgdGhhbiB0aGVpciBzYW1wbGVzLgo+IAo+IFRoYXQgYmVp bmcgc2FpZCwgUzI0IGlzIGV4cGxpY2l0bHkgYSBmb3JtYXQgd2hlcmUgeW91IHNlbmQgYSBzYW1w bGUgb2YKPiAyNCBiaXRzIGluIGEgMzItYml0IHdvcmQgKGluIHRoZSBsb3dlc3QgdGhyZWUgYnl0 ZXMsIGxpdHRsZSBlbmRpYW4pCj4gCj4gU2VlOgo+IGh0dHBzOi8vZWxpeGlyLmJvb3RsaW4uY29t L2xpbnV4L3Y1LjktcmMzL3NvdXJjZS9zb3VuZC9jb3JlL3BjbV9taXNjLmMjTDc1Cj4gaHR0cHM6 Ly9tYWlsbWFuLmFsc2EtcHJvamVjdC5vcmcvcGlwZXJtYWlsL2Fsc2EtZGV2ZWwvMjAxMy1BcHJp bC8wNjEwNzMuaHRtbAo+IAo+IDI0IGJpdHMgb2YgZGF0YSBvdmVyIHRocmVlIGJ5dGVzIGxpa2Ug eW91IHN1Z2dlc3QgaXMgUzI0XzNMRQo+IAoKTXkgdW5kZXJzdGFuZGluZyBpcyBwaHlzaWNhbF93 aWR0aCByZWZlcnMgdG8gdGhlIGluIG1lbW9yeQpyZXByZXNlbnRhdGlvbiwgYnV0IHNob3VsZG4n dCBiZSB1c2VkIHRvIGNvbnRyb2wgdGhlIHNsb3Qgd2lkdGgKb24gdGhlIGJ1cy4gSWYgbm90IHNw ZWNpZmllZCBvdGhlcndpc2UgKHNheSB0aHJvdWdoIHRoZSBzZXRfdGRtCmNhbGxiYWNrKSwgYW5k IGlmIHRoZSBhcHByb3ByaWF0ZSBCQ0xLIGlzIHN1cHBvcnRlZCwgdGhlbiB0aGUgc2xvdApzaG91 bGQgYmUganVzdCBsYXJnZSBlbm91Z2ggdG8gaG9sZCB0aGUgZGF0YS4KClRoYW5rcywKQ2hhcmxl cwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgt YXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQu b3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJt LWtlcm5lbAo=