From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2999C433E2 for ; Sat, 5 Sep 2020 12:02:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 99BB120757 for ; Sat, 5 Sep 2020 12:02:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599307338; bh=Byd7lldqYKdhk0D4aP5ylXoKM5Ow4mbv4nJ33uiteZs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=fDdmjMsOJr9LuSEDs3INCpooIom6/mBYLRxVGPJA3K2B5Rad3pWqEV91yU/BByAtA zbeRtpcpT8YZb4+dIqzMwBuLx46qRhLV0N9v6EXbNyv8T8luOeMzvg9haCmwZtFfYZ fqhsycgcIE4p1CKaf/IT7UVTHkvs/7ybhN9k6o+U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728544AbgIEMCO (ORCPT ); Sat, 5 Sep 2020 08:02:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:44610 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726597AbgIEMCN (ORCPT ); Sat, 5 Sep 2020 08:02:13 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D8E3320757; Sat, 5 Sep 2020 12:02:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599307333; bh=Byd7lldqYKdhk0D4aP5ylXoKM5Ow4mbv4nJ33uiteZs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=chuIF9SbtPql5/5QxDbmfAOD9dcumoSjcy3NdT7h3/FN4zZgBYLKNavX70bOY5sTX JAXdCRHdO6/kbTfiNsPrXa437pRHICuLPPqZZGf2tW41HeZmAhrdKM6VxYa8r9qSdK 5dIGoJ5nI3ZeMzHsp1hK6Prv4hhoFFnTBUPZLSag= Date: Sat, 5 Sep 2020 08:02:11 -0400 From: Sasha Levin To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Samuel Thibault , devel@driverdev.osuosl.org Subject: Re: [PATCH AUTOSEL 5.8 07/42] speakup: Fix wait_for_xmitr for ttyio case Message-ID: <20200905120211.GH8670@sasha-vm> References: <20200831152934.1023912-1-sashal@kernel.org> <20200831152934.1023912-7-sashal@kernel.org> <20200831153345.GA2525965@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200831153345.GA2525965@kroah.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 31, 2020 at 05:33:45PM +0200, Greg Kroah-Hartman wrote: >On Mon, Aug 31, 2020 at 11:28:59AM -0400, Sasha Levin wrote: >> From: Samuel Thibault >> >> [ Upstream commit 2b86d9b8ec6efb86fc5ea44f2d49b1df17f699a1 ] >> >> This was missed while introducing the tty-based serial access. >> >> The only remaining use of wait_for_xmitr with tty-based access is in >> spk_synth_is_alive_restart to check whether the synth can be restarted. >> With tty-based this is up to the tty layer to cope with the buffering >> etc. so we can just say yes. >> >> Signed-off-by: Samuel Thibault >> Link: https://lore.kernel.org/r/20200804160637.x3iycau5izywbgzl@function >> Signed-off-by: Greg Kroah-Hartman >> Signed-off-by: Sasha Levin >> --- >> drivers/staging/speakup/serialio.c | 8 +++++--- >> drivers/staging/speakup/spk_priv.h | 1 - >> drivers/staging/speakup/spk_ttyio.c | 7 +++++++ >> drivers/staging/speakup/spk_types.h | 1 + >> drivers/staging/speakup/synth.c | 2 +- >> 5 files changed, 14 insertions(+), 5 deletions(-) > >Not needed for 5.8 or older, sorry, this was a 5.9-rc1+ issue only. Dropped, thanks! -- Thanks, Sasha From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5716C433E2 for ; Sat, 5 Sep 2020 12:02:20 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7331520757 for ; Sat, 5 Sep 2020 12:02:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="chuIF9Sb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7331520757 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id CA7B086A4F; Sat, 5 Sep 2020 12:02:19 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AEdK_0Le0pzJ; Sat, 5 Sep 2020 12:02:16 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id EB17786451; Sat, 5 Sep 2020 12:02:15 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 682491BF20B for ; Sat, 5 Sep 2020 12:02:14 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 62BE6868EA for ; Sat, 5 Sep 2020 12:02:14 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id c5XJvzoHFpkE for ; Sat, 5 Sep 2020 12:02:13 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by whitealder.osuosl.org (Postfix) with ESMTPS id A3D22868E5 for ; Sat, 5 Sep 2020 12:02:13 +0000 (UTC) Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D8E3320757; Sat, 5 Sep 2020 12:02:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599307333; bh=Byd7lldqYKdhk0D4aP5ylXoKM5Ow4mbv4nJ33uiteZs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=chuIF9SbtPql5/5QxDbmfAOD9dcumoSjcy3NdT7h3/FN4zZgBYLKNavX70bOY5sTX JAXdCRHdO6/kbTfiNsPrXa437pRHICuLPPqZZGf2tW41HeZmAhrdKM6VxYa8r9qSdK 5dIGoJ5nI3ZeMzHsp1hK6Prv4hhoFFnTBUPZLSag= Date: Sat, 5 Sep 2020 08:02:11 -0400 From: Sasha Levin To: Greg Kroah-Hartman Subject: Re: [PATCH AUTOSEL 5.8 07/42] speakup: Fix wait_for_xmitr for ttyio case Message-ID: <20200905120211.GH8670@sasha-vm> References: <20200831152934.1023912-1-sashal@kernel.org> <20200831152934.1023912-7-sashal@kernel.org> <20200831153345.GA2525965@kroah.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200831153345.GA2525965@kroah.com> X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Samuel Thibault , linux-kernel@vger.kernel.org, stable@vger.kernel.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Mon, Aug 31, 2020 at 05:33:45PM +0200, Greg Kroah-Hartman wrote: >On Mon, Aug 31, 2020 at 11:28:59AM -0400, Sasha Levin wrote: >> From: Samuel Thibault >> >> [ Upstream commit 2b86d9b8ec6efb86fc5ea44f2d49b1df17f699a1 ] >> >> This was missed while introducing the tty-based serial access. >> >> The only remaining use of wait_for_xmitr with tty-based access is in >> spk_synth_is_alive_restart to check whether the synth can be restarted. >> With tty-based this is up to the tty layer to cope with the buffering >> etc. so we can just say yes. >> >> Signed-off-by: Samuel Thibault >> Link: https://lore.kernel.org/r/20200804160637.x3iycau5izywbgzl@function >> Signed-off-by: Greg Kroah-Hartman >> Signed-off-by: Sasha Levin >> --- >> drivers/staging/speakup/serialio.c | 8 +++++--- >> drivers/staging/speakup/spk_priv.h | 1 - >> drivers/staging/speakup/spk_ttyio.c | 7 +++++++ >> drivers/staging/speakup/spk_types.h | 1 + >> drivers/staging/speakup/synth.c | 2 +- >> 5 files changed, 14 insertions(+), 5 deletions(-) > >Not needed for 5.8 or older, sorry, this was a 5.9-rc1+ issue only. Dropped, thanks! -- Thanks, Sasha _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel