From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Vincent Whitchurch <vincent.whitchurch@axis.com>
Cc: thierry.reding@gmail.com, lee.jones@linaro.org, kernel@axis.com,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
robh+dt@kernel.org, oliver@schinagl.nl
Subject: Re: [PATCH v2 0/2] GPIO PWM driver
Date: Sat, 5 Sep 2020 18:42:49 +0200 [thread overview]
Message-ID: <20200905164249.5vy23gizpwstbs5c@pengutronix.de> (raw)
In-Reply-To: <20200902121236.20514-1-vincent.whitchurch@axis.com>
[-- Attachment #1: Type: text/plain, Size: 600 bytes --]
Hello Vincent,
On Wed, Sep 02, 2020 at 02:12:34PM +0200, Vincent Whitchurch wrote:
> v2:
> - [..]
> - Stop PWM before unregister
I didn't take the time yet to look at v2, but just spotted this which is
wrong. .remove() is not supposed to modify the output. (If the PWM is
still running in .remove() this is either because it was running at
bootup and was never modified or is a bug in the consumer code.)
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-09-05 16:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 12:12 [PATCH v2 0/2] GPIO PWM driver Vincent Whitchurch
2020-09-02 12:12 ` [PATCH v2 1/2] dt-bindings: pwm: Add pwm-gpio Vincent Whitchurch
2020-09-14 20:16 ` Rob Herring
2020-09-02 12:12 ` [PATCH v2 2/2] pwm: Add GPIO PWM driver Vincent Whitchurch
2020-09-05 16:42 ` Uwe Kleine-König [this message]
2020-09-15 13:54 ` [PATCH v2 0/2] " Vincent Whitchurch
2020-09-16 6:00 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200905164249.5vy23gizpwstbs5c@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=kernel@axis.com \
--cc=lee.jones@linaro.org \
--cc=linux-pwm@vger.kernel.org \
--cc=oliver@schinagl.nl \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=vincent.whitchurch@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.