All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/3] package/python-piexif : new package
Date: Sat, 5 Sep 2020 23:22:04 +0200	[thread overview]
Message-ID: <20200905232204.35d56f14@windsurf.home> (raw)
In-Reply-To: <20200901143731.2916-3-jugurtha.belkalem@smile.fr>

On Tue,  1 Sep 2020 16:37:30 +0200
Jugurtha BELKALEM <jugurtha.belkalem@smile.fr> wrote:

> diff --git a/package/python-piexif/Config.in b/package/python-piexif/Config.in
> new file mode 100644
> index 0000000000..aad42cbaeb
> --- /dev/null
> +++ b/package/python-piexif/Config.in
> @@ -0,0 +1,10 @@
> +config BR2_PACKAGE_PYTHON_PIEXIF
> +	bool "python-piexif"
> +	depends on BR2_PACKAGE_PYTHON3
> +	select BR2_PACKAGE_PYTHON_PILLOW

Looking at the code, I didn't really see where pillow is mandatory.
Apparently, you can pass images opened to pillow, but you don't have
to. So I dropped this "select". Of course, if that's incorrect, let me
know, and we can fix it.

> +	help
> +	  To simplify exif manipulations with Python.
> +	  Writing, reading, and more? Piexif is pure Python.
> +	  To everywhere with Python.

This description (from their github) is not super useful, I've instead
taken the description from their documentation, which is a bit more
sensible.

> +sha256	c9d2e27b56e1c47bb99ffac43d61077019dc54015d5e34d0e84411cce3d1bbde  LICENSE.txt

This hash was incorrect and didn't match the actual license file.

I fixed those issues, and applied. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2020-09-05 21:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-01 14:37 [Buildroot] [PATCH 0/3] package/python-stegano Jugurtha BELKALEM
2020-09-01 14:37 ` [Buildroot] [PATCH 1/3] package/python-crayons : new package Jugurtha BELKALEM
2020-09-05 21:20   ` Thomas Petazzoni
2020-09-01 14:37 ` [Buildroot] [PATCH 2/3] package/python-piexif " Jugurtha BELKALEM
2020-09-05 21:22   ` Thomas Petazzoni [this message]
2020-09-01 14:37 ` [Buildroot] [PATCH 3/3] package/python-stegano " Jugurtha BELKALEM
2020-09-05 21:25   ` Thomas Petazzoni
2022-01-06 19:22     ` Romain Naour

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200905232204.35d56f14@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.